diff options
| author | Jakub Hrozek <jhrozek@redhat.com> | 2014-07-07 21:29:05 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-07-08 20:28:09 +0200 |
| commit | 34de8a00f5b480ef3f46d2516e072e4acf1ebf87 (patch) | |
| tree | 82ee2b904a8c8ef0569122a97d39b83a0ece888d /src/providers/ldap/sdap.c | |
| parent | 004b3589f85808bcfcb0019aa92e47d3ce4017c9 (diff) | |
| download | sssd-34de8a00f5b480ef3f46d2516e072e4acf1ebf87.tar.gz sssd-34de8a00f5b480ef3f46d2516e072e4acf1ebf87.tar.xz sssd-34de8a00f5b480ef3f46d2516e072e4acf1ebf87.zip | |
LDAP: Remove unused output parameter _dn from sdap_parse_entry
No caller directly accessed this parameter. Moreover, it seemed useless
since the same data is available as SYSDB_ORIGINAL_DN in the attributes.
Reviewed-by: Michal Židek <mzidek@redhat.com>
Diffstat (limited to 'src/providers/ldap/sdap.c')
| -rw-r--r-- | src/providers/ldap/sdap.c | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/src/providers/ldap/sdap.c b/src/providers/ldap/sdap.c index 4c364df73..4bb701187 100644 --- a/src/providers/ldap/sdap.c +++ b/src/providers/ldap/sdap.c @@ -293,7 +293,7 @@ int sdap_get_map(TALLOC_CTX *memctx, int sdap_parse_entry(TALLOC_CTX *memctx, struct sdap_handle *sh, struct sdap_msg *sm, struct sdap_attr_map *map, int attrs_num, - struct sysdb_attrs **_attrs, char **_dn, + struct sysdb_attrs **_attrs, bool disable_range_retrieval) { struct sysdb_attrs *attrs; @@ -307,7 +307,6 @@ int sdap_parse_entry(TALLOC_CTX *memctx, bool store; bool base64; char *base_attr; - char *dn = NULL; uint32_t range_offset; TALLOC_CTX *tmp_ctx = talloc_new(NULL); if (!tmp_ctx) return ENOMEM; @@ -336,16 +335,8 @@ int sdap_parse_entry(TALLOC_CTX *memctx, DEBUG(SSSDBG_TRACE_LIBS, "OriginalDN: [%s].\n", str); ret = sysdb_attrs_add_string(attrs, SYSDB_ORIG_DN, str); - if (ret) goto done; - if (_dn) { - dn = talloc_strdup(tmp_ctx, str); - if (!dn) { - ret = ENOMEM; - ldap_memfree(str); - goto done; - } - } ldap_memfree(str); + if (ret) goto done; if (map) { vals = ldap_get_values_len(sh->ldap, sm->msg, "objectClass"); @@ -523,7 +514,6 @@ int sdap_parse_entry(TALLOC_CTX *memctx, } *_attrs = talloc_steal(memctx, attrs); - if (_dn) *_dn = talloc_steal(memctx, dn); ret = EOK; done: |