Disable connection callbacks when going online

Under certain circumstances, the openldap libraries will continue
internally trying to reconnect to a connection lost (as during a
cable-pull test). We need to drop the reconnection callbacks when
marking the backend offline in order to guarantee that they are
not called with an invalid sdap_handle.

1 files changed, 10 insertions, 0 deletions

diff --git a/src/providers/ldap/ldap_common.c b/src/providers/ldap/ldap_common.c
index 0257ef638..78bcac2db 100644
--- a/src/providers/ldap/ldap_common.c
+++ b/src/providers/ldap/ldap_common.c
@@ -24,6 +24,7 @@
 
 #include "providers/ldap/ldap_common.h"
 #include "providers/fail_over.h"
+#include "providers/ldap/sdap_async_private.h"
 
 #include "util/sss_krb5.h"
 
@@ -358,10 +359,19 @@ bool sdap_connected(struct sdap_id_ctx *ctx)
 
 void sdap_mark_offline(struct sdap_id_ctx *ctx)
 {
+    int ret;
+
     if (ctx->gsh) {
         /* make sure we mark the connection as gone when we go offline so that
          * we do not try to reuse a bad connection by mistale later */
         ctx->gsh->connected = false;
+        ret = remove_ldap_connection_callbacks(ctx->gsh);
+        if (ret != EOK) {
+            DEBUG(1, ("Could not clear ldap connection callbacks\n"));
+            /* Not really anything we can do about this, so proceed
+             * and hope for the best.
+             */
+        }
     }
 
     be_mark_offline(ctx->be);