diff options
author | Lukas Slebodnik <lslebodn@redhat.com> | 2013-10-14 11:21:02 +0200 |
---|---|---|
committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-11-28 16:06:11 +0100 |
commit | 466f5a539be1e4c6e7cfb396a2f406e1eb8c428d (patch) | |
tree | 32ca6fb17899002df59ac5348c7086ad3b65bef9 /src/providers/krb5 | |
parent | 2dc519ba98ca886076ba9e16b95a72732909cea1 (diff) | |
download | sssd-466f5a539be1e4c6e7cfb396a2f406e1eb8c428d.tar.gz sssd-466f5a539be1e4c6e7cfb396a2f406e1eb8c428d.tar.xz sssd-466f5a539be1e4c6e7cfb396a2f406e1eb8c428d.zip |
krb5: Check return value of sss_krb5_princ_realm
sss_krb5_princ_realm set output parameter realm to NULL and len to 0
in case of failure. Clang static analysers reported warning
"Null pointer passed as an argument to a 'nonnull' parameter"
in function match_principal. It was possible, that realm_name with value NULL
could be used in strncmp.
Reviewed-by: Pavel Reichl <preichl@redhat.com>
Diffstat (limited to 'src/providers/krb5')
-rw-r--r-- | src/providers/krb5/krb5_ccache.c | 5 | ||||
-rw-r--r-- | src/providers/krb5/krb5_child.c | 8 |
2 files changed, 13 insertions, 0 deletions
diff --git a/src/providers/krb5/krb5_ccache.c b/src/providers/krb5/krb5_ccache.c index 7aa36b744..8da562b50 100644 --- a/src/providers/krb5/krb5_ccache.c +++ b/src/providers/krb5/krb5_ccache.c @@ -574,6 +574,11 @@ errno_t get_ccache_file_data(const char *ccache_file, const char *client_name, } sss_krb5_princ_realm(ctx, client_princ, &realm_name, &realm_length); + if (realm_length == 0) { + kerr = KRB5KRB_ERR_GENERIC; + DEBUG(SSSDBG_CRIT_FAILURE, "sss_krb5_princ_realm failed.\n"); + goto done; + } server_name = talloc_asprintf(NULL, "krbtgt/%.*s@%.*s", realm_length, realm_name, diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c index 94cd34e43..ec22665b5 100644 --- a/src/providers/krb5/krb5_child.c +++ b/src/providers/krb5/krb5_child.c @@ -974,6 +974,10 @@ static krb5_error_code get_and_save_tgt(struct krb5_req *kr, } sss_krb5_princ_realm(kr->ctx, kr->princ, &realm_name, &realm_length); + if (realm_length == 0) { + DEBUG(SSSDBG_CRIT_FAILURE, "sss_krb5_princ_realm failed.\n"); + return KRB5KRB_ERR_GENERIC; + } DEBUG(SSSDBG_TRACE_FUNC, "Attempting kinit for realm [%s]\n",realm_name); @@ -1136,6 +1140,10 @@ static errno_t changepw_child(struct krb5_req *kr, bool prelim) set_changepw_options(kr->options); sss_krb5_princ_realm(kr->ctx, kr->princ, &realm_name, &realm_length); + if (realm_length == 0) { + DEBUG(SSSDBG_CRIT_FAILURE, "sss_krb5_princ_realm failed.\n"); + return ERR_INTERNAL; + } DEBUG(SSSDBG_TRACE_FUNC, "Attempting kinit for realm [%s]\n",realm_name); |