diff options
| author | Jakub Hrozek <jhrozek@redhat.com> | 2015-10-01 13:13:05 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-10-07 12:42:03 +0200 |
| commit | 309aa83d16b5919f727af04850bcd0799ba0962f (patch) | |
| tree | 8ba57574ae0a09f25a0087655be8af13fc348859 /src/providers/ipa | |
| parent | d8899526551cbfe112e0ecc8280003a8349fc531 (diff) | |
| download | sssd-309aa83d16b5919f727af04850bcd0799ba0962f.tar.gz sssd-309aa83d16b5919f727af04850bcd0799ba0962f.tar.xz sssd-309aa83d16b5919f727af04850bcd0799ba0962f.zip | |
AD: Provide common connection list construction functions
https://fedorahosted.org/sssd/ticket/2810
Provides a new AD common function ad_ldap_conn_list() that creates a
list of AD connection to use along with properties to avoid mistakes
when manually constructing these lists.
Reviewed-by: Sumit Bose <sbose@redhat.com>
Diffstat (limited to 'src/providers/ipa')
| -rw-r--r-- | src/providers/ipa/ipa_subdomains_id.c | 21 |
1 files changed, 8 insertions, 13 deletions
diff --git a/src/providers/ipa/ipa_subdomains_id.c b/src/providers/ipa/ipa_subdomains_id.c index 8f13608bc..472985d4a 100644 --- a/src/providers/ipa/ipa_subdomains_id.c +++ b/src/providers/ipa/ipa_subdomains_id.c @@ -641,21 +641,16 @@ ipa_get_ad_acct_send(TALLOC_CTX *mem_ctx, case BE_REQ_BY_SECID: case BE_REQ_GROUP: clist = ad_gc_conn_list(req, ad_id_ctx, state->obj_dom); - if (clist == NULL) { - ret = ENOMEM; - goto fail; - } - clist[1]->ignore_mark_offline = true; break; default: - clist = talloc_zero_array(req, struct sdap_id_conn_ctx *, 2); - if (clist == NULL) { - ret = ENOMEM; - goto fail; - } - clist[0] = ad_id_ctx->ldap_ctx; - clist[0]->ignore_mark_offline = true; - clist[1] = NULL; + clist = ad_ldap_conn_list(req, ad_id_ctx, state->obj_dom); + break; + } + + if (clist == NULL) { + DEBUG(SSSDBG_OP_FAILURE, "Cannot generate AD connection list!\n"); + ret = ENOMEM; + goto fail; } /* Now we already need ad_id_ctx in particular sdap_id_conn_ctx */ |