diff options
| author | Sumit Bose <sbose@redhat.com> | 2014-10-20 17:09:34 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-10-22 12:38:50 +0200 |
| commit | bc85b7e2b7b1569e64d8832c52cab9ad165e6fc1 (patch) | |
| tree | b5ba68d1df47a943b35bcdd942b663cb15ddf753 /src/providers/ipa | |
| parent | 44329653f423c632b027065a9c0ea0bf4199396a (diff) | |
| download | sssd-bc85b7e2b7b1569e64d8832c52cab9ad165e6fc1.tar.gz sssd-bc85b7e2b7b1569e64d8832c52cab9ad165e6fc1.tar.xz sssd-bc85b7e2b7b1569e64d8832c52cab9ad165e6fc1.zip | |
ipa: improve error reporting for extdom LDAP exop
This patch fixes a typo when calling ldap_parse_result() which prevented
the server-side error message to be used and adds a hint that more
information might be available on the server side.
Fixes: https://fedorahosted.org/sssd/ticket/2456
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Diffstat (limited to 'src/providers/ipa')
| -rw-r--r-- | src/providers/ipa/ipa_s2n_exop.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/providers/ipa/ipa_s2n_exop.c b/src/providers/ipa/ipa_s2n_exop.c index 96528816a..bd5c00b6a 100644 --- a/src/providers/ipa/ipa_s2n_exop.c +++ b/src/providers/ipa/ipa_s2n_exop.c @@ -133,7 +133,7 @@ static void ipa_s2n_exop_done(struct sdap_op *op, } ret = ldap_parse_result(state->sh->ldap, reply->msg, - &result, &errmsg, NULL, NULL, + &result, NULL, &errmsg, NULL, NULL, 0); if (ret != LDAP_SUCCESS) { DEBUG(SSSDBG_OP_FAILURE, "ldap_parse_result failed (%d)\n", @@ -142,10 +142,13 @@ static void ipa_s2n_exop_done(struct sdap_op *op, goto done; } - DEBUG(SSSDBG_TRACE_FUNC, "ldap_extended_operation result: %s(%d), %s\n", - sss_ldap_err2string(result), result, errmsg); + DEBUG(result == LDAP_SUCCESS ? SSSDBG_TRACE_FUNC : SSSDBG_OP_FAILURE, + "ldap_extended_operation result: %s(%d), %s.\n", + sss_ldap_err2string(result), result, errmsg); if (result != LDAP_SUCCESS) { + DEBUG(SSSDBG_OP_FAILURE, "ldap_extended_operation failed, " \ + "server logs might contain more details.\n"); ret = ERR_NETWORK_IO; goto done; } |