AD: Split off ad_create_default_options

Related:
    https://fedorahosted.org/sssd/ticket/2638

Make the function reusable and add a simple unit test.

Reviewed-by: Sumit Bose <sbose@redhat.com>

1 files changed, 15 insertions, 3 deletions

diff --git a/src/providers/ad/ad_common.c b/src/providers/ad/ad_common.c
index e945958fc..60b234dc2 100644
--- a/src/providers/ad/ad_common.c
+++ b/src/providers/ad/ad_common.c
@@ -108,9 +108,7 @@ fail:
 }
 
 struct ad_options *
-ad_create_2way_trust_options(TALLOC_CTX *mem_ctx,
-                             const char *realm,
-                             const char *hostname)
+ad_create_default_options(TALLOC_CTX *mem_ctx)
 {
     struct ad_options *ad_options;
     errno_t ret;
@@ -134,6 +132,20 @@ ad_create_2way_trust_options(TALLOC_CTX *mem_ctx,
         return NULL;
     }
 
+    return ad_options;
+}
+
+struct ad_options *
+ad_create_2way_trust_options(TALLOC_CTX *mem_ctx,
+                             const char *realm,
+                             const char *hostname)
+{
+    struct ad_options *ad_options;
+    errno_t ret;
+
+    ad_options = ad_create_default_options(mem_ctx);
+    if (ad_options == NULL) return NULL;
+
     ret = dp_opt_set_string(ad_options->basic, AD_KRB5_REALM, realm);
     if (ret != EOK) {
         DEBUG(SSSDBG_OP_FAILURE, "Cannot set AD domain\n");