diff options
| author | Sumit Bose <sbose@redhat.com> | 2014-10-29 15:20:12 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-11-05 18:54:26 +0100 |
| commit | 61b6c497901004e34f1bdf6d3c04c2943720a500 (patch) | |
| tree | 3dcacfea06af28481c321bbfcb2e407ce141d64c /src/ldb_modules | |
| parent | 07ca52cf9c0727c42880ed03b4ffb3e6c5f7b97d (diff) | |
| download | sssd-61b6c497901004e34f1bdf6d3c04c2943720a500.tar.gz sssd-61b6c497901004e34f1bdf6d3c04c2943720a500.tar.xz sssd-61b6c497901004e34f1bdf6d3c04c2943720a500.zip | |
memberof: check for empty arrays to avoid segfaults
The arrays with members to add or delete may be empty, i.e. have 0
entries. In this case further processing should be skipped to avoid
segfaults later on.
Fixes (hopefully) https://fedorahosted.org/sssd/ticket/2430
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Diffstat (limited to 'src/ldb_modules')
| -rw-r--r-- | src/ldb_modules/memberof.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/ldb_modules/memberof.c b/src/ldb_modules/memberof.c index ceeba0e47..995c382a8 100644 --- a/src/ldb_modules/memberof.c +++ b/src/ldb_modules/memberof.c @@ -3654,7 +3654,7 @@ static int mbof_mod_add(struct mbof_mod_ctx *mod_ctx, } } - if (ael != NULL) { + if (ael != NULL && ael->num > 0) { /* Add itself to the list of the parents to also get the memberuid */ parents->dns = talloc_realloc(parents, parents->dns, struct ldb_dn *, parents->num + 1); @@ -3724,7 +3724,7 @@ static int mbof_mod_delete(struct mbof_mod_ctx *mod_ctx, } /* prepare del sets */ - if (del != NULL) { + if (del != NULL && del->num > 0) { for (i = 0; i < del->num; i++) { ret = mbof_append_delop(first, del->dns[i]); if (ret != LDB_SUCCESS) { |