diff options
| author | Simo Sorce <ssorce@redhat.com> | 2009-09-08 14:36:11 -0400 |
|---|---|---|
| committer | Stephen Gallagher <sgallagh@redhat.com> | 2009-09-08 15:10:49 -0400 |
| commit | aef967dc115c64f0288b8ecc3ff1d927aa42af70 (patch) | |
| tree | fe616b2927b13552453f9c900f30e5d23e096f14 /server | |
| parent | 8390c75752f96b55185e8be91896574723ffe4c7 (diff) | |
| download | sssd-aef967dc115c64f0288b8ecc3ff1d927aa42af70.tar.gz sssd-aef967dc115c64f0288b8ecc3ff1d927aa42af70.tar.xz sssd-aef967dc115c64f0288b8ecc3ff1d927aa42af70.zip | |
Fix two possible uninitialized values
Make counter for used messages explicit.
Diffstat (limited to 'server')
| -rw-r--r-- | server/providers/ldap/sdap_async.c | 2 | ||||
| -rw-r--r-- | server/responder/nss/nsssrv_cmd.c | 7 |
2 files changed, 5 insertions, 4 deletions
diff --git a/server/providers/ldap/sdap_async.c b/server/providers/ldap/sdap_async.c index e13fba348..550cb9d3f 100644 --- a/server/providers/ldap/sdap_async.c +++ b/server/providers/ldap/sdap_async.c @@ -1424,7 +1424,7 @@ static void sdap_get_users_save_done(struct tevent_req *subreq) struct tevent_req); struct sdap_get_users_state *state = tevent_req_data(req, struct sdap_get_users_state); - char *timestamp; + char *timestamp = NULL; int ret; ret = sdap_save_user_recv(subreq, state, ×tamp); diff --git a/server/responder/nss/nsssrv_cmd.c b/server/responder/nss/nsssrv_cmd.c index 88749e9e5..abd20a1b8 100644 --- a/server/responder/nss/nsssrv_cmd.c +++ b/server/responder/nss/nsssrv_cmd.c @@ -1368,7 +1368,7 @@ static int fill_grent(struct sss_packet *packet, size_t nsize; size_t delim; size_t dom_len; - int i, ret, num, memnum; + int i, ret, num, memnum, used; size_t rzero, rsize; bool add_domain = dom->fqnames; const char *domain = dom->name; @@ -1384,6 +1384,7 @@ static int fill_grent(struct sss_packet *packet, num = 0; memnum = 0; + used = 0; /* first 2 fields (len and reserved), filled up later */ ret = sss_packet_grow(packet, 2*sizeof(uint32_t)); @@ -1394,7 +1395,7 @@ static int fill_grent(struct sss_packet *packet, rzero = 2*sizeof(uint32_t); rsize = 0; - for (i = 0; i < *count; i++) { + for (i = 0; i < *count; i++, used++) { msg = msgs[i]; /* new group */ @@ -1607,7 +1608,7 @@ static int fill_grent(struct sss_packet *packet, } done: - *count = i; + *count = used; if (num == 0) { /* if num is 0 most probably something went wrong, |