diff options
| author | Dmitri Pal <dpal@redhat.com> | 2009-08-14 23:04:37 -0400 |
|---|---|---|
| committer | Stephen Gallagher <sgallagh@redhat.com> | 2009-08-20 15:47:34 -0400 |
| commit | 1069fb127a38d875d0ca2f56bfc936a97a964380 (patch) | |
| tree | d100388a5be8ef2926b80a6182f2cfc8e6d16c5c /common/collection/collection_queue.c | |
| parent | c7916d6b820bde690145450ba02209e741154866 (diff) | |
| download | sssd-1069fb127a38d875d0ca2f56bfc936a97a964380.tar.gz sssd-1069fb127a38d875d0ca2f56bfc936a97a964380.tar.xz sssd-1069fb127a38d875d0ca2f56bfc936a97a964380.zip | |
COMMON Fixes to return values, errno, leaks
Started looking at the ticket #107 related to
traverse functions. Realized that the return values
are not consistent. That ovelapped with the work
that I wanted to do for ticket #103 - errno cleanup.
So I (across collection, INI and ELAPI):
* Made the return codes consistent (where found)
* Removed errno where it is not needed
While was testing used valgrind and found a nasty
problem when the value was added to collection with
overwriting duplicates the count was decreased improperly.
Fixing collection.c to not decrease count made
valgrind happy. While I was debugging this
I also spotted several build warnings in trace
statements when the " exp ? v1 : v2 " was used.
Fixed those.
In ini_config.c there was a trace stament that used
variable after it was freed. Removed trace stament.
Diffstat (limited to 'common/collection/collection_queue.c')
| -rw-r--r-- | common/collection/collection_queue.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/collection/collection_queue.c b/common/collection/collection_queue.c index 35c59bc49..7e0683390 100644 --- a/common/collection/collection_queue.c +++ b/common/collection/collection_queue.c @@ -19,8 +19,8 @@ along with Collection Library. If not, see <http://www.gnu.org/licenses/>. */ -#include "stdlib.h" -#include "errno.h" +#include <stdlib.h> +#include <errno.h> #include "collection_queue.h" #include "trace.h" |