summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2015-09-02 13:42:06 +0200
committerJakub Hrozek <jhrozek@redhat.com>2015-09-21 17:04:04 +0200
commit7fc8692d49cdaa0368072f196433c07b475da679 (patch)
treec1ccb900eaf779c967d512a0550ade5e6fba86a6
parent0561d532cf76b035b73cfed929a6896071dac407 (diff)
downloadsssd-7fc8692d49cdaa0368072f196433c07b475da679.tar.gz
sssd-7fc8692d49cdaa0368072f196433c07b475da679.tar.xz
sssd-7fc8692d49cdaa0368072f196433c07b475da679.zip
AD: Only ignore errors from SDAP lookups if there's another connection to fallback to
Required for: https://fedorahosted.org/sssd/ticket/2637 The AD lookup code honors the ignore_mark_offline flag in the sense that if it's set, the sdap return code is not reported to the upper layer, but EOK is returned as request status and the sdap return code is returned separately. This patch modifies the behaviour further to only apply if there is another connection to fall back to. Reviewed-by: Pavel Březina <pbrezina@redhat.com>
-rw-r--r--src/providers/ad/ad_id.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/providers/ad/ad_id.c b/src/providers/ad/ad_id.c
index 7a0c6eccd..4f327f823 100644
--- a/src/providers/ad/ad_id.c
+++ b/src/providers/ad/ad_id.c
@@ -146,6 +146,7 @@ ad_handle_acct_info_done(struct tevent_req *subreq)
ret = sdap_handle_acct_req_recv(subreq, &dp_error, &err, &sdap_err);
if (dp_error == DP_ERR_OFFLINE
+ && state->conn[state->cindex+1] != NULL
&& state->conn[state->cindex]->ignore_mark_offline) {
/* This is a special case: GC does not work.
* We need to Fall back to ldap