summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2013-06-05 12:53:41 +0200
committerJakub Hrozek <jhrozek@redhat.com>2013-06-06 23:58:56 +0200
commit154e62fc712f4c994fbc684386302edca277a99a (patch)
treec5e41e2684adb563f30b29e527b6a774852da42a
parent92af6f25864b5c389b57d0f659686801b45ca58c (diff)
downloadsssd-154e62fc712f4c994fbc684386302edca277a99a.tar.gz
sssd-154e62fc712f4c994fbc684386302edca277a99a.tar.xz
sssd-154e62fc712f4c994fbc684386302edca277a99a.zip
Intermittent fix for get_user_and_group_users_done
users_get_recv() never returns ENOENT. In general it should return EOK in the case no matching user was found. But since I forget to handle a SID based filter properly in sdap_get_users_process() an error is returned in this case which makes get_user_and_group_users_done() work as expected with this patch. There is an upcoming enhancement to users_get_recv() which I'm planning to use for a full fix.
-rw-r--r--src/providers/ldap/ldap_id.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index 72fdd9c26..13b607ac3 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -1325,9 +1325,6 @@ static void get_user_and_group_users_done(struct tevent_req *subreq)
if (ret == EOK) { /* Matching user found */
tevent_req_done(req);
return;
- } else if (ret != ENOENT) {
- tevent_req_error(req, ret);
- return;
}
subreq = groups_get_send(req, state->ev, state->id_ctx, state->filter_val,