summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Gallagher <sgallagh@redhat.com>2010-12-16 14:39:00 -0500
committerStephen Gallagher <sgallagh@redhat.com>2010-12-17 07:07:40 -0500
commit7215ce30acdc19e95e31d83518a20f75eec74112 (patch)
treef01cfe27024df5018e1b3a3e5e5ed67b1c55bcb2
parent3da2609d20eb5cbb05f212e13baa040bf7cf02fa (diff)
downloadsssd-7215ce30acdc19e95e31d83518a20f75eec74112.tar.gz
sssd-7215ce30acdc19e95e31d83518a20f75eec74112.tar.xz
sssd-7215ce30acdc19e95e31d83518a20f75eec74112.zip
Fix unchecked return value in sss_krb5_verify_keytab_ex
https://fedorahosted.org/sssd/ticket/711
-rw-r--r--src/util/sss_krb5.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c
index 174b6d9fa..894dd443d 100644
--- a/src/util/sss_krb5.c
+++ b/src/util/sss_krb5.c
@@ -152,7 +152,14 @@ int sss_krb5_verify_keytab_ex(const char *principal, const char *keytab_name,
found = true;
}
free(kt_principal);
- krb5_free_keytab_entry_contents(context, &entry);
+ krberr = krb5_free_keytab_entry_contents(context, &entry);
+ if (krberr) {
+ /* This should never happen. The API docs for this function
+ * specify only success for this function
+ */
+ DEBUG(1,("Could not free keytab entry contents\n"));
+ /* This is non-fatal, so we'll continue here */
+ }
if (found) {
break;