diff options
author | Stephen Gallagher <sgallagh@redhat.com> | 2010-06-09 09:44:47 -0400 |
---|---|---|
committer | Stephen Gallagher <sgallagh@redhat.com> | 2010-06-10 10:17:21 -0400 |
commit | 13cdd7f5f49ae0241cc5ff7395c8e3759246a432 (patch) | |
tree | 3fb467b1cb0667ec0404aa3d63ad5bbf300c8eed | |
parent | 0b67f531ca2c0a632e3b2c12095fb005ff528fa8 (diff) | |
download | sssd-13cdd7f5f49ae0241cc5ff7395c8e3759246a432.tar.gz sssd-13cdd7f5f49ae0241cc5ff7395c8e3759246a432.tar.xz sssd-13cdd7f5f49ae0241cc5ff7395c8e3759246a432.zip |
Avoid potential NULL dereference
https://fedorahosted.org/sssd/ticket/506
-rw-r--r-- | src/providers/ipa/ipa_auth.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/providers/ipa/ipa_auth.c b/src/providers/ipa/ipa_auth.c index 16bb407ea..283196dc3 100644 --- a/src/providers/ipa/ipa_auth.c +++ b/src/providers/ipa/ipa_auth.c @@ -233,6 +233,7 @@ void ipa_auth(struct be_req *be_req) { struct tevent_req *req; struct ipa_auth_state *state; + struct pam_data *pd = talloc_get_type(be_req->req_data, struct pam_data); state = talloc_zero(be_req, struct ipa_auth_state); if (state == NULL) { @@ -246,7 +247,7 @@ void ipa_auth(struct be_req *be_req) state->be_req = be_req; state->ev = be_req->be_ctx->ev; - state->pd = talloc_get_type(be_req->req_data, struct pam_data); + state->pd = pd; switch (state->pd->cmd) { case SSS_PAM_AUTHENTICATE: @@ -276,8 +277,9 @@ void ipa_auth(struct be_req *be_req) return; fail: - state->pd->pam_status = PAM_SYSTEM_ERR; - ipa_auth_reply(be_req, DP_ERR_FATAL, state->pd->pam_status); + talloc_free(state); + pd->pam_status = PAM_SYSTEM_ERR; + ipa_auth_reply(be_req, DP_ERR_FATAL, pd->pam_status); } static void ipa_auth_handler_done(struct tevent_req *req) |