summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Gallagher <sgallagh@redhat.com>2010-06-09 09:54:11 -0400
committerStephen Gallagher <sgallagh@redhat.com>2010-06-10 10:17:21 -0400
commita05ee9b926d398318e36944813a313bdff5eb999 (patch)
tree75390a9113d9a722b7abc3a12a1c6fa5210d434c
parent13cdd7f5f49ae0241cc5ff7395c8e3759246a432 (diff)
downloadsssd-a05ee9b926d398318e36944813a313bdff5eb999.tar.gz
sssd-a05ee9b926d398318e36944813a313bdff5eb999.tar.xz
sssd-a05ee9b926d398318e36944813a313bdff5eb999.zip
Properly handle missing originalMemberOf entry in initgroups
Failing to return after the tevent_req_post() here can result in a null-pointer dereference (along with other hard-to-track bugs) https://fedorahosted.org/sssd/ticket/507
-rw-r--r--src/providers/ldap/sdap_async_accounts.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/providers/ldap/sdap_async_accounts.c b/src/providers/ldap/sdap_async_accounts.c
index abebe2883..c5c3a5072 100644
--- a/src/providers/ldap/sdap_async_accounts.c
+++ b/src/providers/ldap/sdap_async_accounts.c
@@ -1660,6 +1660,7 @@ static struct tevent_req *sdap_initgr_nested_send(TALLOC_CTX *memctx,
/* user with no groups ? */
tevent_req_error(req, ENOENT);
tevent_req_post(req, ev);
+ return req;
}
state->count = el->num_values;