summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2010-06-10 11:16:16 +0200
committerStephen Gallagher <sgallagh@redhat.com>2010-06-14 16:54:42 -0400
commit51420d01e19549c202af9a4ed20ea120bd27c010 (patch)
tree868114f3383267ad2b6535f6a69f55f283608730
parentbae7e43b7fe602beba8952ad9d25e059773e8860 (diff)
downloadsssd-51420d01e19549c202af9a4ed20ea120bd27c010.tar.gz
sssd-51420d01e19549c202af9a4ed20ea120bd27c010.tar.xz
sssd-51420d01e19549c202af9a4ed20ea120bd27c010.zip
Potential memory leak in _nss_sss_*_r()
Fixes: #516
-rw-r--r--src/sss_client/group.c3
-rw-r--r--src/sss_client/passwd.c2
2 files changed, 5 insertions, 0 deletions
diff --git a/src/sss_client/group.c b/src/sss_client/group.c
index e1b36e2a4..60b4611c2 100644
--- a/src/sss_client/group.c
+++ b/src/sss_client/group.c
@@ -235,6 +235,7 @@ enum nss_status _nss_sss_initgroups_dyn(const char *user, gid_t group,
*start += 1;
}
+ free(repbuf);
return NSS_STATUS_SUCCESS;
}
@@ -274,6 +275,7 @@ enum nss_status _nss_sss_getgrnam_r(const char *name, struct group *result,
/* only 1 result is accepted for this function */
if (((uint32_t *)repbuf)[0] != 1) {
*errnop = EBADMSG;
+ free(repbuf);
return NSS_STATUS_TRYAGAIN;
}
@@ -325,6 +327,7 @@ enum nss_status _nss_sss_getgrgid_r(gid_t gid, struct group *result,
/* only 1 result is accepted for this function */
if (((uint32_t *)repbuf)[0] != 1) {
*errnop = EBADMSG;
+ free(repbuf);
return NSS_STATUS_TRYAGAIN;
}
diff --git a/src/sss_client/passwd.c b/src/sss_client/passwd.c
index aa5c76023..95c7de619 100644
--- a/src/sss_client/passwd.c
+++ b/src/sss_client/passwd.c
@@ -208,6 +208,7 @@ enum nss_status _nss_sss_getpwnam_r(const char *name, struct passwd *result,
/* only 1 result is accepted for this function */
if (((uint32_t *)repbuf)[0] != 1) {
*errnop = EBADMSG;
+ free(repbuf);
return NSS_STATUS_TRYAGAIN;
}
@@ -259,6 +260,7 @@ enum nss_status _nss_sss_getpwuid_r(uid_t uid, struct passwd *result,
/* only 1 result is accepted for this function */
if (((uint32_t *)repbuf)[0] != 1) {
*errnop = EBADMSG;
+ free(repbuf);
return NSS_STATUS_TRYAGAIN;
}