diff options
| author | Sumit Bose <sbose@redhat.com> | 2015-01-29 20:31:19 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-01-30 15:55:05 +0100 |
| commit | e3e6a3f87496667bf6456de8855ff831bf222abb (patch) | |
| tree | dcb6155340f251358194a577187cae7da632f42c | |
| parent | 8b61b994f95f351d7036f4748e5c6f467698f6ae (diff) | |
| download | sssd-e3e6a3f87496667bf6456de8855ff831bf222abb.tar.gz sssd-e3e6a3f87496667bf6456de8855ff831bf222abb.tar.xz sssd-e3e6a3f87496667bf6456de8855ff831bf222abb.zip | |
fill_id() fix LE/BE issue with wrong data type
Related to https://fedorahosted.org/sssd/ticket/1588
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
(cherry picked from commit 866ab45027c83fafb7f7f45d34d3e1e7721b77dc)
| -rw-r--r-- | src/responder/nss/nsssrv_cmd.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c index 93b220cc8..1affde874 100644 --- a/src/responder/nss/nsssrv_cmd.c +++ b/src/responder/nss/nsssrv_cmd.c @@ -4867,18 +4867,20 @@ static errno_t fill_id(struct sss_packet *packet, uint8_t *body; size_t blen; size_t pctr = 0; - uint64_t id; + uint64_t tmp_id; + uint32_t id; if (id_type == SSS_ID_TYPE_GID) { - id = ldb_msg_find_attr_as_uint64(msg, SYSDB_GIDNUM, 0); + tmp_id = ldb_msg_find_attr_as_uint64(msg, SYSDB_GIDNUM, 0); } else { - id = ldb_msg_find_attr_as_uint64(msg, SYSDB_UIDNUM, 0); + tmp_id = ldb_msg_find_attr_as_uint64(msg, SYSDB_UIDNUM, 0); } - if (id == 0 || id >= UINT32_MAX) { + if (tmp_id == 0 || tmp_id >= UINT32_MAX) { DEBUG(SSSDBG_CRIT_FAILURE, "Invalid POSIX ID.\n"); return EINVAL; } + id = (uint32_t) tmp_id; ret = sss_packet_grow(packet, 4 * sizeof(uint32_t)); if (ret != EOK) { |