diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-05-24 19:36:54 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-05-26 16:56:27 +0200 |
| commit | aad67c44ecebb6a674a280fa5f00cbc0a68e9052 (patch) | |
| tree | 70194419c243880b0403a6ad9b6d86d3460a466f | |
| parent | 80c092f94a7ac24ea00e560201e37ae27cfbf665 (diff) | |
| download | sssd-aad67c44ecebb6a674a280fa5f00cbc0a68e9052.tar.gz sssd-aad67c44ecebb6a674a280fa5f00cbc0a68e9052.tar.xz sssd-aad67c44ecebb6a674a280fa5f00cbc0a68e9052.zip | |
UTIL: Include netinet/in.h for ip adress macros
The manual page in.h (man in.h) says:
The <netinet/in.h> header shall define the in6_addr structure that con‐
tains at least the following member:
uint8_t s6_addr[16]
The <netinet/in.h> header shall define the following macros that test
for special IPv6 addresses. Each macro is of type int and takes a sin‐
gle argument of type const struct in6_addr *:
IN6_IS_ADDR_LINKLOCAL: Unicast link-local address.
IN6_IS_ADDR_LOOPBACK: Loopback address.
IN6_IS_ADDR_MULTICAST: Multicast address.
The header file netinet/in.h> was not included directly in src/util/util.c
and it caused few problems.
./src/util/util.h:378: warning: 'struct in6_addr' declared inside parameter list
./src/util/util.h:378: warning: its scope is only this definition or declaration, which is probably not what you want
src/util/util.c: In function 'check_ipv4_addr':
src/util/util.c:765: error: implicit declaration of function 'IN_MULTICAST'
src/util/util.c:769: error: 'IN_LOOPBACKNET' undeclared (first use in this function)
src/util/util.c:769: error: (Each undeclared identifier is reported only once
src/util/util.c:769: error: for each function it appears in.)
src/util/util.c:778: error: 'INADDR_BROADCAST' undeclared (first use in this function)
src/util/util.c: At top level:
src/util/util.c:786: warning: 'struct in6_addr' declared inside parameter list
src/util/util.c:787: error: conflicting types for 'check_ipv6_addr'
./src/util/util.h:378: error: previous declaration of 'check_ipv6_addr' was here
src/util/util.c: In function 'check_ipv6_addr':
src/util/util.c:796: error: implicit declaration of function 'IN6_IS_ADDR_LINKLOCAL'
src/util/util.c:799: error: implicit declaration of function 'IN6_IS_ADDR_LOOPBACK'
src/util/util.c:802: error: implicit declaration of function 'IN6_IS_ADDR_MULTICAST'
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
| -rw-r--r-- | src/util/util.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/util/util.h b/src/util/util.h index 54c6c6c78..f682f50fe 100644 --- a/src/util/util.h +++ b/src/util/util.h @@ -38,6 +38,7 @@ #include <sys/types.h> #include <sys/stat.h> #include <arpa/inet.h> +#include <netinet/in.h> #include <talloc.h> #include <tevent.h> |