summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2014-04-21 17:04:24 +0200
committerJakub Hrozek <jhrozek@redhat.com>2014-06-03 13:31:16 +0200
commit7daf068c4bbf581a898891e130c244eb9707b32a (patch)
tree986a285e1adc3eeae502f0c9620931031317b7bb
parentd37429aa532943fdb6ce6568b3d3176013a6b378 (diff)
downloadsssd-7daf068c4bbf581a898891e130c244eb9707b32a.tar.gz
sssd-7daf068c4bbf581a898891e130c244eb9707b32a.tar.xz
sssd-7daf068c4bbf581a898891e130c244eb9707b32a.zip
SBUS: several trivial style fixes
In SSSD we tend to use {} brackets around single-line blocks, too to make sure we don't forget to add them should the block become larger. We also don't add a space between function name and the opening "(". Reviewed-by: Pavel Březina <pbrezina@redhat.com> Reviewed-by: Stef Walter <stefw@redhat.com> (cherry picked from commit 3d5908ed0faf400a5c7d9c3e4312597ee1b7786a)
-rw-r--r--src/sbus/sssd_dbus_connection.c2
-rw-r--r--src/sbus/sssd_dbus_meta.c9
-rw-r--r--src/sbus/sssd_dbus_request.c4
3 files changed, 9 insertions, 6 deletions
diff --git a/src/sbus/sssd_dbus_connection.c b/src/sbus/sssd_dbus_connection.c
index ab18049f8..da7f8dc86 100644
--- a/src/sbus/sssd_dbus_connection.c
+++ b/src/sbus/sssd_dbus_connection.c
@@ -301,7 +301,7 @@ DBusConnection *sbus_get_connection(struct sbus_connection *conn)
return conn->dbus.conn;
}
-void sbus_disconnect (struct sbus_connection *conn)
+void sbus_disconnect(struct sbus_connection *conn)
{
if (conn == NULL) {
return;
diff --git a/src/sbus/sssd_dbus_meta.c b/src/sbus/sssd_dbus_meta.c
index 57123b743..76e192f71 100644
--- a/src/sbus/sssd_dbus_meta.c
+++ b/src/sbus/sssd_dbus_meta.c
@@ -28,8 +28,9 @@ sbus_meta_find_method(const struct sbus_interface_meta *interface,
const struct sbus_method_meta *method;
for (method = interface->methods; method && method->name; method++) {
- if (strcmp(method_name, method->name) == 0)
+ if (strcmp(method_name, method->name) == 0) {
return method;
+ }
}
return NULL;
@@ -42,8 +43,9 @@ sbus_meta_find_signal(const struct sbus_interface_meta *interface,
const struct sbus_signal_meta *signal;
for (signal = interface->signals; signal && signal->name; signal++) {
- if (strcmp(signal_name, signal->name) == 0)
+ if (strcmp(signal_name, signal->name) == 0) {
return signal;
+ }
}
return NULL;
@@ -56,8 +58,9 @@ sbus_meta_find_property(const struct sbus_interface_meta *interface,
const struct sbus_property_meta *property;
for (property = interface->properties; property && property->name; property++) {
- if (strcmp(property_name, property->name) == 0)
+ if (strcmp(property_name, property->name) == 0) {
return property;
+ }
}
return NULL;
diff --git a/src/sbus/sssd_dbus_request.c b/src/sbus/sssd_dbus_request.c
index 387691dea..342d8dfd2 100644
--- a/src/sbus/sssd_dbus_request.c
+++ b/src/sbus/sssd_dbus_request.c
@@ -185,7 +185,7 @@ parent_dbus_string_arrays(struct sbus_request *request, int first_arg_type,
arg_type == DBUS_TYPE_SIGNATURE) {
array_arg = talloc_zero(request, struct array_arg);
- if(array_arg == NULL) {
+ if (array_arg == NULL) {
/* no kidding ... */
DEBUG(SSSDBG_CRIT_FAILURE, "Out of memory while trying not to leak memory\n");
return false;
@@ -222,7 +222,7 @@ sbus_request_parse_or_finish(struct sbus_request *request,
if (dbus_message_get_args_valist(request->message, &error,
first_arg_type, va)) {
- ret = parent_dbus_string_arrays (request, first_arg_type, va2);
+ ret = parent_dbus_string_arrays(request, first_arg_type, va2);
} else {
/* Trying to send the error back to the caller in this case is a joke */