summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Gallagher <sgallagh@redhat.com>2012-02-29 10:37:41 -0500
committerStephen Gallagher <sgallagh@redhat.com>2012-03-01 10:20:46 -0500
commit24b34aaa810a1bf641f19b714a80f66f97f1b1a3 (patch)
tree88fb5b8728cc88cdd9e127767daf3bf262cd1311
parentadf987941cc1a7b43678d4ab1443acb069db8444 (diff)
downloadsssd-24b34aaa810a1bf641f19b714a80f66f97f1b1a3.tar.gz
sssd-24b34aaa810a1bf641f19b714a80f66f97f1b1a3.tar.xz
sssd-24b34aaa810a1bf641f19b714a80f66f97f1b1a3.zip
Handle cases where UID is -1
Also removes an unnecessary range check (since it's already handled by strtoint32() https://fedorahosted.org/sssd/ticket/1216
-rw-r--r--src/util/find_uid.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/util/find_uid.c b/src/util/find_uid.c
index f4156ce76..77b9f22a8 100644
--- a/src/util/find_uid.c
+++ b/src/util/find_uid.c
@@ -137,7 +137,7 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid)
} else {
*e = '\0';
}
- num = strtouint32(p, &endptr, 10);
+ num = (uint32_t) strtoint32(p, &endptr, 10);
error = errno;
if (error != 0) {
DEBUG(1, ("strtol failed [%s].\n", strerror(error)));
@@ -148,11 +148,6 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid)
return EINVAL;
}
- if (num >= UINT32_MAX) {
- DEBUG(1, ("uid out of range.\n"));
- return ERANGE;
- }
-
} else {
DEBUG(1, ("format error\n"));
return EINVAL;