diff options
| author | Stephen Gallagher <sgallagh@redhat.com> | 2015-06-11 09:17:02 -0400 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-06-23 15:43:07 +0200 |
| commit | b08b6a994dcca108bb571458da092e0e320ce9c2 (patch) | |
| tree | ae6d12b908d208999620fc8cc86c0fae6d9f89a7 | |
| parent | 7d4b8fe684112401779c13ecc9073f1e8dc40358 (diff) | |
| download | sssd-b08b6a994dcca108bb571458da092e0e320ce9c2.tar.gz sssd-b08b6a994dcca108bb571458da092e0e320ce9c2.tar.xz sssd-b08b6a994dcca108bb571458da092e0e320ce9c2.zip | |
GPO: Fix incorrect strerror on GPO access denial
We're attempting to use strerror() to print the result from
ad_gpo_access_check(), but that function returns an extended SSSD errno
Signed-off-by: Lukas Slebodnik <lslebodn@redhat.com>
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
| -rw-r--r-- | src/providers/ad/ad_gpo.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c index 4e7afb12a..974fd04b9 100644 --- a/src/providers/ad/ad_gpo.c +++ b/src/providers/ad/ad_gpo.c @@ -1149,7 +1149,7 @@ ad_gpo_store_policy_settings(struct sss_domain_info *domain, if (ret != EOK && ret != ENOENT) { DEBUG(SSSDBG_CRIT_FAILURE, "ad_gpo_extract_policy_setting failed for %s [%d][%s]\n", - allow_key, ret, strerror(ret)); + allow_key, ret, sss_strerror(ret)); goto done; } else if (ret != ENOENT) { ret = sysdb_gpo_store_gpo_result_setting(domain, @@ -1175,7 +1175,7 @@ ad_gpo_store_policy_settings(struct sss_domain_info *domain, if (ret != EOK && ret != ENOENT) { DEBUG(SSSDBG_CRIT_FAILURE, "ad_gpo_extract_policy_setting failed for %s [%d][%s]\n", - deny_key, ret, strerror(ret)); + deny_key, ret, sss_strerror(ret)); goto done; } else if (ret != ENOENT) { ret = sysdb_gpo_store_gpo_result_setting(domain, @@ -1448,7 +1448,7 @@ ad_gpo_perform_hbac_processing(TALLOC_CTX *mem_ctx, if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, "GPO access check failed: [%d](%s)\n", - ret, strerror(ret)); + ret, sss_strerror(ret)); goto done; } @@ -1670,7 +1670,7 @@ ad_gpo_connect_done(struct tevent_req *subreq) if (dp_error != DP_ERR_OFFLINE) { DEBUG(SSSDBG_OP_FAILURE, "Failed to connect to AD server: [%d](%s)\n", - ret, strerror(ret)); + ret, sss_strerror(ret)); goto done; } else { DEBUG(SSSDBG_TRACE_FUNC, "Preparing for offline operation.\n"); @@ -1992,7 +1992,7 @@ ad_gpo_process_gpo_done(struct tevent_req *subreq) if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, "Unable to filter GPO list by CSE_GUID: [%d](%s)\n", - ret, strerror(ret)); + ret, sss_strerror(ret)); goto done; } @@ -2041,7 +2041,7 @@ ad_gpo_process_gpo_done(struct tevent_req *subreq) default: DEBUG(SSSDBG_FATAL_FAILURE, "Could not delete GPO Result from cache: [%s]\n", - strerror(ret)); + sss_strerror(ret)); goto done; } } @@ -2133,7 +2133,7 @@ ad_gpo_cse_step(struct tevent_req *req) cached_gpt_version = -1; } else { DEBUG(SSSDBG_FATAL_FAILURE, "Could not read GPO from cache: [%s]\n", - strerror(ret)); + sss_strerror(ret)); return ret; } @@ -4034,7 +4034,7 @@ static void gpo_cse_done(struct tevent_req *subreq) if (ret != EOK) { DEBUG(SSSDBG_CRIT_FAILURE, "ad_gpo_parse_gpo_child_response failed: [%d][%s]\n", - ret, strerror(ret)); + ret, sss_strerror(ret)); tevent_req_error(req, ret); return; } else if (child_result != 0){ |