diff options
| author | Pavel Březina <pbrezina@redhat.com> | 2015-03-25 12:08:04 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-04-08 11:30:01 +0200 |
| commit | c34ac0da2396205200095a1223c3aec02c882d07 (patch) | |
| tree | 041d2adcadbcfd0a68b63858e39feefc9297fbb8 | |
| parent | 2dd4676825aa42a7fc38907dd0f879c17d508960 (diff) | |
| download | sssd-c34ac0da2396205200095a1223c3aec02c882d07.tar.gz sssd-c34ac0da2396205200095a1223c3aec02c882d07.tar.xz sssd-c34ac0da2396205200095a1223c3aec02c882d07.zip | |
enumeration: fix talloc context
If for some reason ptask fails (e.g. timeout), req is talloc freed
but because subreq is attached to ectx which is permanent it is
finished anyway. Then a crash occures when we are trying to access
callback data.
The same happens in sdap_dom_enum_ex_send.
Resolves:
https://fedorahosted.org/sssd/ticket/2611
Reviewed-by: Pavel Reichl <preichl@redhat.com>
(cherry picked from commit 725bb2a9901c4f673b107ed179f5d68ec443ca63)
(cherry picked from commit 81bb9be1ae0b2a4ebe960f136a52576abcdfbbac)
| -rw-r--r-- | src/providers/ldap/ldap_id_enum.c | 2 | ||||
| -rw-r--r-- | src/providers/ldap/sdap_async_enum.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/providers/ldap/ldap_id_enum.c b/src/providers/ldap/ldap_id_enum.c index 206adb5a6..d45536258 100644 --- a/src/providers/ldap/ldap_id_enum.c +++ b/src/providers/ldap/ldap_id_enum.c @@ -129,7 +129,7 @@ ldap_enumeration_send(TALLOC_CTX *mem_ctx, state->dom = ectx->sdom->dom; state->id_ctx = talloc_get_type_abort(ectx->pvt, struct sdap_id_ctx); - subreq = sdap_dom_enum_send(ectx, ev, state->id_ctx, ectx->sdom, + subreq = sdap_dom_enum_send(state, ev, state->id_ctx, ectx->sdom, state->id_ctx->conn); if (subreq == NULL) { /* The ptask API will reschedule the enumeration on its own on diff --git a/src/providers/ldap/sdap_async_enum.c b/src/providers/ldap/sdap_async_enum.c index 83bdde3f7..334cf3b7c 100644 --- a/src/providers/ldap/sdap_async_enum.c +++ b/src/providers/ldap/sdap_async_enum.c @@ -90,7 +90,7 @@ sdap_dom_enum_ex_send(TALLOC_CTX *memctx, int t; errno_t ret; - req = tevent_req_create(ctx, &state, struct sdap_dom_enum_ex_state); + req = tevent_req_create(memctx, &state, struct sdap_dom_enum_ex_state); if (req == NULL) return NULL; state->ev = ev; |