diff options
| author | Sumit Bose <sbose@redhat.com> | 2013-08-23 10:13:02 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2013-08-24 18:05:24 +0200 |
| commit | ce0769479e53208ba9e35d9617eb85f3cac615cf (patch) | |
| tree | 3e79b238241acff716e9cc3267979d9225a9511b | |
| parent | bea1c465473b6f26e1952f991a81172bd3260106 (diff) | |
| download | sssd-ce0769479e53208ba9e35d9617eb85f3cac615cf.tar.gz sssd-ce0769479e53208ba9e35d9617eb85f3cac615cf.tar.xz sssd-ce0769479e53208ba9e35d9617eb85f3cac615cf.zip | |
check_cc_validity: make sure _valid is always set
In the KRB5_FCC_NOFILE code path _valid is not set leading to 'may be
used uninitialized' compiler warnings.
| -rw-r--r-- | src/providers/krb5/krb5_utils.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/providers/krb5/krb5_utils.c b/src/providers/krb5/krb5_utils.c index c6967ea58..f8fbb29eb 100644 --- a/src/providers/krb5/krb5_utils.c +++ b/src/providers/krb5/krb5_utils.c @@ -750,12 +750,14 @@ check_cc_validity(const char *location, } ret = EOK; - *_valid = valid; - done: - if (ccache) krb5_cc_close(context, ccache); - krb5_free_context(context); - return ret; +done: + if (ret == EOK) { + *_valid = valid; + } + if (ccache) krb5_cc_close(context, ccache); + krb5_free_context(context); + return ret; } /*======== ccache back end utilities ========*/ |