summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Slebodnik <lslebodn@redhat.com>2015-02-17 16:40:01 +0100
committerJakub Hrozek <jhrozek@redhat.com>2015-03-17 14:40:19 +0100
commit87f8bee53ee1b4ca87b602ff8536bc5fd5b5b595 (patch)
treebb4ac04a7ec9983ac907e2d90955852be017ac25
parentd81d8d3dc151ebc95cd0e3f3b14c1cdaa48980f1 (diff)
downloadsssd-87f8bee53ee1b4ca87b602ff8536bc5fd5b5b595.tar.gz
sssd-87f8bee53ee1b4ca87b602ff8536bc5fd5b5b595.tar.xz
sssd-87f8bee53ee1b4ca87b602ff8536bc5fd5b5b595.zip
Add missing new lines to debug messages
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
-rw-r--r--src/confdb/confdb_setup.c2
-rw-r--r--src/db/sysdb_autofs.c4
-rw-r--r--src/db/sysdb_sudo.c2
-rw-r--r--src/db/sysdb_views.c2
-rw-r--r--src/monitor/monitor.c6
-rw-r--r--src/monitor/monitor_netlink.c16
-rw-r--r--src/providers/ad/ad_common.c8
-rw-r--r--src/providers/ad/ad_init.c8
-rw-r--r--src/providers/ad/ad_subdomains.c4
-rw-r--r--src/providers/data_provider_be.c4
-rw-r--r--src/providers/dp_dyndns.c16
-rw-r--r--src/providers/dp_ptask.c10
-rw-r--r--src/providers/ipa/ipa_access.c2
-rw-r--r--src/providers/ipa/ipa_hbac_rules.c2
-rw-r--r--src/providers/ipa/ipa_hostid.c2
-rw-r--r--src/providers/ipa/ipa_selinux.c6
-rw-r--r--src/providers/ipa/ipa_subdomains.c6
-rw-r--r--src/providers/krb5/krb5_child.c2
-rw-r--r--src/providers/krb5/krb5_wait_queue.c2
-rw-r--r--src/providers/ldap/ldap_id.c2
-rw-r--r--src/providers/ldap/sdap.c4
-rw-r--r--src/providers/ldap/sdap_async.c2
-rw-r--r--src/providers/ldap/sdap_async_connection.c2
-rw-r--r--src/providers/ldap/sdap_async_initgroups.c6
-rw-r--r--src/providers/ldap/sdap_utils.c2
-rw-r--r--src/responder/autofs/autofssrv_cmd.c4
-rw-r--r--src/responder/common/responder_dp.c4
-rw-r--r--src/responder/nss/nsssrv_cmd.c4
-rw-r--r--src/responder/nss/nsssrv_netgroup.c4
-rw-r--r--src/responder/pac/pacsrv_cmd.c2
-rw-r--r--src/responder/pac/pacsrv_utils.c4
-rw-r--r--src/responder/pam/pamsrv.c4
-rw-r--r--src/responder/sudo/sudosrv_get_sudorules.c2
-rw-r--r--src/responder/sudo/sudosrv_query.c2
-rw-r--r--src/sbus/sssd_dbus_server.c4
-rw-r--r--src/tests/krb5_child-test.c2
-rw-r--r--src/tools/files.c12
-rw-r--r--src/tools/sss_sync_ops.c2
-rw-r--r--src/util/debug.c2
-rw-r--r--src/util/domain_info_utils.c8
-rw-r--r--src/util/find_uid.c2
-rw-r--r--src/util/server.c4
-rw-r--r--src/util/sss_ini.c4
-rw-r--r--src/util/sss_krb5.c10
-rw-r--r--src/util/sss_semanage.c7
-rw-r--r--src/util/usertools.c2
46 files changed, 107 insertions, 104 deletions
diff --git a/src/confdb/confdb_setup.c b/src/confdb/confdb_setup.c
index 857725f1a..93a1a1b53 100644
--- a/src/confdb/confdb_setup.c
+++ b/src/confdb/confdb_setup.c
@@ -275,7 +275,7 @@ int confdb_init_db(const char *config_file, struct confdb_ctx *cdb)
goto done;
}
- DEBUG(SSSDBG_TRACE_LIBS, "LDIF file to import: \n%s", config_ldif);
+ DEBUG(SSSDBG_TRACE_LIBS, "LDIF file to import: \n%s\n", config_ldif);
while ((ldif = ldb_ldif_read_string(cdb->ldb, &config_ldif))) {
ret = ldb_add(cdb->ldb, ldif->msg);
diff --git a/src/db/sysdb_autofs.c b/src/db/sysdb_autofs.c
index 218e9c0a0..b3e9b4ec8 100644
--- a/src/db/sysdb_autofs.c
+++ b/src/db/sysdb_autofs.c
@@ -222,7 +222,7 @@ sysdb_get_map_byname(TALLOC_CTX *mem_ctx,
&count, &msgs);
if (ret != EOK && ret != ENOENT) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error looking up autofs map [%s]", safe_map_name);
+ "Error looking up autofs map [%s]\n", safe_map_name);
goto done;
} else if (ret == ENOENT) {
DEBUG(SSSDBG_TRACE_FUNC, "No such map\n");
@@ -467,7 +467,7 @@ sysdb_invalidate_autofs_maps(struct sss_domain_info *domain)
&count, &msgs);
if (ret != EOK && ret != ENOENT) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error looking up autofs maps");
+ "Error looking up autofs maps\n");
goto done;
} else if (ret == ENOENT) {
ret = EOK;
diff --git a/src/db/sysdb_sudo.c b/src/db/sysdb_sudo.c
index 54f726fff..4c50d32c7 100644
--- a/src/db/sysdb_sudo.c
+++ b/src/db/sysdb_sudo.c
@@ -668,7 +668,7 @@ errno_t sysdb_sudo_purge_byfilter(struct sss_domain_info *domain,
ret = EOK;
goto done;
} else if (ret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules\n");
goto done;
}
diff --git a/src/db/sysdb_views.c b/src/db/sysdb_views.c
index 431d33454..945f16ac1 100644
--- a/src/db/sysdb_views.c
+++ b/src/db/sysdb_views.c
@@ -238,7 +238,7 @@ errno_t sysdb_invalidate_overrides(struct sysdb_ctx *sysdb)
base_dn = ldb_dn_new(tmp_ctx, sysdb->ldb, SYSDB_BASE);
if (base_dn == NULL) {
- DEBUG(SSSDBG_OP_FAILURE, "ldb_dn_new failed");
+ DEBUG(SSSDBG_OP_FAILURE, "ldb_dn_new failed\n");
ret = ENOMEM;
goto done;
}
diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index 8845e4a37..e02397b6e 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -998,9 +998,9 @@ static int get_monitor_config(struct mt_ctx *ctx)
ret = add_implicit_services(ctx->cdb, ctx, &ctx->services);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Failed to add implicit configured " \
- "services. Some functionality might " \
- "be missing");
+ DEBUG(SSSDBG_OP_FAILURE, "Failed to add implicit configured "
+ "services. Some functionality might "
+ "be missing\n");
}
badsrv = check_services(ctx->services);
diff --git a/src/monitor/monitor_netlink.c b/src/monitor/monitor_netlink.c
index 51e8ffe47..7e6f8cbbd 100644
--- a/src/monitor/monitor_netlink.c
+++ b/src/monitor/monitor_netlink.c
@@ -220,7 +220,7 @@ static bool has_phy_80211_subdir(const char *sysfs_path)
ret = snprintf(phy80211_path, SYSFS_SUBDIR_PATH_MAX,
"%s/%s", sysfs_path, PHY_80211_SUBDIR);
if (ret < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_OP_FAILURE, "snprintf failed\n");
return false;
} else if (ret >= SYSFS_SUBDIR_PATH_MAX) {
DEBUG(SSSDBG_OP_FAILURE, "path too long?!?!\n");
@@ -263,7 +263,7 @@ static bool discard_iff_up(const char *ifname)
ret = snprintf(path, SYSFS_IFACE_PATH_MAX, SYSFS_IFACE_TEMPLATE, ifname);
if (ret < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_OP_FAILURE, "snprintf failed\n");
return false;
} else if (ret >= SYSFS_IFACE_PATH_MAX) {
DEBUG(SSSDBG_OP_FAILURE, "path too long?!?!\n");
@@ -339,8 +339,8 @@ static bool nlw_accept_message(struct nlw_handle *nlp,
}
if (accept_msg == false) {
- DEBUG(SSSDBG_TRACE_ALL, "ignoring netlink message from PID %d",
- hdr->nlmsg_pid);
+ DEBUG(SSSDBG_TRACE_ALL,
+ "ignoring netlink message from PID %d\n", hdr->nlmsg_pid);
}
return accept_msg;
@@ -475,8 +475,8 @@ static int event_msg_recv(struct nl_msg *msg, void *arg)
creds = nlmsg_get_creds(msg);
if (!creds || creds->uid != 0) {
DEBUG(SSSDBG_TRACE_ALL,
- "Ignoring netlink message from UID %"SPRIuid,
- creds ? creds->uid : (uid_t)-1);
+ "Ignoring netlink message from UID %"SPRIuid"\n",
+ creds ? creds->uid : (uid_t)-1);
return NL_SKIP;
}
@@ -754,8 +754,8 @@ int setup_netlink(TALLOC_CTX *mem_ctx, struct tevent_context *ev,
/* allocate the libnl handle/socket and register the default filter set */
nlctx->nlp = nlw_alloc();
if (!nlctx->nlp) {
- DEBUG(SSSDBG_CRIT_FAILURE, ("unable to allocate netlink handle: %s"),
- nlw_geterror(ENOMEM));
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ "unable to allocate netlink handle: %s\n", nlw_geterror(ENOMEM));
ret = ENOMEM;
goto fail;
}
diff --git a/src/providers/ad/ad_common.c b/src/providers/ad/ad_common.c
index c3cbfdac0..120878977 100644
--- a/src/providers/ad/ad_common.c
+++ b/src/providers/ad/ad_common.c
@@ -437,8 +437,8 @@ _ad_servers_init(struct ad_service *service,
false, sdata);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Failed to add service discovery to failover: [%s]",
- strerror(ret));
+ "Failed to add service discovery to failover: [%s]\n",
+ strerror(ret));
goto done;
}
@@ -454,8 +454,8 @@ _ad_servers_init(struct ad_service *service,
false, sdata);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Failed to add service discovery to failover: [%s]",
- strerror(ret));
+ "Failed to add service discovery to failover: [%s]\n",
+ strerror(ret));
goto done;
}
diff --git a/src/providers/ad/ad_init.c b/src/providers/ad/ad_init.c
index ca2d49f62..3d12f382c 100644
--- a/src/providers/ad/ad_init.c
+++ b/src/providers/ad/ad_init.c
@@ -454,16 +454,16 @@ sssm_ad_access_init(struct be_ctx *bectx,
ret = sss_hash_create(access_ctx, 10, &access_ctx->gpo_map_options_table);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Could not create gpo_map_options hash table: [%s]",
- strerror(ret));
+ "Could not create gpo_map_options hash table: [%s]\n",
+ strerror(ret));
goto fail;
}
ret = ad_gpo_parse_map_options(access_ctx);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Could not parse gpo_map_options (invalid config): [%s]",
- strerror(ret));
+ "Could not parse gpo_map_options (invalid config): [%s]\n",
+ strerror(ret));
goto fail;
}
diff --git a/src/providers/ad/ad_subdomains.c b/src/providers/ad/ad_subdomains.c
index b3821f8d0..5a6e9338d 100644
--- a/src/providers/ad/ad_subdomains.c
+++ b/src/providers/ad/ad_subdomains.c
@@ -1186,12 +1186,12 @@ int ad_subdom_init(struct be_ctx *be_ctx,
ret = be_add_online_cb(ctx, be_ctx, ad_subdom_online_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback\n");
}
ret = be_add_offline_cb(ctx, be_ctx, ad_subdom_offline_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback\n");
}
err = sss_idmap_init(sss_idmap_talloc, ctx, sss_idmap_talloc_free,
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index 47809e20f..a48a42878 100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -927,7 +927,7 @@ be_file_account_request(struct be_req *be_req, struct be_acct_req *ar)
if ((ar->entry_type & 0xFF) == BE_REQ_INITGROUPS) {
ret = be_initgroups_prereq(be_req);
if (ret) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Prerequest failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Prerequest failed\n");
return ret;
}
}
@@ -936,7 +936,7 @@ be_file_account_request(struct be_req *be_req, struct be_acct_req *ar)
ret = be_file_request(be_ctx, be_req,
be_ctx->bet_info[BET_ID].bet_ops->handler);
if (ret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Failed to file request");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Failed to file request\n");
return ret;
}
diff --git a/src/providers/dp_dyndns.c b/src/providers/dp_dyndns.c
index 580fb2c63..7db21509d 100644
--- a/src/providers/dp_dyndns.c
+++ b/src/providers/dp_dyndns.c
@@ -475,10 +475,10 @@ be_nsupdate_create_fwd_msg(TALLOC_CTX *mem_ctx, const char *realm,
}
DEBUG(SSSDBG_TRACE_FUNC,
- " -- Begin nsupdate message -- \n%s",
- update_msg);
- DEBUG(SSSDBG_TRACE_FUNC,
- " -- End nsupdate message -- \n");
+ " -- Begin nsupdate message -- \n"
+ "%s"
+ " -- End nsupdate message -- \n",
+ update_msg);
ret = ERR_OK;
*_update_msg = talloc_steal(mem_ctx, update_msg);
@@ -517,10 +517,10 @@ be_nsupdate_create_ptr_msg(TALLOC_CTX *mem_ctx, const char *realm,
}
DEBUG(SSSDBG_TRACE_FUNC,
- " -- Begin nsupdate message -- \n%s",
- update_msg);
- DEBUG(SSSDBG_TRACE_FUNC,
- " -- End nsupdate message -- \n");
+ " -- Begin nsupdate message -- \n"
+ "%s"
+ " -- End nsupdate message -- \n",
+ update_msg);
ret = ERR_OK;
*_update_msg = talloc_steal(mem_ctx, update_msg);
diff --git a/src/providers/dp_ptask.c b/src/providers/dp_ptask.c
index e3450851e..0f28dee1e 100644
--- a/src/providers/dp_ptask.c
+++ b/src/providers/dp_ptask.c
@@ -317,15 +317,17 @@ errno_t be_ptask_create(TALLOC_CTX *mem_ctx,
/* install offline and online callbacks */
ret = be_add_online_cb(task, be_ctx, be_ptask_online_cb, task, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Unable to install online callback "
- "[%d]: %s", ret, sss_strerror(ret));
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Unable to install online callback [%d]: %s\n",
+ ret, sss_strerror(ret));
goto done;
}
ret = be_add_offline_cb(task, be_ctx, be_ptask_offline_cb, task, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Unable to install offline callback "
- "[%d]: %s", ret, sss_strerror(ret));
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Unable to install offline callback [%d]: %s\n",
+ ret, sss_strerror(ret));
goto done;
}
}
diff --git a/src/providers/ipa/ipa_access.c b/src/providers/ipa/ipa_access.c
index ed52132ad..2ebaec337 100644
--- a/src/providers/ipa/ipa_access.c
+++ b/src/providers/ipa/ipa_access.c
@@ -711,7 +711,7 @@ errno_t hbac_get_cached_rules(TALLOC_CTX *mem_ctx,
HBAC_RULES_SUBDIR, attrs,
&rule_count, &msgs);
if (ret != EOK && ret != ENOENT) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up HBAC rules");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up HBAC rules\n");
goto done;
} if (ret == ENOENT) {
rule_count = 0;
diff --git a/src/providers/ipa/ipa_hbac_rules.c b/src/providers/ipa/ipa_hbac_rules.c
index 571b90c58..497eee612 100644
--- a/src/providers/ipa/ipa_hbac_rules.c
+++ b/src/providers/ipa/ipa_hbac_rules.c
@@ -144,7 +144,7 @@ ipa_hbac_rule_info_send(TALLOC_CTX *mem_ctx,
ret = sysdb_attrs_get_string_array(ipa_host, SYSDB_ORIG_MEMBEROF,
tmp_ctx, &memberof_list);
if (ret != EOK && ret != ENOENT) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify ");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify.\n");
} if (ret == ENOENT) {
/* This host is not a member of any hostgroups */
memberof_list = talloc_array(tmp_ctx, const char *, 1);
diff --git a/src/providers/ipa/ipa_hostid.c b/src/providers/ipa/ipa_hostid.c
index 6b8233587..31fa29f91 100644
--- a/src/providers/ipa/ipa_hostid.c
+++ b/src/providers/ipa/ipa_hostid.c
@@ -110,7 +110,7 @@ ipa_host_info_complete(struct be_req *breq, int dp_error,
error_text = NULL;
} else {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Bug: dp_error is OK on failed request");
+ "Bug: dp_error is OK on failed request\n");
dp_error = DP_ERR_FATAL;
error_text = default_error_text;
}
diff --git a/src/providers/ipa/ipa_selinux.c b/src/providers/ipa/ipa_selinux.c
index aa53769e3..0555cdd50 100644
--- a/src/providers/ipa/ipa_selinux.c
+++ b/src/providers/ipa/ipa_selinux.c
@@ -211,7 +211,7 @@ done:
if (in_transaction) {
sret = sysdb_transaction_cancel(sysdb);
if (sret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Failed to cancel transaction");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Failed to cancel transaction\n");
}
}
return ret;
@@ -788,7 +788,7 @@ static errno_t choose_best_seuser(TALLOC_CTX *mem_ctx,
ret = selinux_child_setup(tmp_ctx, pd->user, user_domain, seuser_mls_str, &sci);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Cannot set up child input buffer");
+ DEBUG(SSSDBG_OP_FAILURE, "Cannot set up child input buffer\n");
goto done;
}
@@ -865,7 +865,7 @@ selinux_child_setup(TALLOC_CTX *mem_ctx,
}
} else {
DEBUG(SSSDBG_OP_FAILURE,
- "sss_parse_name failed: [%d] %s", ret, sss_strerror(ret));
+ "sss_parse_name failed: [%d] %s\n", ret, sss_strerror(ret));
goto done;
}
} else {
diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
index d0f02bade..0fe2a8dd6 100644
--- a/src/providers/ipa/ipa_subdomains.c
+++ b/src/providers/ipa/ipa_subdomains.c
@@ -1658,17 +1658,17 @@ int ipa_subdom_init(struct be_ctx *be_ctx,
NULL);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Failed to add subdom reset timeouts callback");
+ "Failed to add subdom reset timeouts callback\n");
}
ret = be_add_online_cb(ctx, be_ctx, ipa_subdom_online_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback\n");
}
ret = be_add_offline_cb(ctx, be_ctx, ipa_subdom_offline_cb, ctx, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback");
+ DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback\n");
}
ret = ipa_subdom_reinit(ctx);
diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index 6c690145d..8fb2e6b2f 100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -947,7 +947,7 @@ done:
}
if (krb5_kt_close(kr->ctx, keytab) != 0) {
- DEBUG(SSSDBG_MINOR_FAILURE, "krb5_kt_close failed");
+ DEBUG(SSSDBG_MINOR_FAILURE, "krb5_kt_close failed\n");
}
if (validation_princ != NULL) {
krb5_free_principal(kr->ctx, validation_princ);
diff --git a/src/providers/krb5/krb5_wait_queue.c b/src/providers/krb5/krb5_wait_queue.c
index 3c390531e..10c50d81b 100644
--- a/src/providers/krb5/krb5_wait_queue.c
+++ b/src/providers/krb5/krb5_wait_queue.c
@@ -84,7 +84,7 @@ errno_t add_to_wait_queue(struct be_req *be_req, struct pam_data *pd,
&krb5_ctx->wait_queue_hash, 0, 0, 0, 0,
wait_queue_del_cb, NULL);
if (ret != EOK) {
- DEBUG(SSSDBG_CRIT_FAILURE, "sss_hash_create failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "sss_hash_create failed\n");
return ret;
}
}
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index e60e3a53a..642ae5c29 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -1640,7 +1640,7 @@ static void sdap_account_info_complete(struct tevent_req *req)
error_text = NULL;
} else {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Bug: dp_error is OK on failed request");
+ "Bug: dp_error is OK on failed request\n");
dp_error = DP_ERR_FATAL;
error_text = req_error_text;
}
diff --git a/src/providers/ldap/sdap.c b/src/providers/ldap/sdap.c
index c401e7dc8..bae7d02c5 100644
--- a/src/providers/ldap/sdap.c
+++ b/src/providers/ldap/sdap.c
@@ -437,7 +437,7 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
if (!vals) {
ldap_get_option(sh->ldap, LDAP_OPT_RESULT_CODE, &lerrno);
if (lerrno != LDAP_SUCCESS) {
- DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)",
+ DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)\n",
lerrno, sss_ldap_err2string(lerrno));
ret = EIO;
goto done;
@@ -517,7 +517,7 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
ldap_get_option(sh->ldap, LDAP_OPT_RESULT_CODE, &lerrno);
if (lerrno) {
- DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)",
+ DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)\n",
lerrno, sss_ldap_err2string(lerrno));
ret = EIO;
goto done;
diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index a6954620b..c30a4578e 100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -1481,7 +1481,7 @@ static void sdap_get_generic_op_finished(struct sdap_op *op,
&total_count, &cookie);
ldap_controls_free(returned_controls);
if (lret != LDAP_SUCCESS) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Could not determine page control");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Could not determine page control\n");
tevent_req_error(req, EIO);
return;
}
diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c
index 304505458..bc03a87a2 100644
--- a/src/providers/ldap/sdap_async_connection.c
+++ b/src/providers/ldap/sdap_async_connection.c
@@ -1792,7 +1792,7 @@ static void sdap_cli_auth_step(struct tevent_req *req)
ret = sdap_cli_auth_reconnect(req);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "sdap_cli_auth_reconnect failed: %d:[%s]",
+ "sdap_cli_auth_reconnect failed: %d:[%s]\n",
ret, sss_strerror(ret));
tevent_req_error(req, ret);
}
diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c
index bc6b5e45e..2fd235f28 100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -1792,7 +1792,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req *subreq)
ret = save_rfc2307bis_groups(state);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not save groups memberships [%d]", ret);
+ "Could not save groups memberships [%d]\n", ret);
goto fail;
}
@@ -1800,7 +1800,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req *subreq)
ret = save_rfc2307bis_group_memberships(state);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not save group memberships [%d]", ret);
+ "Could not save group memberships [%d]\n", ret);
goto fail;
}
@@ -1808,7 +1808,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req *subreq)
ret = save_rfc2307bis_user_memberships(state);
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not save user memberships [%d]", ret);
+ "Could not save user memberships [%d]\n", ret);
goto fail;
}
diff --git a/src/providers/ldap/sdap_utils.c b/src/providers/ldap/sdap_utils.c
index 93a1faae1..f5ce8ee54 100644
--- a/src/providers/ldap/sdap_utils.c
+++ b/src/providers/ldap/sdap_utils.c
@@ -86,7 +86,7 @@ sdap_save_all_names(const char *name,
ret = sysdb_attrs_get_aliases(tmp_ctx, ldap_attrs, name,
lowercase, &aliases);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Failed to get the alias list");
+ DEBUG(SSSDBG_OP_FAILURE, "Failed to get the alias list\n");
goto done;
}
diff --git a/src/responder/autofs/autofssrv_cmd.c b/src/responder/autofs/autofssrv_cmd.c
index 4c9f5cf7d..797e638d5 100644
--- a/src/responder/autofs/autofssrv_cmd.c
+++ b/src/responder/autofs/autofssrv_cmd.c
@@ -188,9 +188,9 @@ set_autofs_map(struct autofs_ctx *actx,
hret = hash_enter(actx->maps, &key, &value);
if (hret != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Unable to add hash table entry for [%s]", key.str);
+ "Unable to add hash table entry for [%s]\n", key.str);
DEBUG(SSSDBG_MINOR_FAILURE,
- "Hash error [%d][%s]", hret, hash_error_string(hret));
+ "Hash error [%d][%s]\n", hret, hash_error_string(hret));
return EIO;
}
talloc_steal(actx->maps, map);
diff --git a/src/responder/common/responder_dp.c b/src/responder/common/responder_dp.c
index df7455ce3..853b3eae3 100644
--- a/src/responder/common/responder_dp.c
+++ b/src/responder/common/responder_dp.c
@@ -684,8 +684,8 @@ sss_dp_internal_get_send(struct resp_ctx *rctx,
ret = sss_dp_get_domain_conn(rctx, dom->conn_name, &be_conn);
if (ret != EOK) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "BUG: The Data Provider connection for %s is not available!",
- dom->name);
+ "BUG: The Data Provider connection for %s is not available!\n",
+ dom->name);
ret = EIO;
goto error;
}
diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c
index 4f297c6a3..4c0e9414d 100644
--- a/src/responder/nss/nsssrv_cmd.c
+++ b/src/responder/nss/nsssrv_cmd.c
@@ -2865,8 +2865,8 @@ static int fill_grent(struct sss_packet *packet,
fullname.len - pwfield.len);
if (ret != EOK && ret != ENOMEM) {
DEBUG(SSSDBG_OP_FAILURE,
- "Failed to store group %s(%s) in mmap cache!",
- name.str, domain);
+ "Failed to store group %s(%s) in mmap cache!\n",
+ name.str, domain);
}
}
diff --git a/src/responder/nss/nsssrv_netgroup.c b/src/responder/nss/nsssrv_netgroup.c
index 66b7f2759..c71043858 100644
--- a/src/responder/nss/nsssrv_netgroup.c
+++ b/src/responder/nss/nsssrv_netgroup.c
@@ -76,9 +76,9 @@ static errno_t set_netgroup_entry(struct nss_ctx *nctx,
hret = hash_enter(nctx->netgroups, &key, &value);
if (hret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Unable to add hash table entry for [%s]", key.str);
+ "Unable to add hash table entry for [%s]\n", key.str);
DEBUG(SSSDBG_CONF_SETTINGS,
- "Hash error [%d][%s]", hret, hash_error_string(hret));
+ "Hash error [%d][%s]\n", hret, hash_error_string(hret));
return EIO;
}
talloc_steal(nctx->netgroups, netgr);
diff --git a/src/responder/pac/pacsrv_cmd.c b/src/responder/pac/pacsrv_cmd.c
index 83609343b..64c02e81c 100644
--- a/src/responder/pac/pacsrv_cmd.c
+++ b/src/responder/pac/pacsrv_cmd.c
@@ -131,7 +131,7 @@ static errno_t pac_add_pac_user(struct cli_ctx *cctx)
pr_ctx->domain_name = pr_ctx->logon_info->info3.base.logon_domain.string;
if (pr_ctx->domain_name == NULL) {
- DEBUG(SSSDBG_FATAL_FAILURE, "No domain name in PAC");
+ DEBUG(SSSDBG_FATAL_FAILURE, "No domain name in PAC\n");
ret = EINVAL;
goto done;
}
diff --git a/src/responder/pac/pacsrv_utils.c b/src/responder/pac/pacsrv_utils.c
index 7d37cda87..de2e8dfbd 100644
--- a/src/responder/pac/pacsrv_utils.c
+++ b/src/responder/pac/pacsrv_utils.c
@@ -433,8 +433,8 @@ errno_t get_pwd_from_pac(TALLOC_CTX *mem_ctx,
goto done;
}
} else {
- DEBUG(SSSDBG_OP_FAILURE, "Missing full name in PAC, "
- "gecos field will by empty.\n ");
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Missing full name in PAC, gecos field will by empty.\n");
}
/* Check if there is a special homedir template for sub-domains. If not a
diff --git a/src/responder/pam/pamsrv.c b/src/responder/pam/pamsrv.c
index 886136b42..45747baa0 100644
--- a/src/responder/pam/pamsrv.c
+++ b/src/responder/pam/pamsrv.c
@@ -278,8 +278,8 @@ static int pam_process_init(TALLOC_CTX *mem_ctx,
ret = sss_hash_create(pctx, 10, &pctx->id_table);
if (ret != EOK) {
DEBUG(SSSDBG_FATAL_FAILURE,
- "Could not create initgroups hash table: [%s]",
- strerror(ret));
+ "Could not create initgroups hash table: [%s]\n",
+ strerror(ret));
goto done;
}
diff --git a/src/responder/sudo/sudosrv_get_sudorules.c b/src/responder/sudo/sudosrv_get_sudorules.c
index ac9587714..34d63bd74 100644
--- a/src/responder/sudo/sudosrv_get_sudorules.c
+++ b/src/responder/sudo/sudosrv_get_sudorules.c
@@ -664,7 +664,7 @@ static errno_t sudosrv_get_sudorules_query_cache(TALLOC_CTX *mem_ctx,
SUDORULE_SUBDIR, attrs,
&count, &msgs);
if (ret != EOK && ret != ENOENT) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up SUDO rules\n");
goto done;
} if (ret == ENOENT) {
*_rules = NULL;
diff --git a/src/responder/sudo/sudosrv_query.c b/src/responder/sudo/sudosrv_query.c
index 4d19514cd..4cb07e32b 100644
--- a/src/responder/sudo/sudosrv_query.c
+++ b/src/responder/sudo/sudosrv_query.c
@@ -109,7 +109,7 @@ static int sudosrv_response_append_attr(TALLOC_CTX *mem_ctx,
/* values */
for (i = 0; i < values_num; i++) {
if (strlen((char*)(values[i].data)) != values[i].length) {
- DEBUG(SSSDBG_CRIT_FAILURE, "value is not a string");
+ DEBUG(SSSDBG_CRIT_FAILURE, "value is not a string\n");
ret = EINVAL;
goto done;
}
diff --git a/src/sbus/sssd_dbus_server.c b/src/sbus/sssd_dbus_server.c
index 137524892..0a1cace41 100644
--- a/src/sbus/sssd_dbus_server.c
+++ b/src/sbus/sssd_dbus_server.c
@@ -56,7 +56,7 @@ static void sbus_server_init_new_connection(DBusServer *dbus_server,
SBUS_CONN_TYPE_PRIVATE, &conn);
if (ret != 0) {
dbus_connection_close(dbus_conn);
- DEBUG(SSSDBG_FUNC_DATA,"Closing connection (failed setup)");
+ DEBUG(SSSDBG_FUNC_DATA, "Closing connection (failed setup)\n");
return;
}
@@ -145,7 +145,7 @@ remove_socket_symlink(const char *symlink_name)
ret = snprintf(pidpath, PATH_MAX, "%s.%lu",
symlink_name, (unsigned long) getpid());
if (ret < 0) {
- DEBUG(SSSDBG_OP_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_OP_FAILURE, "snprintf failed\n");
return EIO;
} else if (ret >= PATH_MAX) {
DEBUG(SSSDBG_OP_FAILURE, "path too long?!?!\n");
diff --git a/src/tests/krb5_child-test.c b/src/tests/krb5_child-test.c
index a59863b4d..50acc88ed 100644
--- a/src/tests/krb5_child-test.c
+++ b/src/tests/krb5_child-test.c
@@ -73,7 +73,7 @@ setup_krb5_child_test(TALLOC_CTX *mem_ctx, struct krb5_child_test_ctx **_ctx)
ctx->ev = tevent_context_init(ctx);
if (ctx->ev == NULL) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Could not init tevent context");
+ DEBUG(SSSDBG_CRIT_FAILURE, "Could not init tevent context\n");
talloc_free(ctx);
return EFAULT;
}
diff --git a/src/tools/files.c b/src/tools/files.c
index f1cede0ce..5b3f9d103 100644
--- a/src/tools/files.c
+++ b/src/tools/files.c
@@ -516,7 +516,7 @@ copy_entry(struct copy_ctx *cctx,
if (ret != 0) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "couldn't stat '%s': %s", src_ent_path, strerror(ret));
+ "couldn't stat '%s': %s\n", src_ent_path, strerror(ret));
goto done;
}
@@ -577,7 +577,7 @@ copy_dir(struct copy_ctx *cctx,
if (dir == NULL) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error reading '%s': %s", src_dir_path, strerror(ret));
+ "Error reading '%s': %s\n", src_dir_path, strerror(ret));
goto done;
}
@@ -590,7 +590,7 @@ copy_dir(struct copy_ctx *cctx,
if (ret == -1 && errno != EEXIST) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error reading '%s': %s", dest_dir_path, strerror(ret));
+ "Error reading '%s': %s\n", dest_dir_path, strerror(ret));
goto done;
}
@@ -599,7 +599,7 @@ copy_dir(struct copy_ctx *cctx,
if (dest_dir_fd == -1) {
ret = errno;
DEBUG(SSSDBG_CRIT_FAILURE,
- "Error opening '%s': %s", dest_dir_path, strerror(ret));
+ "Error opening '%s': %s\n", dest_dir_path, strerror(ret));
goto done;
}
@@ -628,7 +628,7 @@ copy_dir(struct copy_ctx *cctx,
if (ret == -1 && errno != EPERM) {
ret = errno;
DEBUG(SSSDBG_OP_FAILURE,
- "Error changing owner of '%s': %s",
+ "Error changing owner of '%s': %s\n",
dest_dir_path, strerror(ret));
goto done;
}
@@ -640,7 +640,7 @@ copy_dir(struct copy_ctx *cctx,
if (ret == -1) {
ret = errno;
DEBUG(SSSDBG_OP_FAILURE,
- "Error setting mode of '%s': %s",
+ "Error setting mode of '%s': %s\n",
dest_dir_path, strerror(ret));
goto done;
}
diff --git a/src/tools/sss_sync_ops.c b/src/tools/sss_sync_ops.c
index fd401cb4d..e6faedcae 100644
--- a/src/tools/sss_sync_ops.c
+++ b/src/tools/sss_sync_ops.c
@@ -40,7 +40,7 @@
#define VAR_CHECK(var, val, attr, msg) do { \
if (var != (val)) { \
- DEBUG(SSSDBG_CRIT_FAILURE, msg" attribute: %s", attr); \
+ DEBUG(SSSDBG_CRIT_FAILURE, msg" attribute: %s\n", attr); \
return val; \
} \
} while(0)
diff --git a/src/util/debug.c b/src/util/debug.c
index 413757091..3121c70b1 100644
--- a/src/util/debug.c
+++ b/src/util/debug.c
@@ -431,5 +431,5 @@ int rotate_debug_files(void)
void talloc_log_fn(const char *message)
{
- DEBUG(SSSDBG_FATAL_FAILURE, "%s", message);
+ DEBUG(SSSDBG_FATAL_FAILURE, "%s\n", message);
}
diff --git a/src/util/domain_info_utils.c b/src/util/domain_info_utils.c
index cbfc55b26..a889bd7aa 100644
--- a/src/util/domain_info_utils.c
+++ b/src/util/domain_info_utils.c
@@ -568,8 +568,8 @@ done:
if (err < 0) {
err = errno;
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not remove file [%s]: [%d]: %s",
- tmp_file, err, strerror(err));
+ "Could not remove file [%s]: [%d]: %s\n",
+ tmp_file, err, strerror(err));
}
}
talloc_free(tmp_ctx);
@@ -731,8 +731,8 @@ done:
if (err == -1) {
err = errno;
DEBUG(SSSDBG_MINOR_FAILURE,
- "Could not remove file [%s]: [%d]: %s",
- tmp_file, err, sss_strerror(err));
+ "Could not remove file [%s]: [%d]: %s\n",
+ tmp_file, err, sss_strerror(err));
}
}
diff --git a/src/util/find_uid.c b/src/util/find_uid.c
index d0f76030d..535d8268e 100644
--- a/src/util/find_uid.c
+++ b/src/util/find_uid.c
@@ -74,7 +74,7 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid)
ret = snprintf(path, PATHLEN, "/proc/%d/status", pid);
if (ret < 0) {
- DEBUG(SSSDBG_CRIT_FAILURE, "snprintf failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "snprintf failed\n");
return EINVAL;
} else if (ret >= PATHLEN) {
DEBUG(SSSDBG_CRIT_FAILURE, "path too long?!?!\n");
diff --git a/src/util/server.c b/src/util/server.c
index abd29310f..7e9b76f74 100644
--- a/src/util/server.c
+++ b/src/util/server.c
@@ -350,8 +350,8 @@ int die_if_parent_died(void)
ret = prctl(PR_SET_PDEATHSIG, SIGTERM, 0, 0, 0);
if (ret != 0) {
ret = errno;
- DEBUG(SSSDBG_OP_FAILURE, "prctl failed [%d]: %s",
- ret, strerror(ret));
+ DEBUG(SSSDBG_OP_FAILURE, "prctl failed [%d]: %s\n",
+ ret, strerror(ret));
return ret;
}
#endif
diff --git a/src/util/sss_ini.c b/src/util/sss_ini.c
index 526ca31d4..766a75ea6 100644
--- a/src/util/sss_ini.c
+++ b/src/util/sss_ini.c
@@ -425,7 +425,7 @@ int sss_confdb_create_ldif(TALLOC_CTX *mem_ctx,
ldif_attr = talloc_asprintf(tmp_ctx,
"%s: %s\n", attrs[j], value);
- DEBUG(SSSDBG_TRACE_ALL, "%s", ldif_attr);
+ DEBUG(SSSDBG_TRACE_ALL, "%s\n", ldif_attr);
attr_len = strlen(ldif_attr);
@@ -455,7 +455,7 @@ int sss_confdb_create_ldif(TALLOC_CTX *mem_ctx,
dn[dn_size-1] = '\n';
dn[dn_size] = '\0';
- DEBUG(SSSDBG_TRACE_ALL, "Section dn\n%s", dn);
+ DEBUG(SSSDBG_TRACE_ALL, "Section dn\n%s\n", dn);
tmp_ldif = talloc_realloc(mem_ctx, ldif, char,
ldif_len+dn_size+1);
diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c
index 447b5a5bc..e5c2121da 100644
--- a/src/util/sss_krb5.c
+++ b/src/util/sss_krb5.c
@@ -172,7 +172,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
if (_principal) {
kerr = krb5_unparse_name(krb_ctx, client_princ, &principal_string);
if (kerr) {
- DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed\n");
ret = EFAULT;
goto done;
}
@@ -180,7 +180,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
*_principal = talloc_strdup(mem_ctx, principal_string);
free(principal_string);
if (!*_principal) {
- DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed\n");
ret = ENOMEM;
goto done;
}
@@ -192,7 +192,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
KRB5_PRINCIPAL_UNPARSE_NO_REALM,
&principal_string);
if (kerr) {
- DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "krb5_unparse_name failed\n");
ret = EFAULT;
goto done;
}
@@ -200,7 +200,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
*_primary = talloc_strdup(mem_ctx, principal_string);
free(principal_string);
if (!*_primary) {
- DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup failed\n");
if (_principal) talloc_zfree(*_principal);
ret = ENOMEM;
goto done;
@@ -223,7 +223,7 @@ errno_t select_principal_from_keytab(TALLOC_CTX *mem_ctx,
*_realm = talloc_asprintf(mem_ctx, "%.*s",
realm_len, realm_name);
if (!*_realm) {
- DEBUG(SSSDBG_CRIT_FAILURE, "talloc_asprintf failed");
+ DEBUG(SSSDBG_CRIT_FAILURE, "talloc_asprintf failed\n");
if (_principal) talloc_zfree(*_principal);
if (_primary) talloc_zfree(*_primary);
ret = ENOMEM;
diff --git a/src/util/sss_semanage.c b/src/util/sss_semanage.c
index 3c566553f..b85831c3d 100644
--- a/src/util/sss_semanage.c
+++ b/src/util/sss_semanage.c
@@ -326,8 +326,9 @@ int del_seuser(const char *login_name)
}
if (!exists) {
- DEBUG(SSSDBG_CRIT_FAILURE, "Login mapping for %s is defined in policy, "
- "cannot be deleted", login_name);
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ "Login mapping for %s is defined in policy, cannot be deleted\n",
+ login_name);
ret = ENOENT;
goto done;
}
@@ -335,7 +336,7 @@ int del_seuser(const char *login_name)
ret = semanage_seuser_del_local(handle, key);
if (ret != 0) {
DEBUG(SSSDBG_CRIT_FAILURE,
- "Could not delete login mapping for %s", login_name);
+ "Could not delete login mapping for %s\n", login_name);
ret = EIO;
goto done;
}
diff --git a/src/util/usertools.c b/src/util/usertools.c
index ebe139e6c..439c1494a 100644
--- a/src/util/usertools.c
+++ b/src/util/usertools.c
@@ -144,7 +144,7 @@ static errno_t sss_fqnames_init(struct sss_names_ctx *nctx, const char *fq_fmt)
fq = sss_tc_fqname2 (nctx, nctx, "unused.example.com", "unused", "the-test-user");
if (fq == NULL) {
DEBUG(SSSDBG_OP_FAILURE,
- "The fq format is invalid [%s]", nctx->fq_fmt);
+ "The fq format is invalid [%s]\n", nctx->fq_fmt);
return EINVAL;
} else if (strstr (fq, "the-test-user") == NULL) {
DEBUG(SSSDBG_OP_FAILURE,