diff options
| author | Pavel Reichl <preichl@redhat.com> | 2014-08-01 11:13:20 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-08-17 21:01:43 +0200 |
| commit | 46ebf4415306454e1d062b61a2495b7cdb821c0f (patch) | |
| tree | 9b5621491eb009b0d9220efc35e6fb33f57dc98a | |
| parent | 719985a9e2aeaf2cba960f1525325ff125b7e19b (diff) | |
| download | sssd-46ebf4415306454e1d062b61a2495b7cdb821c0f.tar.gz sssd-46ebf4415306454e1d062b61a2495b7cdb821c0f.tar.xz sssd-46ebf4415306454e1d062b61a2495b7cdb821c0f.zip | |
SDAP: nitpicks in sdap_access_filter_get_access_done
Fixed typo and replaced duplicated string by macro definition.
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
| -rw-r--r-- | src/providers/ldap/sdap_access.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/src/providers/ldap/sdap_access.c b/src/providers/ldap/sdap_access.c index 33277e7d1..94c64eff4 100644 --- a/src/providers/ldap/sdap_access.c +++ b/src/providers/ldap/sdap_access.c @@ -40,6 +40,8 @@ #include "providers/data_provider.h" #include "providers/dp_backend.h" +#define MALFORMED_FILTER "Malformed access control filter [%s]\n" + static errno_t sdap_save_user_cache_bool(struct sss_domain_info *domain, const char *username, const char *attr_name, @@ -874,10 +876,8 @@ static void sdap_access_filter_get_access_done(struct tevent_req *subreq) } else if (dp_error == DP_ERR_OFFLINE) { ret = sdap_access_filter_decide_offline(req); } else if (ret == ERR_INVALID_FILTER) { - sss_log(SSS_LOG_ERR, - "Malformed access control filter [%s]\n", state->filter); - DEBUG(SSSDBG_CRIT_FAILURE, - "Malformed access control filter [%s]\n", state->filter); + sss_log(SSS_LOG_ERR, MALFORMED_FILTER, state->filter); + DEBUG(SSSDBG_CRIT_FAILURE, MALFORMED_FILTER, state->filter); ret = ERR_ACCESS_DENIED; } else { DEBUG(SSSDBG_CRIT_FAILURE, @@ -917,9 +917,7 @@ static void sdap_access_filter_get_access_done(struct tevent_req *subreq) } if (found) { - /* Save "allow" to the cache for future offline - :q* access checks. - */ + /* Save "allow" to the cache for future offline access checks. */ DEBUG(SSSDBG_TRACE_FUNC, "Access granted by online lookup\n"); ret = EOK; } |