diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-08-20 19:21:40 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-08-22 11:00:13 +0200 |
| commit | 9046ade0da38e739eb6d645f04542b28f1acd91c (patch) | |
| tree | 3f7a097b8269c640319ad0462a68e092db15ae7d | |
| parent | 61d9a9138d3a2a2c18873b1f2e6f1a5391383709 (diff) | |
| download | sssd-9046ade0da38e739eb6d645f04542b28f1acd91c.tar.gz sssd-9046ade0da38e739eb6d645f04542b28f1acd91c.tar.xz sssd-9046ade0da38e739eb6d645f04542b28f1acd91c.zip | |
responder-get-domains-tests: fix checking of leaks
global_talloc_context should not be NULL in tests. It should be initialised
with function leak_check_setup otherwise memory leak will not be detected.
check_leaks_pop should not be directly called for global_talloc_context.
It is a purpose of function leak_check_teardown
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
(cherry picked from commit bf65fbdd8c3fecd38a66363c3517e7a2679b8186)
| -rw-r--r-- | src/tests/cmocka/test_responder_common.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/tests/cmocka/test_responder_common.c b/src/tests/cmocka/test_responder_common.c index 58aa32b5d..fb1217700 100644 --- a/src/tests/cmocka/test_responder_common.c +++ b/src/tests/cmocka/test_responder_common.c @@ -88,8 +88,7 @@ void parse_inp_test_setup(void **state) { struct parse_inp_test_ctx *parse_inp_ctx; - check_leaks_push(global_talloc_context); - + assert_true(leak_check_setup()); parse_inp_ctx = talloc_zero(global_talloc_context, struct parse_inp_test_ctx); assert_non_null(parse_inp_ctx); @@ -119,7 +118,7 @@ void parse_inp_test_teardown(void **state) assert_true(check_leaks_pop(parse_inp_ctx) == true); talloc_free(parse_inp_ctx); - assert_true(check_leaks_pop(global_talloc_context) == true); + assert_true(leak_check_teardown()); } int __real_sss_parse_name_for_domains(TALLOC_CTX *memctx, |