summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2014-12-05 11:03:48 +0100
committerJakub Hrozek <jhrozek@redhat.com>2015-01-14 12:15:18 +0100
commit8eb022f5a34e86b091c62fb0c9b30834021f1e23 (patch)
tree675fb2ab82ee85d3ba93ec5f3ec0648645a364e3
parent7d4d2a29a210964024f971708e82c441034d49a7 (diff)
downloadsssd-8eb022f5a34e86b091c62fb0c9b30834021f1e23.tar.gz
sssd-8eb022f5a34e86b091c62fb0c9b30834021f1e23.tar.xz
sssd-8eb022f5a34e86b091c62fb0c9b30834021f1e23.zip
IPA: make version check more precise
The call protected by the check does not only expect the version 1 of the extdom plugin is used but a specific response type as well. Since version 1 can return older response types as well we want to be on the safe side. Reviewed-by: Jakub Hrozek <jhrozek@redhat.com> (cherry picked from commit 2fc12875f7d51248799016c19c1298b85e06a286)
-rw-r--r--src/providers/ipa/ipa_s2n_exop.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/providers/ipa/ipa_s2n_exop.c b/src/providers/ipa/ipa_s2n_exop.c
index 1d9a79a38..b02387a82 100644
--- a/src/providers/ipa/ipa_s2n_exop.c
+++ b/src/providers/ipa/ipa_s2n_exop.c
@@ -759,7 +759,7 @@ static errno_t s2n_response_to_attrs(TALLOC_CTX *mem_ctx,
attrs->a.user.pw_uid = uid;
attrs->a.user.pw_gid = gid;
- if (is_v1) {
+ if (is_v1 && type == RESP_USER_GROUPLIST) {
ret = add_v1_user_data(ber, attrs);
if (ret != EOK) {
DEBUG(SSSDBG_OP_FAILURE, "add_v1_user_data failed.\n");
@@ -798,7 +798,7 @@ static errno_t s2n_response_to_attrs(TALLOC_CTX *mem_ctx,
attrs->a.group.gr_gid = gid;
- if (is_v1) {
+ if (is_v1 && type == RESP_GROUP_MEMBERS) {
ret = add_v1_group_data(ber, attrs);
if (ret != EOK) {
DEBUG(SSSDBG_OP_FAILURE, "add_v1_group_data failed.\n");