summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPavel Reichl <preichl@redhat.com>2015-02-25 05:38:38 -0500
committerJakub Hrozek <jhrozek@redhat.com>2015-03-03 16:31:45 +0100
commitfcb087c3a51b665d96f10fb03cfb889cc441e0ae (patch)
tree0558985a4a7ecee6e94a62fdb50d23a6ef61c151
parent548f998fa87807740fbd21857fd49f47bcb9d870 (diff)
downloadsssd-fcb087c3a51b665d96f10fb03cfb889cc441e0ae.tar.gz
sssd-fcb087c3a51b665d96f10fb03cfb889cc441e0ae.tar.xz
sssd-fcb087c3a51b665d96f10fb03cfb889cc441e0ae.zip
PAM: check return value of confdb_get_string
Coverity found this neglect. Reviewed-by: Jakub Hrozek <jhrozek@redhat.com> (cherry picked from commit c5290f2175845f2c5e3f35ce279b6f52b1d51275)
-rw-r--r--src/responder/pam/pamsrv_cmd.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c
index ab8369b0f..86e763f82 100644
--- a/src/responder/pam/pamsrv_cmd.c
+++ b/src/responder/pam/pamsrv_cmd.c
@@ -679,6 +679,12 @@ static void pam_reply(struct pam_auth_req *preq)
ret = confdb_get_string(pctx->rctx->cdb, pd, CONFDB_PAM_CONF_ENTRY,
CONFDB_PAM_ACCOUNT_EXPIRED_MESSAGE, "",
&pam_account_expired_message);
+ if (ret != EOK) {
+ DEBUG(SSSDBG_MINOR_FAILURE,
+ "Failed to get expiration message: %d:[%s].\n",
+ ret, sss_strerror(ret));
+ goto done;
+ }
inform_account_expired(pd, pam_account_expired_message);
}