diff options
| author | Pavel Reichl <preichl@redhat.com> | 2015-03-09 05:45:20 -0400 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-03-13 15:30:21 +0100 |
| commit | 82a28b6e8cde92eac8db2267083901d7f2f4f855 (patch) | |
| tree | 5bf3cb38ba7e6ac68d047768126e758ecd14dfb4 | |
| parent | fd725d5de53c3bd45a7fa7e375e9f43dbf960ce6 (diff) | |
| download | sssd-82a28b6e8cde92eac8db2267083901d7f2f4f855.tar.gz sssd-82a28b6e8cde92eac8db2267083901d7f2f4f855.tar.xz sssd-82a28b6e8cde92eac8db2267083901d7f2f4f855.zip | |
ldap_child: fix coverity warning
In ldap_child_get_tgt_sync() variable 'ret' got overriden in done
section without ever before being read.
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
(cherry picked from commit 6ccda8691123bb27f5f2a88a0c80174af3e0fd0a)
| -rw-r--r-- | src/providers/ldap/ldap_child.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/providers/ldap/ldap_child.c b/src/providers/ldap/ldap_child.c index 8f034affa..82481d6e7 100644 --- a/src/providers/ldap/ldap_child.c +++ b/src/providers/ldap/ldap_child.c @@ -391,14 +391,20 @@ static krb5_error_code ldap_child_get_tgt_sync(TALLOC_CTX *memctx, ccname_file = talloc_asprintf(tmp_ctx, "%s/ccache_%s", DB_PATH, realm_name); if (ccname_file == NULL) { - ret = ENOMEM; + krberr = ENOMEM; + DEBUG(SSSDBG_CRIT_FAILURE, + "talloc_asprintf failed: %s:[%d].\n", + strerror(krberr), krberr); goto done; } ccname_file_dummy = talloc_asprintf(tmp_ctx, "%s/ccache_%s_XXXXXX", DB_PATH, realm_name); if (ccname_file_dummy == NULL) { - ret = ENOMEM; + krberr = ENOMEM; + DEBUG(SSSDBG_CRIT_FAILURE, + "talloc_asprintf failed: %s:[%d].\n", + strerror(krberr), krberr); goto done; } @@ -407,6 +413,10 @@ static krb5_error_code ldap_child_get_tgt_sync(TALLOC_CTX *memctx, umask(old_umask); if (fd == -1) { ret = errno; + DEBUG(SSSDBG_CRIT_FAILURE, + "mkstemp failed: %s:[%d].\n", + strerror(ret), ret); + krberr = KRB5KRB_ERR_GENERIC; goto done; } /* We only care about creating a unique file name here, we don't |