diff options
author | Sumit Bose <sbose@redhat.com> | 2014-12-17 09:42:57 +0100 |
---|---|---|
committer | Sumit Bose <sbose@redhat.com> | 2014-12-17 16:04:29 +0100 |
commit | 956dbefd49ce3cbf27539d8846a6d71462a3a927 (patch) | |
tree | a58b15ae2aaa1ab4be6b7e01fbbdf5141991c704 | |
parent | 4bbcc2d6d3f16b015796818746a45134861c93a4 (diff) | |
download | sssd-956dbefd49ce3cbf27539d8846a6d71462a3a927.tar.gz sssd-956dbefd49ce3cbf27539d8846a6d71462a3a927.tar.xz sssd-956dbefd49ce3cbf27539d8846a6d71462a3a927.zip |
krb5: handle KRB5KRB_ERR_GENERIC as unspecific error
KRB5KRB_ERR_GENERIC is a generic error and we cannot make any
assumptions about the cause. If there are cases where
KRB5KRB_ERR_GENERIC is returned and SSSD should behave differently this
must be solved by other means.
Resolves https://fedorahosted.org/sssd/ticket/2535
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
-rw-r--r-- | src/providers/krb5/krb5_child.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c index 64fe6f0cb..e5ce50be4 100644 --- a/src/providers/krb5/krb5_child.c +++ b/src/providers/krb5/krb5_child.c @@ -1076,7 +1076,6 @@ static errno_t map_krb5_error(krb5_error_code kerr) case KRB5_LIBOS_CANTREADPWD: return ERR_NO_CREDS; - case KRB5KRB_ERR_GENERIC: case KRB5KRB_AP_ERR_SKEW: case KRB5_KDC_UNREACH: case KRB5_REALM_CANT_RESOLVE: @@ -1099,6 +1098,18 @@ static errno_t map_krb5_error(krb5_error_code kerr) case KRB5KDC_ERR_PREAUTH_FAILED: return ERR_CREDS_INVALID; + /* Please do not remove KRB5KRB_ERR_GENERIC here, it is a _generic_ error + * code and we cannot make any assumptions about the reason for the error. + * As a consequence we cannot return a different error code than a generic + * one which unfortunately might result in a unspecific system error + * message to the user. + * + * If there are cases where libkrb5 calls return KRB5KRB_ERR_GENERIC where + * SSSD should behave differently this has to be detected by different + * means, e.g. by evaluation error messages, and then the error code + * should be changed to a more suitable KRB5* error code or immediately to + * a SSSD ERR_* error code to avoid the default handling here. */ + case KRB5KRB_ERR_GENERIC: default: return ERR_INTERNAL; } |