summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2013-10-18 15:54:22 +0200
committerJakub Hrozek <jhrozek@redhat.com>2013-10-22 19:15:33 +0200
commit5fe6ca5e339fd345119752e996c14edf8db57660 (patch)
tree3fc3ba530922a48fe7b3413ae0ffd76cfc7aad78
parentfab48878db202d620f43c9da23e375866d1db2c6 (diff)
downloadsssd-5fe6ca5e339fd345119752e996c14edf8db57660.tar.gz
sssd-5fe6ca5e339fd345119752e996c14edf8db57660.tar.xz
sssd-5fe6ca5e339fd345119752e996c14edf8db57660.zip
sdap_get_generic_ext_send: check if we a re still connected
At the beginning of a LDAP request we check if we are connecte and have a valid sdap handle. But for some requests more than one LDAP operation, typically a search, is needed. Due to the asynchronous handling of LDAP request it might be possible that a second request might detect a server error and close the connection while the first request just finished one LDAP search and wants to start a new LDAP search. This patch tries to make sure that there is a valid sdap handle before sending a LDAP search to the server. Fixes https://fedorahosted.org/sssd/ticket/2126
-rw-r--r--src/providers/ldap/sdap_async.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index 09275dd65..f5cc962b3 100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -1167,6 +1167,13 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx,
state->cb_data = cb_data;
state->clientctrls = clientctrls;
+ if (state->sh == NULL || state->sh->ldap == NULL) {
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ ("Trying LDAP search while not connected.\n"));
+ tevent_req_error(req, EIO);
+ tevent_req_post(req, ev);
+ return req;
+ }
/* Be extra careful and never allow paging for BASE searches,
* even if requested.