summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPavel Reichl <preichl@redhat.com>2015-09-03 04:46:50 -0400
committerJakub Hrozek <jhrozek@redhat.com>2015-09-07 18:39:57 +0200
commit5dbdcc2c7210a0e3eb60ad1e85ba33f27d7faeda (patch)
treee582c322b3c85526f7cb12296b9a8e5086f16eab
parentaf3a627a3ff5402aad02edc6d48576b3c69458e5 (diff)
downloadsssd-5dbdcc2c7210a0e3eb60ad1e85ba33f27d7faeda.tar.gz
sssd-5dbdcc2c7210a0e3eb60ad1e85ba33f27d7faeda.tar.xz
sssd-5dbdcc2c7210a0e3eb60ad1e85ba33f27d7faeda.zip
GPO: fix memory leak
Resolves: https://fedorahosted.org/sssd/ticket/2777 Reviewed-by: Michal Židek <mzidek@redhat.com>
-rw-r--r--src/providers/ad/ad_gpo.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
index ffd8ac5dd..12632e56e 100644
--- a/src/providers/ad/ad_gpo.c
+++ b/src/providers/ad/ad_gpo.c
@@ -560,14 +560,14 @@ ad_gpo_get_sids(TALLOC_CTX *mem_ctx,
DEBUG(SSSDBG_OP_FAILURE,
"sysdb_initgroups failed: [%d](%s)\n",
ret, sss_strerror(ret));
- return ret;
+ goto done;
}
if (res->count == 0) {
ret = ENOENT;
DEBUG(SSSDBG_OP_FAILURE,
"sysdb_initgroups returned empty result\n");
- return ret;
+ goto done;
}
user_sid = ldb_msg_find_attr_as_string(res->msgs[0], SYSDB_SID_STR, NULL);
@@ -602,7 +602,7 @@ ad_gpo_get_sids(TALLOC_CTX *mem_ctx,
*_group_size = num_group_sids + 1;
*_group_sids = talloc_steal(mem_ctx, group_sids);
*_user_sid = talloc_steal(mem_ctx, user_sid);
- return EOK;
+ ret = EOK;
done:
talloc_free(tmp_ctx);