diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-10-02 18:30:56 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-10-03 16:25:00 +0200 |
| commit | 1f2756f065e789ec9e9c9f6f11f3bfc8208ae7bf (patch) | |
| tree | 98b4d05d27ef776a5d0cbe6f6b6551795aedef32 | |
| parent | 4611802d41d8954a3040f39403590adb920ca521 (diff) | |
| download | sssd-1f2756f065e789ec9e9c9f6f11f3bfc8208ae7bf.tar.gz sssd-1f2756f065e789ec9e9c9f6f11f3bfc8208ae7bf.tar.xz sssd-1f2756f065e789ec9e9c9f6f11f3bfc8208ae7bf.zip | |
GPO: Use argument ndg_flags instead of constant
Some internal gpo functions [1] were called just once and with constant
NDR_SCALARS as 2nd argument(ndr_flags), but 2nd argument was not used
in these functions[1]. They used constant NDR_SCALARS.
[1] ndr_pull_security_ace_flags, ndr_pull_security_ace_type,
ndr_pull_security_ace_object_flags, ndr_pull_security_acl_revision,
ndr_pull_security_descriptor_revision, ndr_pull_security_descriptor_type
Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>
| -rw-r--r-- | src/providers/ad/ad_gpo_ndr.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/providers/ad/ad_gpo_ndr.c b/src/providers/ad/ad_gpo_ndr.c index 0ee28f097..884ab763a 100644 --- a/src/providers/ad/ad_gpo_ndr.c +++ b/src/providers/ad/ad_gpo_ndr.c @@ -69,7 +69,7 @@ ndr_pull_security_ace_flags(struct ndr_pull *ndr, uint8_t *r) { uint8_t v; - NDR_CHECK(ndr_pull_uint8(ndr, NDR_SCALARS, &v)); + NDR_CHECK(ndr_pull_uint8(ndr, ndr_flags, &v)); *r = v; return NDR_ERR_SUCCESS; } @@ -81,7 +81,7 @@ ndr_pull_security_ace_type(struct ndr_pull *ndr, enum security_ace_type *r) { uint8_t v; - NDR_CHECK(ndr_pull_enum_uint8(ndr, NDR_SCALARS, &v)); + NDR_CHECK(ndr_pull_enum_uint8(ndr, ndr_flags, &v)); *r = v; return NDR_ERR_SUCCESS; } @@ -93,7 +93,7 @@ ndr_pull_security_ace_object_flags(struct ndr_pull *ndr, uint32_t *r) { uint32_t v; - NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &v)); + NDR_CHECK(ndr_pull_uint32(ndr, ndr_flags, &v)); *r = v; return NDR_ERR_SUCCESS; } @@ -314,7 +314,7 @@ ndr_pull_security_acl_revision(struct ndr_pull *ndr, enum security_acl_revision *r) { uint16_t v; - NDR_CHECK(ndr_pull_enum_uint1632(ndr, NDR_SCALARS, &v)); + NDR_CHECK(ndr_pull_enum_uint1632(ndr, ndr_flags, &v)); *r = v; return NDR_ERR_SUCCESS; } @@ -369,7 +369,7 @@ ndr_pull_security_descriptor_revision(struct ndr_pull *ndr, enum security_descriptor_revision *r) { uint8_t v; - NDR_CHECK(ndr_pull_enum_uint8(ndr, NDR_SCALARS, &v)); + NDR_CHECK(ndr_pull_enum_uint8(ndr, ndr_flags, &v)); *r = v; return NDR_ERR_SUCCESS; } @@ -382,7 +382,7 @@ ndr_pull_security_descriptor_type(struct ndr_pull *ndr, uint16_t *r) { uint16_t v; - NDR_CHECK(ndr_pull_uint16(ndr, NDR_SCALARS, &v)); + NDR_CHECK(ndr_pull_uint16(ndr, ndr_flags, &v)); *r = v; return NDR_ERR_SUCCESS; } |