summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPetr Cech <pcech@redhat.com>2015-09-10 10:05:59 -0400
committerLukas Slebodnik <lslebodn@redhat.com>2015-10-27 10:44:02 +0100
commit152fed23797c8950ca18cf6dc2bddb61a3f615c8 (patch)
treedae0995a22665656d080d91c8bc58d2fd4b3b5d3
parent617d5161d4ec454afc673ce1836b02f82435b347 (diff)
downloadsssd-152fed23797c8950ca18cf6dc2bddb61a3f615c8.tar.gz
sssd-152fed23797c8950ca18cf6dc2bddb61a3f615c8.tar.xz
sssd-152fed23797c8950ca18cf6dc2bddb61a3f615c8.zip
DEBUG: Preventing chown_debug_file if journald on
There is function chown_debug_file() which didn't check if the SSSD is compiled with journald support. This patch add simple checking of this state. Resolves: https://fedorahosted.org/sssd/ticket/2493 Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
-rw-r--r--src/util/debug.c35
1 files changed, 19 insertions, 16 deletions
diff --git a/src/util/debug.c b/src/util/debug.c
index bd13fdecd..a8eea3274 100644
--- a/src/util/debug.c
+++ b/src/util/debug.c
@@ -316,24 +316,27 @@ int chown_debug_file(const char *filename,
const char *log_file;
errno_t ret;
- if (filename == NULL) {
- log_file = debug_log_file;
- } else {
- log_file = filename;
- }
+ if (debug_file) {
- ret = asprintf(&logpath, "%s/%s.log", LOG_PATH, log_file);
- if (ret == -1) {
- return ENOMEM;
- }
+ if (filename == NULL) {
+ log_file = debug_log_file;
+ } else {
+ log_file = filename;
+ }
- ret = chown(logpath, uid, gid);
- free(logpath);
- if (ret != 0) {
- ret = errno;
- DEBUG(SSSDBG_FATAL_FAILURE, "chown failed for [%s]: [%d]\n",
- log_file, ret);
- return ret;
+ ret = asprintf(&logpath, "%s/%s.log", LOG_PATH, log_file);
+ if (ret == -1) {
+ return ENOMEM;
+ }
+
+ ret = chown(logpath, uid, gid);
+ free(logpath);
+ if (ret != 0) {
+ ret = errno;
+ DEBUG(SSSDBG_FATAL_FAILURE, "chown failed for [%s]: [%d]\n",
+ log_file, ret);
+ return ret;
+ }
}
return EOK;