cache_req: remove default branch from switches

Originaly, the cache_req used enum sss_dp_acct_type to indicate
request type but not all types were implemented. Thus we used default
branch to indicate unimplemented request type.

Now when we switched to a custom enum type we can get rid of the default
branch so the compiler can check if all switches contains all values.
This proved to be useful during development of new request types.

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>

1 files changed, 4 insertions, 20 deletions

diff --git a/src/responder/common/responder_cache_req.c b/src/responder/common/responder_cache_req.c
index e7a9fa348..4f94572a5 100644
--- a/src/responder/common/responder_cache_req.c
+++ b/src/responder/common/responder_cache_req.c
@@ -182,7 +182,7 @@ static errno_t cache_req_check_ncache(struct cache_req_input *input,
                                       struct sss_nc_ctx *ncache,
                                       int neg_timeout)
 {
-    errno_t ret;
+    errno_t ret = ERR_INTERNAL;
 
     switch (input->type) {
     case CACHE_REQ_USER_BY_NAME:
@@ -197,10 +197,6 @@ static errno_t cache_req_check_ncache(struct cache_req_input *input,
     case CACHE_REQ_USER_BY_ID:
         ret = sss_ncache_check_uid(ncache, neg_timeout, input->id);
         break;
-    default:
-        ret = EINVAL;
-        DEBUG(SSSDBG_CRIT_FAILURE, "Unsupported cache request type\n");
-        break;
     }
 
     if (ret == EEXIST) {
@@ -214,7 +210,7 @@ static errno_t cache_req_check_ncache(struct cache_req_input *input,
 static void cache_req_add_to_ncache(struct cache_req_input *input,
                                     struct sss_nc_ctx *ncache)
 {
-    errno_t ret;
+    errno_t ret = ERR_INTERNAL;
 
     switch (input->type) {
     case CACHE_REQ_USER_BY_NAME:
@@ -232,10 +228,6 @@ static void cache_req_add_to_ncache(struct cache_req_input *input,
          * if all domains are search and the entry is not found. */
         ret = EOK;
         break;
-    default:
-        ret = EINVAL;
-        DEBUG(SSSDBG_CRIT_FAILURE, "Unsupported cache request type\n");
-        break;
     }
 
     if (ret != EOK) {
@@ -264,10 +256,6 @@ static void cache_req_add_to_ncache_global(struct cache_req_input *input,
     case CACHE_REQ_USER_BY_ID:
         ret = sss_ncache_set_uid(ncache, false, input->id);
         break;
-    default:
-        ret = EINVAL;
-        DEBUG(SSSDBG_CRIT_FAILURE, "Unsupported cache request type\n");
-        break;
     }
 
     if (ret != EOK) {
@@ -285,8 +273,8 @@ static errno_t cache_req_get_object(TALLOC_CTX *mem_ctx,
                                     struct ldb_result **_result)
 {
     struct ldb_result *result = NULL;
-    bool one_item_only;
-    errno_t ret;
+    bool one_item_only = false;
+    errno_t ret = ERR_INTERNAL;
 
     DEBUG(SSSDBG_FUNC_DATA, "Requesting info for [%s]\n", input->debug_fqn);
 
@@ -311,10 +299,6 @@ static errno_t cache_req_get_object(TALLOC_CTX *mem_ctx,
         ret = sysdb_initgroups_with_views(mem_ctx, input->domain,
                                           input->dom_objname, &result);
         break;
-    default:
-        ret = EINVAL;
-        DEBUG(SSSDBG_CRIT_FAILURE, "Unsupported cache request type\n");
-        break;
     }
 
     if (ret != EOK) {