sssd.git/src/tests, branch misc sssd with jhrozek's patches sbus: Check string arguments for valid UTF-8 strings 2015-11-09T14:33:46+00:00 Jakub Hrozek jhrozek@redhat.com 2015-11-06T19:54:13+00:00 b9a9bc90c8be499c84533b3687aae3dfe835a117 libdbus abort()s when a string argument is not valid UTF-8. Since the arguments sometimes come from untrusted sources, it's better to check the string validity explicitly. 
libdbus abort()s when a string argument is not valid UTF-8. Since the
arguments sometimes come from untrusted sources, it's better to check
the string validity explicitly.
sbus: Add a compat wrapper sbus_validate_utf8() 2015-11-09T14:33:45+00:00 Jakub Hrozek jhrozek@redhat.com 2015-11-06T21:11:04+00:00 eef26709738de724a41919d3a7079a90b4273908 






pam-srv-tests: Change service name
2015-11-05T07:57:05+00:00

Sumit Bose
sbose@redhat.com

2015-11-05T07:53:33+00:00

8cfc3d5aeea21a3b8d1801aeef4866a4d3e7add0

It would be better to not use 'ssh' or 'sshd' here at all but something like
'pam_test_service' to indicate that it is a generic name.

Because a default value should not lead to a code path which handles a
special case. The general PAM responder test should not run through the
'sshd' case in pam_reply() only if the service is set explicitly to
'sshd' this features should be tests.

Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>





It would be better to not use 'ssh' or 'sshd' here at all but something like
'pam_test_service' to indicate that it is a generic name.

Because a default value should not lead to a code path which handles a
special case. The general PAM responder test should not run through the
'sshd' case in pam_reply() only if the service is set explicitly to
'sshd' this features should be tests.

Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>







NSS: fix a use-after-free issue
2015-11-04T08:37:57+00:00

Sumit Bose
sbose@redhat.com

2015-10-30T15:28:37+00:00

343b053bc61792023003d077ae81c05ff1676a89

While handling well-known SIDs a debug statement tries to access memory that is
already freed. This can be seen with the following output from valgrind.

==17600== Invalid read of size 4
==17600==    at 0x805ACC6: nss_cmd_getbysid (nsssrv_cmd.c:5458)
==17600==    by 0x805AF41: nss_cmd_getnamebysid (nsssrv_cmd.c:5509)
==17600==    by 0x80662F4: sss_cmd_execute (responder_cmd.c:161)
==17600==    by 0x8067015: client_cmd_execute (responder_common.c:249)
==17600==    by 0x80671F5: client_recv (responder_common.c:283)
==17600==    by 0x806741C: client_fd_handler (responder_common.c:335)
==17600==    by 0x45F5112: epoll_event_loop (tevent_epoll.c:728)
==17600==    by 0x45F5112: epoll_event_loop_once (tevent_epoll.c:926)
==17600==    by 0x45F32EE: std_event_loop_once (tevent_standard.c:114)
==17600==    by 0x45EF3BF: _tevent_loop_once (tevent.c:530)
==17600==    by 0x45EF5AB: tevent_common_loop_wait (tevent.c:634)
==17600==    by 0x45F326E: std_event_loop_wait (tevent_standard.c:140)
==17600==    by 0x45EF647: _tevent_loop_wait (tevent.c:653)
==17600==  Address 0x4b248a0 is 72 bytes inside a block of size 88 free'd
==17600==    at 0x402C26D: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==17600==    by 0x45FEC9E: _talloc_free_internal (talloc.c:1057)
==17600==    by 0x45FEC9E: _talloc_free (talloc.c:1581)
==17600==    by 0x8066085: sss_cmd_done (responder_cmd.c:93)
==17600==    by 0x805A9B0: nss_check_well_known_sid (nsssrv_cmd.c:5382)
==17600==    by 0x805AC86: nss_cmd_getbysid (nsssrv_cmd.c:5455)
==17600==    by 0x805AF41: nss_cmd_getnamebysid (nsssrv_cmd.c:5509)
==17600==    by 0x80662F4: sss_cmd_execute (responder_cmd.c:161)
==17600==    by 0x8067015: client_cmd_execute (responder_common.c:249)
==17600==    by 0x80671F5: client_recv (responder_common.c:283)
==17600==    by 0x806741C: client_fd_handler (responder_common.c:335)
==17600==    by 0x45F5112: epoll_event_loop (tevent_epoll.c:728)
==17600==    by 0x45F5112: epoll_event_loop_once (tevent_epoll.c:926)
==17600==    by 0x45F32EE: std_event_loop_once (tevent_standard.c:114)
==17600==

The patch contains a change to the unit tests which frees the memory in
the wrapper for sss_cmd_done() too. This allows to detect this kind of
issue in the unit tests as well.

Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>





While handling well-known SIDs a debug statement tries to access memory that is
already freed. This can be seen with the following output from valgrind.

==17600== Invalid read of size 4
==17600==    at 0x805ACC6: nss_cmd_getbysid (nsssrv_cmd.c:5458)
==17600==    by 0x805AF41: nss_cmd_getnamebysid (nsssrv_cmd.c:5509)
==17600==    by 0x80662F4: sss_cmd_execute (responder_cmd.c:161)
==17600==    by 0x8067015: client_cmd_execute (responder_common.c:249)
==17600==    by 0x80671F5: client_recv (responder_common.c:283)
==17600==    by 0x806741C: client_fd_handler (responder_common.c:335)
==17600==    by 0x45F5112: epoll_event_loop (tevent_epoll.c:728)
==17600==    by 0x45F5112: epoll_event_loop_once (tevent_epoll.c:926)
==17600==    by 0x45F32EE: std_event_loop_once (tevent_standard.c:114)
==17600==    by 0x45EF3BF: _tevent_loop_once (tevent.c:530)
==17600==    by 0x45EF5AB: tevent_common_loop_wait (tevent.c:634)
==17600==    by 0x45F326E: std_event_loop_wait (tevent_standard.c:140)
==17600==    by 0x45EF647: _tevent_loop_wait (tevent.c:653)
==17600==  Address 0x4b248a0 is 72 bytes inside a block of size 88 free'd
==17600==    at 0x402C26D: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==17600==    by 0x45FEC9E: _talloc_free_internal (talloc.c:1057)
==17600==    by 0x45FEC9E: _talloc_free (talloc.c:1581)
==17600==    by 0x8066085: sss_cmd_done (responder_cmd.c:93)
==17600==    by 0x805A9B0: nss_check_well_known_sid (nsssrv_cmd.c:5382)
==17600==    by 0x805AC86: nss_cmd_getbysid (nsssrv_cmd.c:5455)
==17600==    by 0x805AF41: nss_cmd_getnamebysid (nsssrv_cmd.c:5509)
==17600==    by 0x80662F4: sss_cmd_execute (responder_cmd.c:161)
==17600==    by 0x8067015: client_cmd_execute (responder_common.c:249)
==17600==    by 0x80671F5: client_recv (responder_common.c:283)
==17600==    by 0x806741C: client_fd_handler (responder_common.c:335)
==17600==    by 0x45F5112: epoll_event_loop (tevent_epoll.c:728)
==17600==    by 0x45F5112: epoll_event_loop_once (tevent_epoll.c:926)
==17600==    by 0x45F32EE: std_event_loop_once (tevent_standard.c:114)
==17600==

The patch contains a change to the unit tests which frees the memory in
the wrapper for sss_cmd_done() too. This allows to detect this kind of
issue in the unit tests as well.

Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>







tests: Regression test with wrong LC_ALL
2015-11-04T08:09:38+00:00

Michal Židek
mzidek@redhat.com

2015-10-20T13:03:22+00:00

586f512ab8b6e5a03349598846141f43c1d505b8

Ticket:
https://fedorahosted.org/sssd/ticket/2785

Test local domain tool with wrong LC_ALL
environment variable value.

NOTE: The memory cache files are not deleted
properly in the test teardown to work around the
problem described in ticket
https://fedorahosted.org/sssd/ticket/2726

Once the ticket above is solved, the teardown
will be updated to remove the memory cache
files.

Reviewed-by: Michal Židek <mzidek@redhat.com>





Ticket:
https://fedorahosted.org/sssd/ticket/2785

Test local domain tool with wrong LC_ALL
environment variable value.

NOTE: The memory cache files are not deleted
properly in the test teardown to work around the
problem described in ticket
https://fedorahosted.org/sssd/ticket/2726

Once the ticket above is solved, the teardown
will be updated to remove the memory cache
files.

Reviewed-by: Michal Židek <mzidek@redhat.com>







sbus_codegen_tests: Suppress warning Wmaybe-uninitialized
2015-10-26T15:02:23+00:00

Lukas Slebodnik
lslebodn@redhat.com

2015-10-26T13:14:58+00:00

617d5161d4ec454afc673ce1836b02f82435b347

There is a warning with gcc 4.8

src/tests/sbus_codegen_tests.c:1131:18: warning: 'exp_values' may be used
    uninitialized in this function [-Wmaybe-uninitialized]
     const char **exp_values;
                  ^
Reviewed-by: Pavel Březina <pbrezina@redhat.com>





There is a warning with gcc 4.8

src/tests/sbus_codegen_tests.c:1131:18: warning: 'exp_values' may be used
    uninitialized in this function [-Wmaybe-uninitialized]
     const char **exp_values;
                  ^
Reviewed-by: Pavel Březina <pbrezina@redhat.com>







BUILD: Remove SSS_CRYPTO_LIBS from common libraries
2015-10-26T06:23:15+00:00

Lukas Slebodnik
lslebodn@redhat.com

2015-10-19T06:50:33+00:00

a751a11eec71c42b8aaf723a0eefc3babd35ad32

The similarcahnge was done in main makefile by change
69b46c32357ccf1aab9c0bd6d1afa33a8724ad77

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>





The similarcahnge was done in main makefile by change
69b46c32357ccf1aab9c0bd6d1afa33a8724ad77

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>







BUILD: Remove unused variables
2015-10-26T06:23:11+00:00

Lukas Slebodnik
lslebodn@redhat.com

2015-10-19T06:48:03+00:00

e1c899eaa30f25eee7d2a62b0007d764fda1b722

LIBCAPNG_{CFLAGS,LIBS} are not defined anywhere in sssd.
It could be introduced as copy&paste error from different project.

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>





LIBCAPNG_{CFLAGS,LIBS} are not defined anywhere in sssd.
It could be introduced as copy&paste error from different project.

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>







responder_common_tests: Removed unused libraries
2015-10-26T06:23:07+00:00

Lukas Slebodnik
lslebodn@redhat.com

2015-10-19T06:45:10+00:00

ebbbaeb5d9ae22ca92a9a8920c1bde3f100a8d7f

responder_common_tests does not use any function which requires to link
with UNICODE linraries or with libsss_crypt

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>





responder_common_tests does not use any function which requires to link
with UNICODE linraries or with libsss_crypt

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>







intg_tests: Fix PEP8 warnings
2015-10-26T06:15:26+00:00

Lukas Slebodnik
lslebodn@redhat.com

2015-10-23T06:52:49+00:00

46c89176fd7f140d785bbdc399a94daca269172e

Reviewed-by: Michal Židek <mzidek@redhat.com>





Reviewed-by: Michal Židek <mzidek@redhat.com>