sssd.git/src/python, branch sid_index sssd with jhrozek's patches Python3 support in SSSD 2015-02-13T17:36:50+00:00 Bohuslav Kabrda bkabrda@redhat.com 2014-12-12T10:04:40+00:00 9687d7db79e15846de385537a99525d11cae6a15 https://fedorahosted.org/sssd/ticket/2017 (cherry picked from commit 341a00311680a440d7f979f06c34c70d86c9367a) 
https://fedorahosted.org/sssd/ticket/2017
(cherry picked from commit 341a00311680a440d7f979f06c34c70d86c9367a)
pysss: Fix double free 2015-01-30T10:35:06+00:00 Lukas Slebodnik lslebodn@redhat.com 2015-01-29T07:10:36+00:00 8e0766215aef902eec24d880fbf2b30686c452e6 The talloc context is removed in destructor. ==1695== Invalid read of size 4 ==1695== at 0x1243D0CD: talloc_chunk_from_ptr (talloc.c:372) ==1695== by 0x1243D0CD: _talloc_free (talloc.c:1559) ==1695== by 0x117B18C3: PySssLocalObject_dealloc (pysss.c:836) ==1695== by 0x117B1AEE: PySssLocalObject_new (pysss.c:898) ==1695== by 0x4ED5522: type_call (typeobject.c:729) ==1695== by 0x4E7F902: PyObject_Call (abstract.c:2529) ==1695== by 0x4F15584: do_call (ceval.c:4328) ==1695== by 0x4F15584: call_function (ceval.c:4133) ==1695== by 0x4F15584: PyEval_EvalFrameEx (ceval.c:2753) ==1695== by 0x4F16BE5: fast_function (ceval.c:4196) ==1695== by 0x4F16BE5: call_function (ceval.c:4131) ==1695== by 0x4F16BE5: PyEval_EvalFrameEx (ceval.c:2753) ==1695== by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342) ==1695== by 0x4EA46BC: function_call (funcobject.c:526) ==1695== by 0x4E7F902: PyObject_Call (abstract.c:2529) ==1695== by 0x4F1504F: ext_do_call (ceval.c:4423) ==1695== by 0x4F1504F: PyEval_EvalFrameEx (ceval.c:2792) ==1695== by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342) ==1695== Address 0x112d4560 is 64 bytes inside a block of size 96 free'd ==1695== at 0x4C2ACE9: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==1695== by 0x1243D2F2: _talloc_free_internal (talloc.c:1057) ==1695== by 0x1243D2F2: _talloc_free (talloc.c:1581) ==1695== by 0x117B1ABF: PySssLocalObject_new (pysss.c:876) ==1695== by 0x4ED5522: type_call (typeobject.c:729) ==1695== by 0x4E7F902: PyObject_Call (abstract.c:2529) ==1695== by 0x4F15584: do_call (ceval.c:4328) ==1695== by 0x4F15584: call_function (ceval.c:4133) ==1695== by 0x4F15584: PyEval_EvalFrameEx (ceval.c:2753) ==1695== by 0x4F16BE5: fast_function (ceval.c:4196) ==1695== by 0x4F16BE5: call_function (ceval.c:4131) ==1695== by 0x4F16BE5: PyEval_EvalFrameEx (ceval.c:2753) ==1695== by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342) ==1695== by 0x4EA46BC: function_call (funcobject.c:526) ==1695== by 0x4E7F902: PyObject_Call (abstract.c:2529) ==1695== by 0x4F1504F: ext_do_call (ceval.c:4423) ==1695== by 0x4F1504F: PyEval_EvalFrameEx (ceval.c:2792) ==1695== by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342) Reviewed-by: Pavel Reichl <preichl@redhat.com> (cherry picked from commit 3cd7275c3c41a03eb65769c2bf4e472d1de7b8c0) 
The talloc context is removed in destructor.

==1695== Invalid read of size 4
==1695==    at 0x1243D0CD: talloc_chunk_from_ptr (talloc.c:372)
==1695==    by 0x1243D0CD: _talloc_free (talloc.c:1559)
==1695==    by 0x117B18C3: PySssLocalObject_dealloc (pysss.c:836)
==1695==    by 0x117B1AEE: PySssLocalObject_new (pysss.c:898)
==1695==    by 0x4ED5522: type_call (typeobject.c:729)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F15584: do_call (ceval.c:4328)
==1695==    by 0x4F15584: call_function (ceval.c:4133)
==1695==    by 0x4F15584: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F16BE5: fast_function (ceval.c:4196)
==1695==    by 0x4F16BE5: call_function (ceval.c:4131)
==1695==    by 0x4F16BE5: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)
==1695==    by 0x4EA46BC: function_call (funcobject.c:526)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F1504F: ext_do_call (ceval.c:4423)
==1695==    by 0x4F1504F: PyEval_EvalFrameEx (ceval.c:2792)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)
==1695==  Address 0x112d4560 is 64 bytes inside a block of size 96 free'd
==1695==    at 0x4C2ACE9: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==1695==    by 0x1243D2F2: _talloc_free_internal (talloc.c:1057)
==1695==    by 0x1243D2F2: _talloc_free (talloc.c:1581)
==1695==    by 0x117B1ABF: PySssLocalObject_new (pysss.c:876)
==1695==    by 0x4ED5522: type_call (typeobject.c:729)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F15584: do_call (ceval.c:4328)
==1695==    by 0x4F15584: call_function (ceval.c:4133)
==1695==    by 0x4F15584: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F16BE5: fast_function (ceval.c:4196)
==1695==    by 0x4F16BE5: call_function (ceval.c:4131)
==1695==    by 0x4F16BE5: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)
==1695==    by 0x4EA46BC: function_call (funcobject.c:526)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F1504F: ext_do_call (ceval.c:4423)
==1695==    by 0x4F1504F: PyEval_EvalFrameEx (ceval.c:2792)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)

Reviewed-by: Pavel Reichl <preichl@redhat.com>
(cherry picked from commit 3cd7275c3c41a03eb65769c2bf4e472d1de7b8c0)
pyhbac,pysss: fix reference leaks 2014-10-22T14:40:25+00:00 Pavel Reichl preichl@redhat.com 2014-09-29T15:40:53+00:00 c52d7c41e4127a84f487777c0efa6996f6389c51 Resolves: https://fedorahosted.org/sssd/ticket/1195 Reviewed-by: Jakub Hrozek <jhrozek@redhat.com> 
Resolves:
https://fedorahosted.org/sssd/ticket/1195

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
pysss: test return value of realloc. 2014-09-05T15:34:04+00:00 Lukas Slebodnik lslebodn@redhat.com 2014-08-26T10:59:53+00:00 d79c604c5080c5f6e2bf2d91b4ae79a562437c74 It is not very likely that realloc will return NULL, but it's better to be defensive. src/python/pysss.c:774: var_assigned: Assigning: "groups" = null return value from "realloc". src/python/pysss.c:788: dereference: Dereferencing a null pointer "groups". Reviewed-by: Pavel Reichl <preichl@redhat.com> 
It is not very likely that realloc will return NULL, but it's better
to be defensive.

src/python/pysss.c:774: var_assigned: Assigning: "groups" = null return value from "realloc".
src/python/pysss.c:788: dereference: Dereferencing a null pointer "groups".

Reviewed-by: Pavel Reichl <preichl@redhat.com>
Remove unused structures. 2014-02-26T18:29:46+00:00 Lukas Slebodnik lslebodn@redhat.com 2014-02-26T09:21:03+00:00 a842b7eb49fd640d66aeaec26c05166ef55784f8 Reported by: cppcheck 'struct py_sss_transaction', 'struct resolve_get_domain_stat', 'struct sync_op_res' were defined in implementation modules, but they were not used anywhere. Reviewed-by: Michal Žídek <mzidek@redhat.com> 
Reported by: cppcheck

'struct py_sss_transaction', 'struct resolve_get_domain_stat',
'struct sync_op_res' were defined in implementation modules, but they were not
used anywhere.

Reviewed-by: Michal Žídek <mzidek@redhat.com>
Remove unused parameter from groupadd 2013-11-27T17:24:45+00:00 Lukas Slebodnik lslebodn@redhat.com 2013-11-09T11:40:24+00:00 28ce9dab8537870210761b15f037addd1de65e02 






Remove unused parameter from useradd
2013-11-27T17:24:45+00:00

Lukas Slebodnik
lslebodn@redhat.com

2013-11-09T11:37:30+00:00

b76531423695f649f1907422d9ecbb8c14143999












Remove unused parameter from groupmod
2013-11-27T17:24:45+00:00

Lukas Slebodnik
lslebodn@redhat.com

2013-11-09T11:34:13+00:00

397af5a7fa1db08b8b24dbd67d350b21263035a8












Remove unused parameter from usermod
2013-11-27T17:24:45+00:00

Lukas Slebodnik
lslebodn@redhat.com

2013-11-09T11:31:06+00:00

a117f51165005d880af58d017e6e7e1881b54ddd












SYSDB: Drop the sysdb_ctx parameter from the sysdb_search module
2013-11-15T19:20:18+00:00

Michal Zidek
mzidek@redhat.com

2013-10-08T13:13:58+00:00

b3292840ebaa747a9fd596ff47cc5d18198361d0