sssd.git/src/providers, branch dpstr

DP: Reduce code duplication

2015-11-11T12:35:49+00:00

The handling of sbus requests in Data Provider was extremely duplicated,
resulting in copy-paste errors. This patch adds several helpers that
reduce code duplication.

DP: Check callback messages for valid UTF-8

2015-11-11T11:29:16+00:00

https://fedorahosted.org/sssd/ticket/2861

Messages passed from Data Provider to responder must be valid UTF-8
strings. Because providers might not be completely under our control,
we need to check if the messages we receive are valid UTF-8 and if they
are not, use a fallback.

DP: Drop dp_pam_err_to_string

2015-11-11T11:29:16+00:00

Resolves:
    https://fedorahosted.org/sssd/ticket/2861

All back end requests were using pam_strerror() to print additional info
about why request failed. Since pam_strerror() returns localized message
and we don't know the locale beforehand, this message failed to be
transferred through D-Bus, resulting in a crash.

DP_PTASK: Fix warning may be used uninitialized

2015-11-11T11:01:19+00:00

It could be unitialized only in case if we add new enum be_ptask_schedule
Currently, we have only BE_PTASK_SCHEDULE_FROM_NOW and
BE_PTASK_SCHEDULE_FROM_LAST which are properly covered in switch case.

src/providers/dp_ptask.c:200: warning: ‘tv’ may be used uninitialized in this function

Reviewed-by: Pavel Březina

AD: Remove unused memory context from ad_user_conn_list

2015-11-11T07:35:58+00:00

Reviewed-by: Petr Cech

BE: Add IFP to known clients

2015-11-10T14:51:40+00:00

This gets rid of confusing debug message:
[be_client_destructor] (0x0020): Unknown client removed ...

Reviewed-by: Lukáš Slebodník

FAIL_OVER: Fix warning value computed is not used

2015-11-10T14:30:46+00:00

src/providers/fail_over.c: In function ‘fo_ref_server’:
src/providers/fail_over.c:861: warning: value computed is not used

Reviewed-by: Jakub Hrozek

KRB5_CHILD: More restrictive umask

2015-11-05T15:07:51+00:00

We could use more restrictive umask in krb5_child. I found out that
there is directory creation, but it is done by create_ccache_dir()
which has its own umask setup.

Resolves:
https://fedorahosted.org/sssd/ticket/2424

Reviewed-by: Jakub Hrozek

DP: successful authentication sets explicitly PAM_SUCCESSS

2015-11-03T08:29:09+00:00

Set PAM_SYSTEM_ERR as default pam_status to ensure that we always must
set PAM_SUCCESSS explicitly for a successful authentication and will
really return an error in all other cases.

Reviewed-by: Pavel Reichl

sudo: remove unused param name in sdap_sudo_get_usn()

2015-11-02T15:01:04+00:00

Reviewed-by: Petr Cech