From 1bcc0d697dd37a9268641f0cbaa7e9e781552233 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Thu, 7 May 2015 12:33:40 -0400 Subject: pylint 1.4.3 version fixes Pylint 1.4.3 completely stopped recognizing the star-args condition. In order to avoid pylint error with > 1.4.3 stop caring for star-args and add cmdline option to ignore those errors completly so older pylint versions are happy too. Also fix type() vs isinstance() checks, isinstance is generally a more correct approach to check for classes. In some 'admin' files the type() -> isinstance() fix required to invert the order in which ComplexList and MappingList are checked as the latter is a subclass of ComplexList, so it needs to be checked first otherwise the check for isinstance(option, ComplexList) matches for both and the code stops functioning properly. Signed-off-by: Simo Sorce Reviewed-by: Rob Crittenden --- tests/helpers/http.py | 1 - 1 file changed, 1 deletion(-) (limited to 'tests') diff --git a/tests/helpers/http.py b/tests/helpers/http.py index 97098c8..bfa3240 100755 --- a/tests/helpers/http.py +++ b/tests/helpers/http.py @@ -265,7 +265,6 @@ class HttpSessions(object): args = {} while True: - # pylint: disable=star-args r = self.access(action, url, krb=krb, **args) if r.status_code == 303 or r.status_code == 302: if not follow_redirect: -- cgit