ipsilon.git/ipsilon/login, branch ecp

Validate options of the LDAP auth plugin on installation

2015-08-27T00:22:15+00:00

Few of the LDAP options had any validation at all so it was
easy to provide a bad DN template, basedn and server URL.

These types of errors are now sufficient to kill the installer
rather than letting it limp along and hope the user notices the
failures in the output.

https://fedorahosted.org/ipsilon/ticket/40

Signed-off-by: Rob Crittenden 
Reviewed-by: Patrick Uiterwijk

Report to user if an LDAP error occurs

2015-08-18T18:50:43+00:00

Catch LDAP errors and display them properly rather than
just dumping the exception.

Rename variable authed to authok.

Add test for case where LDAP server is not started to
confirm the user receives the error alert.

https://fedorahosted.org/ipsilon/ticket/55

Signed-off-by: Rob Crittenden 
Reviewed-by: Patrick Uiterwijk

Mark the service as readonly in the UI in authpam plugin

2015-08-18T07:52:25+00:00

Update the Option class to take a readonly keyword argument,
defaulting to False. Extend its subclasses to pass this value
along.

The page template will add the disabled keyword to input and
textarea if a config option is marked as readonly.

https://fedorahosted.org/ipsilon/ticket/6

Signed-off-by: Rob Crittenden 
Reviewed-by: Patrick Uiterwijk

Use full path when constructing "Other authentication methods"

2015-08-11T10:10:50+00:00

It was previously providing just a relative path and if the paths
overlapped I guess the browser was trying to smash them together.

This would result in a double "gssapi" in the gssapi URL like:

https://my.ipsilon.org/idp/login/gssapi/gssapi/negotiate?ips...

Don't rely on the browser to get the path right, use self.basepath.

https://fedorahosted.org/ipsilon/ticket/153

Signed-off-by: Rob Crittenden 
Reviewed-by: Simo Sorce

Return PAM errors from mod_intercept_form_submit

2015-07-15T14:39:20+00:00

This fixes several problems:

1. The PAM error was being retrieved from the wrong location
2. The error was not always logged properly
3. The error was not propogated up
4. Even if the error had been propgated up the auth_failed
   routine failed to pass it to the error page template.

A dictionary is used to translate the PAM errors into something
more consulable. This can be used eventually to translate
into other languages.

https://fedorahosted.org/ipsilon/ticket/69

Signed-off-by: Rob Crittenden 
Reviewed-by: Patrick Uiterwijk

Implement change registration

2015-05-08T20:34:02+00:00

This will make it possible for plugins to register what they
have changed during installation, so that they can revert
any changes they made during the uninstallation.

https://fedorahosted.org/ipsilon/ticket/67

Signed-off-by: Patrick Uiterwijk 
Reviewed-by: Rob Crittenden

Update Copyright header point to COPYING file

2015-05-08T15:00:48+00:00

Point to a file containing the license rather than including
it in every single source file. This will make it easier to
manage the license in the future without another humongous
commit.

https://fedorahosted.org/ipsilon/ticket/126

Signed-off-by: Rob Crittenden 
Reviewed-by: Patrick Uiterwijk

Remove extraneous logging arg in authform login plugin

2015-05-08T14:02:36+00:00

If you didn't provide credentials at all at the form by
pressing ENTER then a 500 error would be thrown rather
than an authentication error.

Signed-off-by: Rob Crittenden 
Reviewed-by: Patrick Uiterwijk

pylint 1.4.3 version fixes

2015-05-07T18:44:20+00:00

Pylint 1.4.3 completely stopped recognizing the star-args condition.
In order to avoid pylint error with > 1.4.3 stop caring for star-args
and add cmdline option to ignore those errors completly so older pylint
versions are happy too.

Also fix type() vs isinstance() checks, isinstance is generally a more
correct approach to check for classes.

In some 'admin' files the type() -> isinstance() fix required to invert
the order in which ComplexList and MappingList are checked as the latter
is a subclass of ComplexList, so it needs to be checked first otherwise
the check for isinstance(option, ComplexList) matches for both and the
code stops functioning properly.

Signed-off-by: Simo Sorce 
Reviewed-by: Rob Crittenden

Use python logging in install / log cherrypy at right severity

2015-05-07T14:44:23+00:00

This replaces the print statements in the installer code with
a python logger so we can log all output to the installer log
and a subset of it to stdout in one step without duplication.

The cherrypy.log.error() logs to the "error" log at a severity
of logging.INFO by default. Set an appropriate log level for
these as well.

https://fedorahosted.org/ipsilon/ticket/35

Signed-off-by: Rob Crittenden 
Reviewed-by: Simo Sorce