From d5ab62f761aa744402aac799c894dad15e3fa68a Mon Sep 17 00:00:00 2001 From: artem Date: Fri, 18 Jul 2008 10:56:37 +0000 Subject: - [DEV-137] fixes for oracle (Artem) - [DEV-137] small fixes (Artem) git-svn-id: svn://svn.zabbix.com/trunk@5834 97f52cf1-0a1b-0410-bd0e-c28be96e8082 --- frontends/php/graphs.php | 43 +++++++++++++++++++---------------- frontends/php/include/blocks.inc.php | 2 +- frontends/php/include/defines.inc.php | 6 ++--- frontends/php/include/export.inc.php | 2 -- frontends/php/include/forms.inc.php | 4 ++-- frontends/php/include/import.inc.php | 12 +++++----- frontends/php/report2.php | 23 +++++++++++-------- 7 files changed, 49 insertions(+), 43 deletions(-) (limited to 'frontends/php') diff --git a/frontends/php/graphs.php b/frontends/php/graphs.php index 8ed58124..73147bfd 100644 --- a/frontends/php/graphs.php +++ b/frontends/php/graphs.php @@ -86,8 +86,9 @@ include_once "include/page_header.php"; check_fields($fields); validate_sort_and_sortorder('g.name',ZBX_SORT_UP); - $options = array("allow_all_hosts","with_monitored_items","only_current_node","always_select_first_host"); + $options = array('allow_all_hosts','only_current_node','always_select_first_host');//'with_monitored_items', validate_group_with_host(PERM_READ_WRITE,$options,'web.last.conf.groupid', 'web.last.conf.hostid'); +//SDI($_REQUEST['groupid'].' : '.$_REQUEST['hostid']); ?> ---- if(isset($_REQUEST["clone"]) && isset($_REQUEST["graphid"])){ @@ -108,10 +109,10 @@ include_once "include/page_header.php"; $items = get_request('items', array()); foreach($items as $gitem){ $sql = 'SELECT h.hostid '. - ' FROM hosts h,items i '. - ' WHERE h.hostid=i.hostid '. - ' AND i.itemid='.$gitem['itemid']. - ' AND h.hostid NOT IN ('.$available_hosts.')'; + ' FROM hosts h,items i '. + ' WHERE h.hostid=i.hostid '. + ' AND i.itemid='.$gitem['itemid']. + ' AND '.DBcondition('h.hostid',$available_hosts,true); if(DBfetch(DBselect($sql,1))){ access_deny(); } @@ -201,10 +202,13 @@ include_once "include/page_header.php"; } else{ /* groups */ $hosts_ids = array(); - $db_hosts = DBselect('SELECT distinct h.hostid FROM hosts h, hosts_groups hg'. - ' WHERE h.hostid=hg.hostid AND hg.groupid in ('.implode(',',$_REQUEST['copy_targetid']).')'. - ' AND h.hostid in ('.$available_hosts.")" - ); + + $sql = 'SELECT distinct h.hostid '. + ' FROM hosts h, hosts_groups hg'. + ' WHERE h.hostid=hg.hostid '. + ' AND hg.groupid IN ('.implode(',',$_REQUEST['copy_targetid']).')'. + ' AND '.DBcondition('h.hostid',$available_hosts); + $db_hosts = DBselect($sql); while($db_host = DBfetch($db_hosts)){ array_push($hosts_ids, $db_host['hostid']); } @@ -265,7 +269,7 @@ include_once "include/page_header.php"; } } // -------- - $available_graphs = get_accessible_graphs(PERM_READ_WRITE); + $available_graphs = get_accessible_graphs(PERM_READ_WRITE, PERM_RES_IDS_ARRAY); ?> AddItem(0,S_ALL_SMALL); $sql='SELECT DISTINCT h.hostid,h.host '. ' FROM hosts h '. - ' WHERE h.hostid IN ('.$available_hosts.') '. + ' WHERE '.DBcondition('h.hostid',$available_hosts). + ' AND h.status IN ('.HOST_STATUS_MONITORED.','.HOST_STATUS_TEMPLATE.') '. ' ORDER BY h.host'; } @@ -364,7 +369,7 @@ include_once "include/page_header.php"; if($_REQUEST["hostid"] > 0){ $result = DBselect('SELECT DISTINCT g.* '. ' FROM graphs g, graphs_items gi,items i '. - ' WHERE g.graphid IN ('.$available_graphs.') '. + ' WHERE '.DBcondition('g.graphid',$available_graphs). ' AND gi.graphid=g.graphid '. ' AND i.itemid=gi.itemid '. ' AND i.hostid='.$_REQUEST['hostid']. @@ -373,7 +378,7 @@ include_once "include/page_header.php"; else{ $result = DBselect('SELECT DISTINCT g.* '. ' FROM graphs g '. - ' WHERE g.graphid IN ('.$available_graphs.') '. + ' WHERE '.DBcondition('g.graphid',$available_graphs). order_by('g.name,g.width,g.height,g.graphtype','g.graphid')); } diff --git a/frontends/php/include/blocks.inc.php b/frontends/php/include/blocks.inc.php index 5652feb8..e1dc3bd7 100644 --- a/frontends/php/include/blocks.inc.php +++ b/frontends/php/include/blocks.inc.php @@ -979,7 +979,7 @@ function add_refresh_objects($ref_tab){ } function get_refresh_obj_script($obj){ - $obj['url'] = (isset($obj['url']))?$obj['url']:'dashboard.php?output=html'; + $obj['url'] = (isset($obj['url']))?$obj['url']:'?output=html'; return 'updater.setObj4Update("'.$obj['id'].'",'.$obj['interval'].',"'.$obj['url'].'",{"favobj": "refresh", "favid": "'.$obj['id'].'"});'; } diff --git a/frontends/php/include/defines.inc.php b/frontends/php/include/defines.inc.php index 7176620a..5f795e3c 100644 --- a/frontends/php/include/defines.inc.php +++ b/frontends/php/include/defines.inc.php @@ -1,7 +1,7 @@ array( 'depends' => '') ), -// based on mod by scricca XML_TAG_HOSTPROFILE => array( 'attribures' => array(), 'elements' => array( @@ -318,7 +317,6 @@ // based on mod by scricca $data = DBfetch(DBselect('SELECT hp.* FROM hosts_profiles hp WHERE hp.hostid='.$hostid)); -// if(!$data) return false; if($data){ zbx_xmlwriter_start_element ($memory,XML_TAG_HOSTPROFILE); diff --git a/frontends/php/include/forms.inc.php b/frontends/php/include/forms.inc.php index 51160467..3be5b593 100644 --- a/frontends/php/include/forms.inc.php +++ b/frontends/php/include/forms.inc.php @@ -2060,7 +2060,7 @@ $target_list = array(); while($target = DBfetch($db_targets)){ array_push($target_list,array( - new CCheckBox('copy_targetid[]', + new CCheckBox('copy_targetid['.$target['target_id'].']', uint_in_array($target['target_id'], $copy_targetid), null, $target['target_id']), @@ -4707,7 +4707,7 @@ $frmHostT->AddVar("hostid",$_REQUEST["hostid"]); } - $frmHostT->AddRow(S_TEMPLATE,new CTextBox("tname",$name,60)); + $frmHostT->AddRow(S_TEMPLATE,new CTextBox("tname",$name,60,'yes')); $hosts_in_tpl = array(); $sql = 'SELECT DISTINCT h.hostid,h.host '. diff --git a/frontends/php/include/import.inc.php b/frontends/php/include/import.inc.php index 41bf60ba..6df83045 100644 --- a/frontends/php/include/import.inc.php +++ b/frontends/php/include/import.inc.php @@ -575,12 +575,12 @@ } } else{ - if($graph = DBfetch(DBselect('select distinct g.graphid, g.templateid'. - ' from graphs g, graphs_items gi, items i'. - ' where g.graphid=gi.graphid '. - ' and gi.itemid=i.itemid'. - ' and g.name='.zbx_dbstr($data['name']). - ' and i.hostid='.$this->data[XML_TAG_HOST]['hostid']))) + if($graph = DBfetch(DBselect('SELECT DISTINCT g.graphid, g.templateid'. + ' FROM graphs g, graphs_items gi, items i'. + ' WHERE g.graphid=gi.graphid '. + ' AND gi.itemid=i.itemid'. + ' AND g.name='.zbx_dbstr($data['name']). + ' AND i.hostid='.$this->data[XML_TAG_HOST]['hostid']))) { /* exist */ if($this->graph['exist']==1){ /* skip */ info('Graph ['.$data['name'].'] skipped - user rule'); diff --git a/frontends/php/report2.php b/frontends/php/report2.php index 0853cd3c..f1c58b1f 100644 --- a/frontends/php/report2.php +++ b/frontends/php/report2.php @@ -138,6 +138,19 @@ include_once 'include/page_header.php'; $table->Show(); } else if(isset($_REQUEST['hostid'])){ + +/* + if($_REQUEST['hostid'] > 0){ + $row = DBfetch(DBselect('SELECT host FROM hosts WHERE hostid='.$_REQUEST['hostid'])); + show_table_header($row['host']); + } + else{ + if(isset($_REQUEST['tpl_triggerid']) && ($_REQUEST['tpl_triggerid'] > 0)) + show_table_header(expand_trigger_description($_REQUEST['tpl_triggerid'])); + else + show_table_header(S_ALL_HOSTS_BIG); + } +//*/ /************************* FILTER *************************/ /***********************************************************/ $filterForm = new CFormTable(S_FILTER);//,'events.php?filter_set=1','POST',null,'sform'); @@ -226,16 +239,6 @@ include_once 'include/page_header.php'; $sql_cond.= ' AND t.templateid='.$_REQUEST['tpl_triggerid']; } - if($_REQUEST['hostid'] > 0){ - $row = DBfetch(DBselect('SELECT host FROM hosts WHERE hostid='.$_REQUEST['hostid'])); - show_table_header($row['host']); - } - else{ - if(isset($_REQUEST['tpl_triggerid']) && ($_REQUEST['tpl_triggerid'] > 0)) - show_table_header(expand_trigger_description($_REQUEST['tpl_triggerid'])); - else - show_table_header(S_ALL_HOSTS_BIG); - } $result = DBselect('SELECT DISTINCT h.hostid,h.host,t.triggerid,t.expression,t.description,t.value '. ' FROM triggers t,hosts h,items i,functions f, hosts_templates ht, groups g, hosts_groups hg '. ' WHERE f.itemid=i.itemid '. -- cgit