From 469d17e7d448ec1833abb72add88d1d1f61c4a06 Mon Sep 17 00:00:00 2001 From: artem Date: Wed, 20 Aug 2008 14:46:11 +0000 Subject: - [DEV-199] performance improvements of js scripts in hosts screen (Artem) - [DEV-137] many small fixes (Artem) git-svn-id: svn://svn.zabbix.com/trunk@5932 97f52cf1-0a1b-0410-bd0e-c28be96e8082 --- frontends/php/popup.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'frontends/php/popup.php') diff --git a/frontends/php/popup.php b/frontends/php/popup.php index 1df0f8a1..4932714b 100644 --- a/frontends/php/popup.php +++ b/frontends/php/popup.php @@ -524,10 +524,11 @@ include_once "include/page_header.php"; $table = new CTableInfo(S_NO_GROUPS_DEFINED); $table->SetHeader(array(S_NAME)); - $db_groups = DBselect("SELECT DISTINCT groupid,name from groups ". - ' where '.DBin_node('groupid', $nodeid). - " AND groupid in (".$available_groups.") ". - " order by name"); + $db_groups = DBselect('SELECT DISTINCT groupid,name '. + ' FROM groups '. + ' WHERE '.DBin_node('groupid', $nodeid). + ' AND '.DBcondition('groupid',$available_groups). + ' ORDER BY name'); while($row = DBfetch($db_groups)){ $name = new CLink($row["name"],"#","action"); if(isset($_REQUEST['reference']) && ($_REQUEST['reference'] =='dashboard')){ @@ -1273,7 +1274,7 @@ include_once "include/page_header.php"; $db_groups = DBselect('SELECT DISTINCT n.name as node_name,g.groupid,g.name,n.nodeid '. ' FROM hosts_groups hg, groups g '. ' LEFT JOIN nodes n ON n.nodeid='.DBid2nodeid('g.groupid'). - ' WHERE g.groupid IN ('.$available_groups.') '. + ' WHERE '.DBcondition('g.groupid',$available_groups). ' AND '.DBin_node('g.groupid',$nodeid). ' ORDER BY n.nodeid,g.name'); -- cgit