From 08a84749d9c92829d580c508f3b0256f7b188321 Mon Sep 17 00:00:00 2001 From: David Troy Date: Tue, 4 Apr 2006 22:33:15 +0000 Subject: git-svn-id: http://svncommunity.digium.com/svn/astmanproxy/branches/1.20pre@83 f02b47b9-160a-0410-81a6-dc3441afb0ec --- TODO | 1 + src/astmanproxy.c | 5 +---- src/config.c | 1 - src/proxyfunc.c | 4 ---- 4 files changed, 2 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 65a0a27..bb0f233 100644 --- a/TODO +++ b/TODO @@ -1,4 +1,5 @@ fix non-blocking in ast_connect +kill autodisconnect concept; this would be managed by inputcomplete/outputcomplete in drivers? 'connected' flag; do not set until we get "authentication accepted' back from server Check for module versions; do not run without modules installed diff --git a/src/astmanproxy.c b/src/astmanproxy.c index 9481610..dbbb05c 100644 --- a/src/astmanproxy.c +++ b/src/astmanproxy.c @@ -344,8 +344,6 @@ void *HandleAsterisk(struct mansession *s) if (!WriteClients(&m)) break; - /* TODO: does it make any sense to abort * conn if we cannot write to clients? I don't think so. - Do we even get a return code back that means anything? I don't think so. */ } else if (res < 0) { if (debug) debugmsg("asterisk@%s: Not connected", ast_inet_ntoa(iabuf, sizeof(iabuf), s->sin.sin_addr)); @@ -490,14 +488,13 @@ int SetIOHandlers(struct mansession *s, char *ifmt, char *ofmt) io = io->next; } + /* set default handlers if non match was found */ if (!s->output) { - /* TODO: Output debug that default/first handler was used */ s->output = iohandlers; res = 1; } if (!s->input) { - /* TODO: Output debug that default/first handler was used */ s->input = iohandlers; res = 1; } diff --git a/src/config.c b/src/config.c index bc1d2cb..b7bbdc7 100644 --- a/src/config.c +++ b/src/config.c @@ -61,7 +61,6 @@ void *add_server(char *srvspec) { pc.serverlist = srv; return 0; - /* TODO: make sure server credentials are freed at leave */ } void *processline(char *s) { diff --git a/src/proxyfunc.c b/src/proxyfunc.c index 54df298..d1d5f38 100644 --- a/src/proxyfunc.c +++ b/src/proxyfunc.c @@ -54,7 +54,6 @@ void *ProxySetOutputFormat(struct mansession *s, struct message *m) { value = astman_get_header(m, "OutputFormat"); SetIOHandlers(s, s->input->formatname, value); - /* TODO: this is retarded */ memset(&mo, 0, sizeof(struct message)); AddHeader(&mo, "ProxyResponse: Success"); @@ -206,10 +205,7 @@ int ProxyAddServer(struct mansession *s, struct message *m) { fprintf(stderr, "Failed to allocate server credentials: %s\n", strerror(errno)); exit(1); } - memset(srv, 0, sizeof (struct ast_server) ); - - /* TODO: Disallow adding of duplicate servers? Or not, I suppose that could be useful (events on/off) */ memset(srv, 0, sizeof(struct ast_server) ); memset(&mo, 0, sizeof(struct message)); strcpy(srv->ast_host, astman_get_header(m, "Server")); -- cgit