summaryrefslogtreecommitdiffstats
path: root/drivers/target/target_core_pscsi.c
diff options
context:
space:
mode:
authorJörn Engel <joern@logfs.org>2012-02-16 11:14:27 -0500
committerNicholas Bellinger <nab@linux-iscsi.org>2012-02-25 14:37:50 -0800
commit99f730d88fd0a25c3e2dfc357bde4cf6b8cb5b40 (patch)
tree94b74e3bbceda90501e550543dfc82f0bde13917 /drivers/target/target_core_pscsi.c
parent47f1b8803e1e358ebbf4f82bfdb98971c912a2c3 (diff)
downloadlinux-99f730d88fd0a25c3e2dfc357bde4cf6b8cb5b40.tar.gz
linux-99f730d88fd0a25c3e2dfc357bde4cf6b8cb5b40.tar.xz
linux-99f730d88fd0a25c3e2dfc357bde4cf6b8cb5b40.zip
target: Fix off-by-seven in target_report_luns
cdb_offset is always equal to offset - 8, so remove that one. More importantly, the existing code only worked correct if se_cmd->data_length is a multiple of 8. Pass in a length of, say, 9 and we will happily overwrite 7 bytes of "unallocated" memory. Now, afaics this bug is currently harmless, as allocations will implicitly be padded to multiples of 8 bytes. But depending on such a fact wouldn't qualify as sound engineering practice. Signed-off-by: Joern Engel <joern@logfs.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_pscsi.c')
0 files changed, 0 insertions, 0 deletions