diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-04-13 22:27:18 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@qca.qualcomm.com> | 2012-04-16 09:32:04 +0300 |
| commit | ebc6a5332f69c3ce2b071015817fb1cb149217c1 (patch) | |
| tree | 65b7f2284b8786809298e3bb6a2a858d8607ba27 /drivers/net/wireless/ath/ath6kl/htc_pipe.c | |
| parent | 2023dbb8310ab39ac1119a32ef52405f7a73f51f (diff) | |
| download | linux-ebc6a5332f69c3ce2b071015817fb1cb149217c1.tar.gz linux-ebc6a5332f69c3ce2b071015817fb1cb149217c1.tar.xz linux-ebc6a5332f69c3ce2b071015817fb1cb149217c1.zip | |
ath6kl: list_first_entry() is never NULL
We can remove the NULL check here. It triggers a Smatch warning because
list_first_entry() never is NULL and people who check for it normally
intend to check for list_empty() instead. In these cases however,
we've already verified that the lists are not empty.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Diffstat (limited to 'drivers/net/wireless/ath/ath6kl/htc_pipe.c')
| -rw-r--r-- | drivers/net/wireless/ath/ath6kl/htc_pipe.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/ath/ath6kl/htc_pipe.c index b277b3446882..b21a69fb7f0f 100644 --- a/drivers/net/wireless/ath/ath6kl/htc_pipe.c +++ b/drivers/net/wireless/ath/ath6kl/htc_pipe.c @@ -108,8 +108,6 @@ static void get_htc_packet_credit_based(struct htc_target *target, /* get packet at head, but don't remove it */ packet = list_first_entry(&ep->txq, struct htc_packet, list); - if (packet == NULL) - break; ath6kl_dbg(ATH6KL_DBG_HTC, "%s: got head packet:0x%p , queue depth: %d\n", @@ -803,8 +801,6 @@ static int htc_send_packets_multiple(struct htc_target *target, /* get first packet to find out which ep the packets will go into */ packet = list_first_entry(pkt_queue, struct htc_packet, list); - if (packet == NULL) - return -EINVAL; if (packet->endpoint >= ENDPOINT_MAX) { WARN_ON_ONCE(1); @@ -1636,10 +1632,6 @@ static int ath6kl_htc_pipe_add_rxbuf_multiple(struct htc_target *target, return -EINVAL; first = list_first_entry(pkt_queue, struct htc_packet, list); - if (first == NULL) { - WARN_ON_ONCE(1); - return -EINVAL; - } if (first->endpoint >= ENDPOINT_MAX) { WARN_ON_ONCE(1); |