nfs-utils.git/utils/mountd, branch master-gss_acquire_cred

mountd: fix is_subdirectory to understand '/'

2012-12-17T21:33:17+00:00

The is_subdirectory() function checks if a given 'child' is a
subdirectory of the given 'parent'.  However it always fails
if 'parent' == "/" (because 'child' doesn't begin with 'parent'
followed by "/").

So change is_subdirectory() to special-case "/".

subexport() also tests if one directory is a subdirectory of the
other, and contains the same bug.  So change it to use
is_subdirectory().

Finally, move is_subdirectory() and related path_matches() and
export_matches() earlier in the file to avoid a forward-reference.

This patch fixes a bug wherein if you export "/" with 'crossmnt', the
crossmnt flag is ineffective and you can only access the root
filesystem, not any descendants.

Acked-by: J. Bruce Fields 
Signed-off-by: NeilBrown 
Signed-off-by: Steve Dickson

mountd: Report the absolute path used to load the junction plug-in

2012-12-12T15:32:29+00:00

As a debugging feature, report the absolute pathname of the plug-in
library that mountd loads to resolve junctions.

Since mountd passes a relative path to dlopen(3), dlopen(3) must
search for the right library.  Displaying the absolute pathname of
the object that it found verifies that mountd loaded the correct
plug-in.

Note: dlinfo(3) is provided by libdl, but there doesn't seem to be a
man page on Fedora 16 for dlinfo(3).  Instead, see:

  http://www.unix.com/man-page/all/3/dlinfo/

Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mountd: cache.c no longer needs #include xmalloc.h

2012-12-12T15:32:28+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mountd: auth.c no longer needs #include xmalloc.h

2012-12-12T15:32:28+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mountd: auth_unix_ip should downcall on error to prevent hangs

2012-11-28T14:33:08+00:00

Since bf6a4febaa78bf188896b7b5b02c46562dd08b70 "mountd: handle
allocation failures in auth_unix_ip upcall", a failure to map the
address of an incoming client to a name could result in a hang.

We should be responding with an error in the case, not just skipping the
downcall and leaving everybody hanging.

Signed-off-by: J. Bruce Fields 
Signed-off-by: Steve Dickson

mountd: Avoid unnecessary type conversions

2012-10-30T19:30:08+00:00

Fixed a number of -Wconversion warnings

Signed-off-by: Steve Dickson

mountd: Avoid unnecessary type conversions

2012-10-30T19:30:08+00:00

Removed a Wsign-conversion warning

Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mountd: Avoid unnecessary type conversions

2012-10-30T19:30:08+00:00

Clean up compiler warnings:

cache.c: In function get_uuid:
cache.c:249:2: warning: conversion to size_t from int may change
  the sign of the result [-Wsign-conversion]

  And the like.

signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mountd: Make local functions static

2012-10-30T19:30:08+00:00

Removed a couple Wmissing-prototypes warnings in the mountd code.

Once the parse_fsid() function was made static, the compiler
detected execution paths through it that did not initialize some
fields in *parsed.

[ I'm pretty sure these problems are currently harmless, since each
path is taken depending on the value of the .fsidtype field.  Each
path accesses only the fields in *parsed that it cares about. ]

This is because parsed_fsid isn't a union type.  parse_fsid() leaves
uninitialized fields that are not used by a particular fsidtype.  To
prevent an accidental dereference of stack garbage (.fhuuid being an
example of a pointer that is left uninitialized sometimes), have
parse_fsid() defensively pre-initialize *parsed to zero.

Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mountd: Eliminate unnecessary type conversions

2012-10-30T19:30:08+00:00

Removed a copule Wsign-conversion in the mountd code.

Signed-off-by: Steve Dickson