summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Removed unnecessary code that was resetting options whenever theAlexandra Ellwood2008-10-292-18/+0
| | | | | | | | | | | | array changes in the background. The problem is that any external change to the ticket list will cause this to happen, even when the options dialog is open. Also removed unused function resetOptions. ticket: 6224 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20938 dc483132-0cff-0310-8789-dd5450dbe970
* Only prompt automatically from GUI appsAlexandra Ellwood2008-10-295-21/+58
| | | | | | | | | | Direct callers such as kinit need command line prompts. Do not automatically prompt (via krb5 or gssapi calls) unless the caller has loaded GUI libraries. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20937 dc483132-0cff-0310-8789-dd5450dbe970
* Remove saved password if it fails to get ticketsAlexandra Ellwood2008-10-291-0/+10
| | | | | | | | | | | Note that if preauth is turned on the password may be removed for other reasons. This is because preauth failing can mean several things. Better to always remove it than have the user sometimes get stuck though. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20936 dc483132-0cff-0310-8789-dd5450dbe970
* KerberosAgent hangs changing pw for passwordless identitiesJustin Anderson2008-10-293-0/+11
| | | | | | | | Trying to change the password for an identity which only uses non-password authentication methods left KerberosAgent with a spinning progress indicator. Problem was with auth sheet not being ended. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20935 dc483132-0cff-0310-8789-dd5450dbe970
* Cleanup memory leaks in test program for dynamically allocated buffers..Ezra Peisach2008-10-281-0/+3
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20934 dc483132-0cff-0310-8789-dd5450dbe970
* Update the exports file for krb5int_buf_add_fmtGreg Hudson2008-10-281-0/+1
| | | | | | | ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20933 dc483132-0cff-0310-8789-dd5450dbe970
* In the k5buf module, add a function to append formatted data to aGreg Hudson2008-10-283-3/+122
| | | | | | | | | buffer. ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20932 dc483132-0cff-0310-8789-dd5450dbe970
* The last change to plugins.c erroneously passes a size_t as a fieldGreg Hudson2008-10-281-1/+1
| | | | | | | width to asprintf. Address the signed/unsigned warning cleanup using a cast instead. git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20931 dc483132-0cff-0310-8789-dd5450dbe970
* Eliminate use of strcpy/strcat/sprintf in wconfig.c. Use memcpy sinceGreg Hudson2008-10-281-20/+33
| | | | | | | | | | we cannot rely on libkrb5support to give us the good stuff. Also fix up (to some extent) an assumption that size_t == int. ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20930 dc483132-0cff-0310-8789-dd5450dbe970
* Add the k5buf string module to libkrb5supportGreg Hudson2008-10-287-1/+585
| | | | | | | ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20929 dc483132-0cff-0310-8789-dd5450dbe970
* Unsigned/signed warnings cleanupEzra Peisach2008-10-282-8/+10
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20928 dc483132-0cff-0310-8789-dd5450dbe970
* localize format strings, not final error stringAlexandra Ellwood2008-10-271-76/+34
| | | | | | | | | | | | | | | errors.c should localize the incoming format string, not the string produced by vasprintf. The format string is constant and thus can be added to a localization table, whereas the output string is not. Note that this change depends on error_message also localizing error table strings (which it does for KfM already). ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20927 dc483132-0cff-0310-8789-dd5450dbe970
* Remove empty declaration of struct _krb5_kt_ops after the fully defined ↵Ezra Peisach2008-10-271-1/+0
| | | | | | structure git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20926 dc483132-0cff-0310-8789-dd5450dbe970
* signed vs. unsigned warnings cleanupEzra Peisach2008-10-271-7/+7
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20925 dc483132-0cff-0310-8789-dd5450dbe970
* Remove kproplog on make cleanEzra Peisach2008-10-271-2/+2
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20924 dc483132-0cff-0310-8789-dd5450dbe970
* partial rewrite of the ASN.1 encodersKen Raeburn2008-10-2519-2225/+2579
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of a pile of macros generating code, that have to be threaded together in just the right way to get a valid ASN.1 encoding, we now have a pile of macros for defining data structures describing the objects and the ASN.1 types they should be encoded as, which structures are interpreted by recursive invocations of an encoder engine; there should be somewhat less rope for accidentally creating invalid encodings. The new macros are commented in asn1_k_encode.c. Putting most of the work into the encoder engine also reduces the code size (in one configuration, including LDAP-KDB and PKINIT encoders, code size went from 37K to <16K, though 10K of tables were added, and the PKINIT encoders are still open-coded). Some encoder interfaces have been revised to be more regular -- all now take one pointer to const argument (no two-input encoders, no pointer-to-non-const-pointer-to-const). A few encoders were eliminated or disabled because they were neither used nor exported from the library. The LDAP-KDB encoder has been converted, but the PKINIT encoders have not as there are no regression tests for them currently. There is still plenty of room for improvement; some notes on specific ideas have been added. String encoding primitives have been combined to reduce code size. A primitive for encoding bit strings has been added. Some miscellaneous warnings in the decoders have been cleaned up. A new dejagnu test case is added that ensures that KRB-SAFE messages get exercised. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20923 dc483132-0cff-0310-8789-dd5450dbe970
* More regression tests for ASN.1 encodersKen Raeburn2008-10-257-2/+182
| | | | | | | | | Export encode_krb5_sam_response_2 and encode_krb5_enc_sam_response_enc_2 via accessor. Add encode tests for encode_krb5_sam_key, _enc_sam_response_enc, _predicted_sam_response, _sam_response_2, _enc_sam_response_enc_2. git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20922 dc483132-0cff-0310-8789-dd5450dbe970
* krb5_build_principal_ext walks off beginning of arrayAlexandra Ellwood2008-10-241-1/+1
| | | | | | | | | | | On error, krb5_build_principal_ext walks off the beginning of the array by using i-- in a conditional when it should be using --i (so that it actually compares the value of i that will be used below). ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20920 dc483132-0cff-0310-8789-dd5450dbe970
* Use strlcpy instead of strcpy in many placesGreg Hudson2008-10-2439-118/+132
| | | | | | | ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20919 dc483132-0cff-0310-8789-dd5450dbe970
* krb5_build_principal_va does not allocate krb5_principalAlexandra Ellwood2008-10-245-117/+166
| | | | | | | | | | | | | | | | | krb5_build_principal_va does not allocate the outer krb5_principal, making it useless for generating krb5_principals which can be freed with krb5_free_principal. Added krb5_build_principal_alloc_va which allocates the krb5_principal. Added krb5int_build_principal_alloc_va which is used by KIM to avoid code duplication. KIM's kim_identity_create_from_components takes the first component as an argument because principals with no components cannot be represented with the KIM UI. Modified KIM to use this new API. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20918 dc483132-0cff-0310-8789-dd5450dbe970
* Add test for kim_identity_create_from_componentsAlexandra Ellwood2008-10-243-0/+54
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20917 dc483132-0cff-0310-8789-dd5450dbe970
* Add build system support for strlcpy and strlcat on platforms which doGreg Hudson2008-10-244-0/+114
| | | | | | | | | not provide it natively. ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20916 dc483132-0cff-0310-8789-dd5450dbe970
* Use CFStringGetCStringPtr if possible to avoid wasting memoryAlexandra Ellwood2008-10-241-12/+25
| | | | | | | | since CFStringGetMaximumSizeForEncoding is wasteful for UTF8. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20914 dc483132-0cff-0310-8789-dd5450dbe970
* Add support for localizing krb5 errors on Mac OS X.Alexandra Ellwood2008-10-241-2/+67
| | | | | | | | | Split into a separate function to make it easier to add support for other localization techniques. ticket: 6245 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20913 dc483132-0cff-0310-8789-dd5450dbe970
* Use snprintf instead of strcpy/strcat in many placesGreg Hudson2008-10-2315-108/+80
| | | | | | | ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20912 dc483132-0cff-0310-8789-dd5450dbe970
* Free global mach ports on library unloadAlexandra Ellwood2008-10-231-2/+19
| | | | | | ticket: 6248 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20911 dc483132-0cff-0310-8789-dd5450dbe970
* Fix previous commit by adding "extern" to header declarations forTom Yu2008-10-221-2/+2
| | | | | | | | | | SPNEGO mechanism OID stuff. It was causing tentative definition issues on the Mac. (where there are constraints about common-block symbols) ticket: 6015 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20910 dc483132-0cff-0310-8789-dd5450dbe970
* KIM should only display error dialogs if it has displayed UI alreadyAlexandra Ellwood2008-10-221-21/+11
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20909 dc483132-0cff-0310-8789-dd5450dbe970
* Remove ipc message sent on cc_context_releaseAlexandra Ellwood2008-10-224-34/+17
| | | | | | | | | IPC message was causing problems when called from thread fini function (via krb5_stdcc_shutdown). ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20908 dc483132-0cff-0310-8789-dd5450dbe970
* kim_identity_change_password_with_credential leaks krb5_credsAlexandra Ellwood2008-10-211-0/+3
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20907 dc483132-0cff-0310-8789-dd5450dbe970
* kim_os_library_get_caller_name leaks file pathAlexandra Ellwood2008-10-211-0/+1
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20906 dc483132-0cff-0310-8789-dd5450dbe970
* kim_ccache_iterator_next leaks principalAlexandra Ellwood2008-10-211-0/+3
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20905 dc483132-0cff-0310-8789-dd5450dbe970
* kim_preferences should free old identity before overwritingAlexandra Ellwood2008-10-211-1/+9
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20904 dc483132-0cff-0310-8789-dd5450dbe970
* Free data in tests so leaks checking is easierAlexandra Ellwood2008-10-212-3/+21
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20903 dc483132-0cff-0310-8789-dd5450dbe970
* krb5_change_set_password should free chpw_rep contentsAlexandra Ellwood2008-10-211-0/+2
| | | | | | ticket: 6214 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20902 dc483132-0cff-0310-8789-dd5450dbe970
* Use asprintf instead of malloc/strcpy/strcat in many placesGreg Hudson2008-10-2018-168/+53
| | | | | | | ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20901 dc483132-0cff-0310-8789-dd5450dbe970
* Apply adapted patch from http://bugs.debian.org/480434 to recurse intoTom Yu2008-10-201-0/+13
| | | | | | | | SPNEGO creds when attempting to retrieve a mechanism cred. ticket: 5807 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20900 dc483132-0cff-0310-8789-dd5450dbe970
* Apply (adapted) patch from Apple to check for SPNEGO mechanism inTom Yu2008-10-203-19/+48
| | | | | | | | export_lucid_sec_ctx. ticket: 6015 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20899 dc483132-0cff-0310-8789-dd5450dbe970
* Use strdup in place of malloc/strcpy in many placesGreg Hudson2008-10-2050-165/+70
| | | | | | | ticket: 6200 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20898 dc483132-0cff-0310-8789-dd5450dbe970
* Include k5-platform.h for SIZE_MAXEzra Peisach2008-10-191-0/+1
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20897 dc483132-0cff-0310-8789-dd5450dbe970
* In krb5_def_store_mkey(), mktemp was being invoked with a string WRFILE:....Ezra Peisach2008-10-191-9/+8
| | | | | | | | | | | | | | This returns an error - as it actually tries to open the file. Move some of the logic that points to the actual filename earlier - so mktemp works on the .... portion. Note that the netbsd linker gives a warning on using mktemp as it may be insecure - but there is no obvious way to avoid it. ticket: new subhect: netbsd mktemp actually tries to open file git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20896 dc483132-0cff-0310-8789-dd5450dbe970
* Make all dialogs beyond the change password sheet also appear as sheetsJustin Anderson2008-10-174-89/+147
| | | | | | ticket:6145 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20894 dc483132-0cff-0310-8789-dd5450dbe970
* Adapted patch from Apple to work around SAMBA mech OID quirks and toTom Yu2008-10-171-39/+37
| | | | | | | | disable sending request flags. ticket: 6016 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20893 dc483132-0cff-0310-8789-dd5450dbe970
* Stop using -[NSWindow setIgnoresMouseEvents:] and manage enabled state of ↵Justin Anderson2008-10-173-16/+342
| | | | | | | | each control individually with bindings ticket:6198 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20890 dc483132-0cff-0310-8789-dd5450dbe970
* KerberosAgent continues to ignore mouse events after errorJustin Anderson2008-10-171-0/+1
| | | | | | | | Problem when trying to change password from behind a NAT. The ensuing error dialog ignores mouse events, making it impossible to dismiss. ticket:new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20889 dc483132-0cff-0310-8789-dd5450dbe970
* temporary testing codeAlexandra Ellwood2008-10-171-5/+9
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20888 dc483132-0cff-0310-8789-dd5450dbe970
* KLCreatePrincipalFromTriplet should work with empty instanceAlexandra Ellwood2008-10-171-5/+12
| | | | | | | | | Fixed bug where shim layer was calling kim_identity_create_from_components incorrectly in this case. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20887 dc483132-0cff-0310-8789-dd5450dbe970
* Added back KLL test programsAlexandra Ellwood2008-10-172-0/+583
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20886 dc483132-0cff-0310-8789-dd5450dbe970
* Double free and leak in kim_os_library_get_application_pathAlexandra Ellwood2008-10-171-1/+1
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20885 dc483132-0cff-0310-8789-dd5450dbe970
* Remap some of the more confusing krb5 errorsAlexandra Ellwood2008-10-172-23/+56
| | | | | | | | Also enlarged last error buffer for UTF8 strings with multibyte chars. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20884 dc483132-0cff-0310-8789-dd5450dbe970