summaryrefslogtreecommitdiffstats
path: root/src/windows
Commit message (Collapse)AuthorAgeFilesLines
...
* add descriptions of credential flags, identity icons, and push-pinsJeffrey Altman2007-10-0124-173/+221
| | | | | | | | | | | | update screen shots add credits to Fermilabs and Stanford University. other changes for kfw 3.2.2 release. ticket: 5789 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20027 dc483132-0cff-0310-8789-dd5450dbe970
* fix the description of the notification icon status colorsJeffrey Altman2007-10-012-0/+0
| | | | | | ticket: 5789 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20026 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: LIB: deadlock in kmqJeffrey Altman2007-09-303-0/+19
| | | | | | | | | | | | Do not obtain a critical section that is already being held: "cs_kmq_types" Update the docs to indicate the additional restriction. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20025 dc483132-0cff-0310-8789-dd5450dbe970
* When there is no ImagePath value for a module it indicatesJeffrey Altman2007-09-301-1/+5
| | | | | | | | | | | | | that the module has not been installed. Do not report an error to the end user for uninstalled modules. This will only annoy the user and there is probably nothing the user can do about it. Perhaps the user uninstalled the module intentionally. The fact that there is still a HKCU key remaining is not an indication that the module is in use. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20023 dc483132-0cff-0310-8789-dd5450dbe970
* Remove Krb5Cred, Krb5Ident, and Krb4Cred default configuration data fromJeffrey Altman2007-09-302-9/+45
| | | | | | | | | | | | | | | the KMM Schema. Require that modules that are installed be properly installed. Add NIM Module Registry values to the NSIS installer. These values were already being set by the Wix installer. By removing the ImagePath default, unable to load module errors will not be generated when the module has not in fact been installed. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20022 dc483132-0cff-0310-8789-dd5450dbe970
* fix documentation typoJeffrey Altman2007-09-301-1/+1
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20021 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: disable warningJeffrey Altman2007-09-301-1/+4
| | | | | | | | | | Disable the potentially uninitialized variable warning for 'ri'. The variable cannot be used when uninitialized. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20020 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: PDF user documentation updates for KFW 3.2.2Jeffrey Altman2007-09-302-0/+0
| | | | | | | | | updates for NIM 1.3.1 / KFW 3.2.2 ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20019 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Provide keyboard accelerator Jeffrey Altman2007-09-291-1/+1
| | | | | | | | | | In the Advanced mode of the Obtain New Credentials dialog the keyboard accelerator was missing. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20018 dc483132-0cff-0310-8789-dd5450dbe970
* Fix typoJeffrey Altman2007-09-291-0/+0
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20017 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Spell CheckJeffrey Altman2007-09-292-34/+34
| | | | | | | | | Correct typos. Make use of "plug-in" vs "plugin" consistent. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20016 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: FEATURE: APP: Notification Icon Tooltip Jeffrey Altman2007-09-273-34/+66
| | | | | | | | | | | | | | The Network Identity Manager notification icon can have a tooltip associated with it. The tooltip will be displayed to the user if she hovers the mouse cursor over the notification icon. Currently, the tooltip is used to indicate the current status of Network Identity Manager. This patch adds the name of the default identity to the tooltip. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19985 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: LIB: optimize khui_find_action()Jeffrey Altman2007-09-271-7/+9
| | | | | | | | | | | | In Network Identity Manager, when locating the action object corresponding to an action identifier using khui_find_action(), don't search through the list of standard actions if we already know that the object we are searching for is a custom action. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19984 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "Set default" sub menu to the Network Identity ManagerJeffrey Altman2007-09-2712-59/+317
| | | | | | | | | | | | | notification icon context menu. The submenu will display a list of identities that the user can select as the default identity. Each identity that is displayed in the sub menu will be colored the same way it is colored in the basic view to provide a hint as to the state of the credentials belonging to the identity. ticket: 5724 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19983 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "View all identities" option to the view menu of NetworkJeffrey Altman2007-09-279-7/+77
| | | | | | | | | | | | | Identity Manager. This option will be toggled when selected. If enabled, all the known identities will be displayed in any credentials view which uses the identity of credentials as the primary group-by field. The setting of this option is persistent. ticket: 5719 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19982 dc483132-0cff-0310-8789-dd5450dbe970
* Document use of KRB5_CCH_CCNAME for ccache name lengthJeffrey Altman2007-09-251-4/+4
| | | | | | ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19978 dc483132-0cff-0310-8789-dd5450dbe970
* change all MAX_PATH ccname buffer lengths to KRB5_CCH_CCNAME and Jeffrey Altman2007-09-251-8/+8
| | | | | | | | document the use of KRB5_CCH_CCNAME. ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19977 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KMM: miscellaneous fixesJeffrey Altman2007-09-253-13/+17
| | | | | | | | | | | | | | | | | | | kmm_reg.c: Allocate enough memory to hold the entire PluginList multi-string plus an extra NUL if the registry value was not properly terminated. kmm_registrar.c: Do not record an error loading a module if there was no configuration for it. kmmmain.c: Avoid a race condition by sending the thread quit message instead of posting it. Do so outside of the critical section to avoid a deadlock. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19976 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KRB5: cleanup krb5funcsJeffrey Altman2007-09-251-2/+3
| | | | | | | | | | | | | | | | (1) remove an extraneous backslash from the generated FILE: ccache name. GetTempPath() always returns paths terminated with a backslash. (2) increase the max ccache name length to KRB5_CCH_CCNAME from MAX_PATH. These changes have dependencies on revisions 19891 and 19897. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19975 dc483132-0cff-0310-8789-dd5450dbe970
* More consolidation of the computation of the default ccache nameJeffrey Altman2007-09-251-29/+2
| | | | | | ticket: 5691 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19974 dc483132-0cff-0310-8789-dd5450dbe970
* Set svn:eol-style on a bunch of text-looking files that didn't have itKen Raeburn2007-09-24115-11761/+11761
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19972 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: Restore Copyright removed in revision 19855Jeffrey Altman2007-09-241-0/+1
| | | | | | | | | Restore MIT Copyright removed in revision 19855. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19968 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: khm_krb5_initialize() failed to return error codeJeffrey Altman2007-09-241-4/+4
| | | | | | | | | | | | | | | | khm_krb5_initialize() is called in the krb5cred.dll and krb4cred.dll credential providers in order to ensure that the caller has references to a valid krb5_context and a valid krb5_ccache. If the krb5_cc_resolve() call failed, the error code was not being returned to the caller. Instead, success was returned which in turn would result in the caller believing the NULL krb5_ccache pointer was in fact valid. This fix resolves Microsoft's WER Event ID 432405961. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19967 dc483132-0cff-0310-8789-dd5450dbe970
* Move the removal of the vc70.pdb and vc80.pdb files to the Jeffrey Altman2007-09-2213-23/+9
| | | | | | | | | global clean rule in config/Makefile.w32. No need to replicate them in each individual Makefile. ticket: 5756 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19966 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: APP: BUG: restore HideWatermark functionalityJeffrey Altman2007-09-211-1/+6
| | | | | | | | | | Restore the HideWatermark functionality that was accidently removed from ui/credwnd.c ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19964 dc483132-0cff-0310-8789-dd5450dbe970
* Windows\Identity Makefile "clean" moreJeffrey Altman2007-09-1813-11/+46
| | | | | | | | | | make sure that we clean up vc70.pdb, vc80.pdb, and temporary files generated during the build process. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19955 dc483132-0cff-0310-8789-dd5450dbe970
* wix installer - permit administrative installsJeffrey Altman2007-09-141-32/+3
| | | | | | | | | remove the registration requirement for administrative installs. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19936 dc483132-0cff-0310-8789-dd5450dbe970
* MSI installer for 64-bit AMD64Jeffrey Altman2007-09-059-314/+687
| | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for building 64-bit AMD64 MSI install packages in addition to 32-bit i386 MSI install packages. Differences between 32-bit MSI and 64-bit MSI include: * no krb4 binaries and libraries * no kclient binaries and libraries * no krb524 binaries and libraries * no leash32.exe * new AMD64 UpgradeCode permits parallel installation with 32-bit MSI * support for Visual Studio 2005 (VS8, CL1400) merge modules Open Issues: * 32-bit MSI installs kfwlogon.dll on AMD64 systems * 32-bit and 64-bit NetIDMgr.exe as startup. Need to decide which should be executed by default. Only one can run at a time. * Need to make sure that src/windows/build properly configures the site-local.wxi file for Visual Studio 2005 and platform. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19922 dc483132-0cff-0310-8789-dd5450dbe970
* 64-bit Windows gss.exe (gui version of gss-client.exe)Jeffrey Altman2007-09-052-3/+5
| | | | | | | | | | Now that krbcc64.lib exists we can build the gss.exe gss-api test client. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19921 dc483132-0cff-0310-8789-dd5450dbe970
* NIM file ccache support improvementsJeffrey Altman2007-08-294-60/+163
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NIM supports the ability of the user to specify an explicit ccache name for use with an identity. If this ccache is a FILE ccache, we need to be able to store credentials into the ccache. krb5cred.dll did not previously specify the KRB5_TC_OPENCLOSE flag on the ccache when setting other flags such as KRB5_TC_NOTICKET (which is used with MSLSA ccaches). As a result, open/close mode was turned off, the ccache file would be opened in read-only mode and attempts to store credentials into the ccache would fail. This is fixed by specifying KRB5_TC_OPENCLOSE when setting the ccache flags. When a CCAPI implementation is unavailable, we need to automatically generate the FILE ccache name if one has not already been specified. We default to a file stored in the user's Local Settings\Temp directory. The generated ccache is then added to the file ccache watch list. Finally, some users have complained about the behavior of Microsoft Vista's UAC mode and how it makes the CCAPI cache useless for storing credentials that must be used in conjunction with processes that do not have restricted privileges since those processes run in a separate logon session. For these users we have added a "DefaultToFileCache" registry value that can be specified to force the use of FILE ccaches in preference to CCAPI ccaches when there is no explicit ccache specified for a given identity. Unlike CCAPI ccaches, the FILE ccaches are accessible from both restricted and unrestricted processes when UAC is active. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19897 dc483132-0cff-0310-8789-dd5450dbe970
* NIM - a small readability changeJeffrey Altman2007-08-291-1/+1
| | | | | | | | | | Instead of testing for NOT the machine key, test for is the user key. ticket: new component: windows/identity/kconfig/api.c git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19896 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: remove unused symbolsJeffrey Altman2007-08-291-2/+0
| | | | | | | | | | Remove unused preprocessor symbols automatically added by Visual Studio's dialog editor. ticket: new component: windows/identity/ui/resource.h git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19895 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: 64-bit Windows Support and Removal of Compile Time WarningsJeffrey Altman2007-08-2840-568/+713
| | | | | | | | | | | | | | | | | | | | | | | | This patch permits Network Identity Manager to be built for 64-bit Windows. In the process all compile time warnings have been taken care of. For 64-bit Windows, we do not build the Kerberos v4 Credential Provider and we will not attempt to load the krb524 library. Note that when testing the 64-bit NIM, there is no CCAPI at the moment so you must manually specify a FILE: ccache as part of the identity's Kerberos v5 configuration if you want to use cache's other than the MSLSA. This patch also consolidates the computation of the default ccache name into utility functions: khm_krb5_get_identity_default_ccache khm_krb5_get_identity_default_ccacheA ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19891 dc483132-0cff-0310-8789-dd5450dbe970
* Windows 64-bit - avoid missing symbol errorsJeffrey Altman2007-08-271-2/+2
| | | | | | | | | | | | | Microsoft defaults stack checking (/Gs) to on. This requires that bufferoverflowU.lib be included in the link step. The macro SCLIB in the build system specifies this library on versions of Windows that require it. Include SCLIB on the link line of the makefile. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19881 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: version updateJeffrey Altman2007-08-242-648/+648
| | | | | | | | | | Set the Network Identity Manager application version to 1.3.1 and the API version to 10. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19869 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Revert ticket 5604Jeffrey Altman2007-08-241-2/+0
| | | | | | | | | | | | | | There was a spurious trigger for reloading the layout of the Network Identity Manager timer code. This was presumably introduced to mitigate a problem where the identity and outline status might become stale. (Ticket 5604) This should no longer be necessary. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19868 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Reposition New Credentials Dialog if necessaryJeffrey Altman2007-08-241-4/+28
| | | | | | | | | | | | | | | | | | | | | The new credentials dialog in Network Identity Manager does not check whether it is positioned outside of the display screen. It tries to position itself in the center of the primary display if the Network Identity Manager window is hidden and it tries to center itself over the main window if the main window is visible. If the main window is too close to the edge of the screen, this may result in the new credentials window being partially outside the display area. This is especially a problem when the new credentials dialog switches to the advanced view. The patch checks whether the window rectangle is visible before repositioning the new credentials dialog and adjusts the window rectangle so that it is. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19867 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: External changes to default identity are improperly reflected by krb5 ↵Jeffrey Altman2007-08-241-11/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | provider The Kerberos v5 identity provider for Network Identity Manager monitors the "Software\MIT\kerberos5" registry key for the logged in user for changes to the "ccname" value. If a change is noticed, it would query the Kerberos v5 library for the default credentials cache and attempt to determine the new default identity, which it would then communicate to the Network Identity Manager application. When the identity provider queried the Kerberos v5 library after a registry change notification, it used a cached krb5_context for the thread. The default credentials cache found using this krb5_context may not be what the registry specified. This patch modifies the code in k5_ccname_monitor_thread() to create a use a new krb5_context when querying for the default credentials cache following a registry change notification. Doing so ensures that Kerberos v5 library takes the new registry value into account. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19866 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: khcint_remove_space() frees memory too soonJeffrey Altman2007-08-241-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | The Network Identity Manager Configuration Provider module keeps track of the application and plug-in configuration settings organized into configuration spaces. The state of each configuration space is maintained in a reference counted object. Once all the references are released, the Configuration Provider will attempt to free the resources allocated for the object. If the configuration space was marked for deletion, then the registry keys associated with the object need to be deleted when the object is being discarded. Due to a coding error, the memory allocated for the object would be freed before the associated registry keys were deleted. This could result in a memory access error. The patch corrects the code in khcint_remove_space() to free the allocated memory after all the remaining clean-up steps have been performed. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19865 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Add Identity Provider Pre-Process Message Jeffrey Altman2007-08-244-363/+387
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Network Identity Manager application does not provide a user interface for identity specification. That responsibility lies with the identity provider. Whenever a dialog needs to allow the user to specify an identity, the identity provider has to populate the dialog with the necessary controls so that the user can specify an identity. In the case of the Kerberos v5 identity provider, the controls allow the user to specify a username and a realm. Once the dialog is populated, the application will dispatch window messages to the identity provider. The identity provider will handle the window messages and notify the application when the selected identity changes. One deficiency of the API was that there was no message to notify the identity provider that an identity selection has to be made immediately. When the user invokes the default action for a dialog by hitting enter, the only message received by the dialog is a command identifier of the default action. In this case, the identity provider will not get a chance to notify the application of the identity selection. This patch fixes the API deficiency by introducing a new message, WMNC_IDENT_PREPROCESS, which the application can use to notify the identity provider that the dialog box is about to be processed. In response, the identity provider can notify the application of the selected identity even if no other messages were received by the identity provider. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19864 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Keep API release documentation up to date Jeffrey Altman2007-08-241-0/+3
| | | | | | | | | | | | | | Update the Network Identity Manager developer documentation to include a reference to the 1.3.0 release which was included with Kerberos for Windows 3.2.1. The release history and, in particular, the API versions corresponding to each release is important for third-party plug-in developers. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19863 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: support include files in schemasJeffrey Altman2007-08-242-189/+201
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ccsv.pl and csvschema.cfg scripts are used to generate "C" source code from CSV files containing tabular data. In particular, these are used to define the configuration schema for Network Identity Manager and some of its plug-ins. It is desirable to be able to include arbitrary header files and define macros in the generated C code so that the schema definition can use them. This patch allows the CSV files to contain headers that define lines of text that will be included literally in the generated C code. Lines at the start of schema CSV file that begin with '#@' will be stripped of the '#@' prefix and inserted into the C code. E.g: The following line at the start of a schema CSV file: #@#include<windows.h> ,will result in the following text in the C code: #include<windows.h> Then the schema definition can use macros of the form: ClrHeaderExpSel, KC_INT32, "RGB(195, 94, 94)" ,which use macros such as RGB that are defined in the included header file. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19862 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: remove unused code from ui/credwnd.cJeffrey Altman2007-08-241-28/+0
| | | | | | | | | | | | | | | | | Remove unused code from Network Identity Manager credwnd.c. The code was meant to construct a user interface context based on where the user right clicks on the credentials display. However, doing so without indicating the changed selection to the user results in the application performing an operation on an identity or credential that the user didn't intend to select. The code was commented out and was never used in any recent release of Kerberos for Windows. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19861 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Selection IssuesJeffrey Altman2007-08-241-47/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Credentials selection in Network Identity Manager has usability issues due to the following causes: - The "cursor row" is not always selected. The "cursor row" is the row which the "cursor" is on. Navigating the credentials view using the keyboard or clicking the credentials display with the mouse will move the cursor to different rows. However, this cursor row is not always selected, especially when Network Identity Manager starts. Having the selection be independent of the cursor row is a requirement for supporting "toggle" selections (holding the 'ctrl' key while clicking), which is a standard way of doing multiple selections on Windows. The problem with the cursor row not being selected when Network Identity Manager starts is due to the delayed start of its plug-ins. Even though the first row is initially selected, when plug-ins complete initialization and notify the application about the credentials that they see, those credentials end up accumulating under different identities. The existing code didn't enforce the selection state of the identity on the newly added credentials. Since there were unselected credentials under the selected outline level, the code would then turn off the selected bit for the outline (which usually is an outline level for an identity) for consistency. The patch changes the behavior to enforce the selection state of the enclosing outline on any new outline levels or credentials that are added under it. This prevents an outline level from losing its selection state when new credentials are added under it. - Identities may have stale data associated with it. The credentials view maintains a set of cached properties for each identity that has credentials. During each refresh cycle, it would go through the credentials and update the properties of each identity. However it would not update the properties for identities that are not associated with any credentials. When the credentials associated an identity were deleted, the cached properties for that identity sometimes never got reset. If the identity was marked as "always visible", then it would be listed in the credentials view along with the stale properties. This patch properly initializes the properties of identities which are not associated with any identities. - Selection state is not updated when switching views. The credentials view maintains selection state for individual credentials when switching views. The same is not true for the outlines since the outline needs to be reconstructed during the switch. The exising code failed to update the selection state of the outlines after switching the view to reflect the the selection state of the credentials. As a result, once a the user switched a view, she might see outline levels which do not appear to be selected even though all the credentials contained at the outline level appear selected. This patch properly adjusts the selection state of outline nodes to correspond to the selection state of the contained credentials. - Selection state may be inconsistent when more than one credential is associated with a single row. Some rows may represent more than one credential. A collapsed outline represents all the credentials contained within that outline level. In addition, two credentials that will appear the same to the user (because all the displayed properties are the same) will be represented by one row. The selection state of these rows should be consistent with the selection state of all the credentials that it represents. The previous code did not enforce this constraint. This patch aims to fix this by enumerating all the credentials that are represented by each row and setting the selection state of each credential to match the selection state of the row. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19860 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Handle WM_PAINT messages without update regionsJeffrey Altman2007-08-241-9/+15
| | | | | | | | | | | | | | | | | It is possible to receive a WM_PAINT message in Windows without there being an update region. For example, this can be caused by someone calling RedrawWindow() with the RDW_INTERNALPAINT flag set. In this case, GetUpdateRect() will indicate that there is no update region and calling BeginPaint()/EndPaint() results in incorrect behavior. The credentials window in Network Identity Manager needs to perform special handling for this case by obtaining a proper device context and completing the drawing operation. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19859 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: do not permit resizing of filler columnsJeffrey Altman2007-08-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | The credentials display of Network Identity Manager allows the user to change the order and size of the displayed columns. However, some columns are not resizable. An oversight in the earlier code allowed the user to change the size of "filler" columns. These columns are sized to fill up the remainder of the display area after the other columns have been allocated. Their width is determined by the size of the credentials display and the width of the other columns. They are used in the basic view where the only columns are the flags column (fixed width) and the identity column (filler). This patch prevents the "filler" columns (columns with the KHUI_CW_COL_FILLER flag) from being resized. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19858 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Cannot cancel timers which have inserted a WM_TIMER message into the queueJeffrey Altman2007-08-241-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The credentials view in Network Identity Manager displays several user interface elements that need to be updated periodically such as any fields that denote the time remaining for a credential or an identity, or an icon and coloring used to indicate the expiration state. When the display rows are computed, the credentials view creates a set of timers that reference each row that times out when that row needs to be redrawn. Since the rows change when switching views or when the outline is recomputed, all the timers are canceled and re-scheduled. However, a race conditions exists where the timer times-out before it is canceled, in which case a WM_TIMER message is placed in the credential window's message queue. Windows does not support canceling a timer that has already fired and has been placed on the message queue. By the time the WM_TIMER message is received by the window, the rows of the display would have been recomputed and the row that the message references may not be what it intended to reference. A spurious WM_TIMER message is harmless when it refers to a row corresponding to a credential. However, the existing code assumed that if a timer event is received that referred to an outline row, then that outline must be an expanded view of an identity, which is currently the only type of outline row that receives timers. This assumption does not always hold in the case of a spurious WM_TIMER message and may lead to the code attempting to use the outline data as a handle to an identity. The patch fixes the problem by checking if the row is actually an expanded view of an identity and ignoring the message if it is not. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19857 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Context menu selection issuesJeffrey Altman2007-08-241-15/+40
| | | | | | | | | | | | | | | | | | | | | | | | The handler for WM_CONTEXTMENU in the credentials view of Network Identity Manager assumed that the context menu was invoked using the mouse. If it was, then the message parameters would specify the x and y co-ordinates of the mouse. The context menu can also be invoked via the keyboard, in which case the x- and y- coordinates are set to (-1,-1). An additional problem with the code is that it was not selecting the row that was right-clicked on if it was not already selected. This results in the some of the commands on the context menu targetting credentials that the user didn't intend to target. This patch adds support for handling the context menu when it is invoked via the keyboard and also sets the selection to the row that was right-clicked if the user invokes the context menu using the mouse. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19856 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: Color SchemasJeffrey Altman2007-08-243-248/+365
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default color scheme used by the Network Identity Manager credentials display can sometimes cause the text to be difficult to read. In addition, since some of the colors are derived from colors used by the current Windows theme, the selection, window background and text colors may be mismatched with the colors that are hardcoded into the application. To rememdy this problem, this patch defines a new set of colors that will be used with the credentials display. The new scheme doesn't use a special color to distinguish the default identity which is already indicated with the text "(Default)" displayed alongside it. Instead the colors are used to denote the remaining lifetime of credentials and identities. Also, the color scheme defines all the colors that it uses instead of deriving some of them from the Windows color scheme. All the color information is now kept in the Network Identity Manager UI schema. The schema automatically maps to the registry, so users (and deployers) can override the colors by creating the necessary registry keys and values. The registry keys containing color information are: Software\MIT\NetIDMgr\CredWindow\Themes and Software\MIT\NetIDMgr\CredWindow\Themes\Default The "Default" key contains the default color scheme. The color value names are defined in ui\uiconfig.csv under Themes\_Schema configuration subspace. Each color is represented by a 32-bit number. The low-order 24 bits contain a COLORREF value. The high-order 8 bits contain an alpha value which, if non-zero, will be used to blend the color with the selection color (color value named ClrSelection). ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19855 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: New command-line options --hide and --show / new command-line help dialogJeffrey Altman2007-08-249-925/+1145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add two command-line options to the Network Identity Manager application: --hide : If there is already an instance of Network Identity Manager running in the user's session, this will cause the main window of that instance to be hidden. --show : Unhides the main window of the running instance. If no options are specified when starting netidmgr.exe while another instance is running, the running instance will perform the default action as configured in the user's preferences. By default, this will be to show the main window. The message box that displayed the command-line options if an invalid option is specified has been replaced with a dialog box that shows the options in a more readable rich text control. The contents of the control are specified in ui/lang/<lang>/cmdline.rtf. Do not edit cmdline.rtf with Microsoft Word. The output of Word is incompatible with the RichEdit20 component. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19854 dc483132-0cff-0310-8789-dd5450dbe970
generated by cgit (git 2.34.1) at 2025-09-28 06:02:35 +0000