summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Removed NOP line of code from krb5_fcc_next_cred()Alexandra Ellwood2007-10-031-1/+0
| | | | | | | | | | | | | | | | | | | | | | cursor = (krb5_cc_cursor *) fcursor; does nothing for a function with a prototype krb5_fcc_next_cred(krb5_context context, krb5_ccache id, krb5_cc_cursor *cursor, krb5_creds *creds) The correct line of code would be: *cursor = (krb5_cc_cursor) fcursor; Except it isn't necessary because fcursor isn't modified by krb5_fcc_next_cred(). Looks like code was copied from krb5_fcc_start_seq_get() and since the line was a NOP no one noticed it. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20085 dc483132-0cff-0310-8789-dd5450dbe970
* Add documentation for error codes used for flow controlAlexandra Ellwood2007-10-0329-2312/+3559
| | | | | | ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20084 dc483132-0cff-0310-8789-dd5450dbe970
* Apply patch from Nalin Dahyabhai to correctly handle delegatedTom Yu2007-10-031-2/+5
| | | | | | | | | | credentials if ret_flags is null. ticket: 5802 target_version: 1.6.3 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20082 dc483132-0cff-0310-8789-dd5450dbe970
* cc_initalize(ccapi_version_2) should return CC_BAD_API_VERSION not CC_NOT_SUPPAlexandra Ellwood2007-10-021-1/+1
| | | | | | | ticket: new target_version: 1.7 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20081 dc483132-0cff-0310-8789-dd5450dbe970
* Initialize options for _alloc interface to same defaults as for _initKen Raeburn2007-10-011-1/+9
| | | | | | | ticket: 5800 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20064 dc483132-0cff-0310-8789-dd5450dbe970
* remove error tables by pointer Jeffrey Altman2007-10-011-3/+3
| | | | | | | | | | | | | | | On Windows, it is possible for the same DLL to be loaded into a process multiple times as separate instances. Each time a DLL is loaded it registers its error tables at different locations in the process address space. Removing the tables by base instead of pointer value can result in the error table list pointing at invalid memory. ticket: new tags: pullup target_version: 1.6.3 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20040 dc483132-0cff-0310-8789-dd5450dbe970
* def-check.pl needs to ignore ordinals in .def fileKen Raeburn2007-10-011-0/+1
| | | | | | | | | Otherwise, the UNIX build blows out now that the Windows export lists have been updated. Silly consistency checks.... ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20039 dc483132-0cff-0310-8789-dd5450dbe970
* - null params are always expected to result in ccErrBadParam.Justin Anderson2007-10-012-19/+23
| | | | | | | | - clarified some test descriptions ticket: 5459 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20036 dc483132-0cff-0310-8789-dd5450dbe970
* Process WM_CLOSE for the command-line option dialogJeffrey Altman2007-10-011-0/+8
| | | | | | | | | ticket: 5798 tags: pullup target_version: 1.6.3 component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20035 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: notification icon tooltip wrong stringJeffrey Altman2007-10-011-0/+2
| | | | | | | | | | | | | | | | | | | The Network Identity Manager notification icon can display a tooltip when the user hovers the mouse cursor over it. It is currently used to indicate the default identity (if one is found). However, when retrieving the name of the default identity, the size of the buffer was left unspecified. This patch specifies the correct buffer size. The function called with the incorrect buffer size was kcdb_identity_get_name(). That function does not write more than KCDB_IDENT_MAXCCH_NAME characters regardless of the size of the buffer specified, and the buffer that was passed in is allocated to be this size. No buffer overrun was present in the existing code, although the behavior was incorrect. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20034 dc483132-0cff-0310-8789-dd5450dbe970
* When Network Identity Manager starts, the credentials displayJeffrey Altman2007-10-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | enumerates known identities and displays them if necessary. However, as plug-ins load and the list of known identities, their properties and credentials change, the order of the displayed list will also change. The existing code does not deal well in respect to tracking the current selection when the list of identities and credentials change. This results in inconsistent behavior where the identity that was originally at the top of the list maintains its selection state while the identity at the top of the list after all the plug-ins have loaded will receive focus. This patch fixes this problem by explicitly setting focus and selection to the identity or credential at the current cursor location following a change in the credentials list. ticket: 5782 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20033 dc483132-0cff-0310-8789-dd5450dbe970
* The credentials display in Network Identity Manager colors theJeffrey Altman2007-10-011-14/+19
| | | | | | | | | | | | | | | | | background of identity headings based on the expiration state of the credentials that belong to the identity. This patch changes the behavior to color these headings based on the existence and expiration state of identity credentials. With this change, only identities that have valid identity credentials will appear in green. The same logic is used when drawing the menu items in the "Set default" sub-menu in the notification icon. ticket: 5783 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20032 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: notification icon state Jeffrey Altman2007-10-011-13/+28
| | | | | | | | | | | | | | | | Currently, the notification icon that is created by Network Identity Manager indicates the status of all the known credentials. If any credential belonging to any identity is expired or in a critical state, the icon will change color to indicate this. This patch changes the behavior to only indicate the status of credentials belonging to the default identity. The expiration state of credentials that do not belong to the default identity no longer affect the appearance of the notification icon. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20031 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: identity data corruptionJeffrey Altman2007-10-011-1/+1
| | | | | | | | | | | | | | The credentials display in Network Identity Manager uses a cached set of properties for each identity that has credentials. The existing code used the wrong field of the khui_credwnd_identity structure to store the credentials type name associated with an identity, resulting in a corrupt data structure. This patch fixes the code to use the correct field. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20030 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: View-Select columns Jeffrey Altman2007-10-011-1/+2
| | | | | | | | | | Change "View columns" to "Select columns" in the "View" menu of Network Identity Manager to be consistent with other Windows applications. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20029 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: leaking prompts in obtain new credentials dialogJeffrey Altman2007-10-011-0/+12
| | | | | | | | | | | | | | The Kerberos v5 plug-in for Network Identity Manager was not clearing the list of prompts properly when a user changes the active identity in the new credentials dialog. The stale prompts would be visible to the user if the newly selected identity is invalid or the new identity cannot be validated. This patch clears the prompts if there is an identity change. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20028 dc483132-0cff-0310-8789-dd5450dbe970
* add descriptions of credential flags, identity icons, and push-pinsJeffrey Altman2007-10-0124-173/+221
| | | | | | | | | | | | update screen shots add credits to Fermilabs and Stanford University. other changes for kfw 3.2.2 release. ticket: 5789 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20027 dc483132-0cff-0310-8789-dd5450dbe970
* fix the description of the notification icon status colorsJeffrey Altman2007-10-012-0/+0
| | | | | | ticket: 5789 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20026 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: LIB: deadlock in kmqJeffrey Altman2007-09-303-0/+19
| | | | | | | | | | | | Do not obtain a critical section that is already being held: "cs_kmq_types" Update the docs to indicate the additional restriction. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20025 dc483132-0cff-0310-8789-dd5450dbe970
* Add static ordinals to DLL exportsJeffrey Altman2007-09-304-356/+358
| | | | | | | | | | | | | | | Add static ordinals to DLL exports in krb5_32.def, xpprof32.def gssapi32.def, and krb524.def. Not added to k5sprt32.def as all of the functions are private. Not added to krb4_32.def as the library is not supported as part of KFW. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20024 dc483132-0cff-0310-8789-dd5450dbe970
* When there is no ImagePath value for a module it indicatesJeffrey Altman2007-09-301-1/+5
| | | | | | | | | | | | | that the module has not been installed. Do not report an error to the end user for uninstalled modules. This will only annoy the user and there is probably nothing the user can do about it. Perhaps the user uninstalled the module intentionally. The fact that there is still a HKCU key remaining is not an indication that the module is in use. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20023 dc483132-0cff-0310-8789-dd5450dbe970
* Remove Krb5Cred, Krb5Ident, and Krb4Cred default configuration data fromJeffrey Altman2007-09-302-9/+45
| | | | | | | | | | | | | | | the KMM Schema. Require that modules that are installed be properly installed. Add NIM Module Registry values to the NSIS installer. These values were already being set by the Wix installer. By removing the ImagePath default, unable to load module errors will not be generated when the module has not in fact been installed. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20022 dc483132-0cff-0310-8789-dd5450dbe970
* fix documentation typoJeffrey Altman2007-09-301-1/+1
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20021 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: disable warningJeffrey Altman2007-09-301-1/+4
| | | | | | | | | | Disable the potentially uninitialized variable warning for 'ri'. The variable cannot be used when uninitialized. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20020 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: PDF user documentation updates for KFW 3.2.2Jeffrey Altman2007-09-302-0/+0
| | | | | | | | | updates for NIM 1.3.1 / KFW 3.2.2 ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20019 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Provide keyboard accelerator Jeffrey Altman2007-09-291-1/+1
| | | | | | | | | | In the Advanced mode of the Obtain New Credentials dialog the keyboard accelerator was missing. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20018 dc483132-0cff-0310-8789-dd5450dbe970
* Fix typoJeffrey Altman2007-09-291-0/+0
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20017 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Spell CheckJeffrey Altman2007-09-292-34/+34
| | | | | | | | | Correct typos. Make use of "plug-in" vs "plugin" consistent. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20016 dc483132-0cff-0310-8789-dd5450dbe970
* cc_ccache_set_principal and cc_ccache_get_principal were also ignoring theirAlexandra Ellwood2007-09-272-37/+114
| | | | | | | | credentials version inputs. ticket: 5771 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19986 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: FEATURE: APP: Notification Icon Tooltip Jeffrey Altman2007-09-273-34/+66
| | | | | | | | | | | | | | The Network Identity Manager notification icon can have a tooltip associated with it. The tooltip will be displayed to the user if she hovers the mouse cursor over the notification icon. Currently, the tooltip is used to indicate the current status of Network Identity Manager. This patch adds the name of the default identity to the tooltip. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19985 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: LIB: optimize khui_find_action()Jeffrey Altman2007-09-271-7/+9
| | | | | | | | | | | | In Network Identity Manager, when locating the action object corresponding to an action identifier using khui_find_action(), don't search through the list of standard actions if we already know that the object we are searching for is a custom action. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19984 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "Set default" sub menu to the Network Identity ManagerJeffrey Altman2007-09-2712-59/+317
| | | | | | | | | | | | | notification icon context menu. The submenu will display a list of identities that the user can select as the default identity. Each identity that is displayed in the sub menu will be colored the same way it is colored in the basic view to provide a hint as to the state of the credentials belonging to the identity. ticket: 5724 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19983 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "View all identities" option to the view menu of NetworkJeffrey Altman2007-09-279-7/+77
| | | | | | | | | | | | | Identity Manager. This option will be toggled when selected. If enabled, all the known identities will be displayed in any credentials view which uses the identity of credentials as the primary group-by field. The setting of this option is persistent. ticket: 5719 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19982 dc483132-0cff-0310-8789-dd5450dbe970
* profile library memory leaks introduced when malloc returns 0Ezra Peisach2007-09-263-2/+7
| | | | | | | | | | | | | | | | | | | | I have a modified version of valgrind that will allow me to have malloc fail in a controlled way. A number of memory leaks in error return passes exist in the profile library. They are essentially inconsequental - but my goal is to eventually create a test harness that tries to cover all code - including error returns... prof_parse.c: (profile_parse_file): Free node being created if parse_line() fails. prof_file.c (profile_open_file): free prf_data_t on malloc failure prof_tree.c (profile_create_node): The magic element must be set before calling profile_free_node for it to release memory. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19981 dc483132-0cff-0310-8789-dd5450dbe970
* Include missing fileJustin Anderson2007-09-251-0/+57
| | | | | | ticket: 5459 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19980 dc483132-0cff-0310-8789-dd5450dbe970
* Update ccapi tests to work at new location in krb5 tree. Also, test for ↵Justin Anderson2007-09-259-12/+14
| | | | | | | | platform when compiling so that KfM and KfW can use this ticket: 5459 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19979 dc483132-0cff-0310-8789-dd5450dbe970
* Document use of KRB5_CCH_CCNAME for ccache name lengthJeffrey Altman2007-09-251-4/+4
| | | | | | ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19978 dc483132-0cff-0310-8789-dd5450dbe970
* change all MAX_PATH ccname buffer lengths to KRB5_CCH_CCNAME and Jeffrey Altman2007-09-251-8/+8
| | | | | | | | document the use of KRB5_CCH_CCNAME. ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19977 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KMM: miscellaneous fixesJeffrey Altman2007-09-253-13/+17
| | | | | | | | | | | | | | | | | | | kmm_reg.c: Allocate enough memory to hold the entire PluginList multi-string plus an extra NUL if the registry value was not properly terminated. kmm_registrar.c: Do not record an error loading a module if there was no configuration for it. kmmmain.c: Avoid a race condition by sending the thread quit message instead of posting it. Do so outside of the critical section to avoid a deadlock. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19976 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KRB5: cleanup krb5funcsJeffrey Altman2007-09-251-2/+3
| | | | | | | | | | | | | | | | (1) remove an extraneous backslash from the generated FILE: ccache name. GetTempPath() always returns paths terminated with a backslash. (2) increase the max ccache name length to KRB5_CCH_CCNAME from MAX_PATH. These changes have dependencies on revisions 19891 and 19897. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19975 dc483132-0cff-0310-8789-dd5450dbe970
* More consolidation of the computation of the default ccache nameJeffrey Altman2007-09-251-29/+2
| | | | | | ticket: 5691 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19974 dc483132-0cff-0310-8789-dd5450dbe970
* cc_ccache_set_principal always returns error 227Alexandra Ellwood2007-09-251-1/+1
| | | | | | | | | Was attempting to read the new name from the reply stream. ticket: new target_version: 1.7 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19973 dc483132-0cff-0310-8789-dd5450dbe970
* Set svn:eol-style on a bunch of text-looking files that didn't have itKen Raeburn2007-09-24115-11761/+11761
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19972 dc483132-0cff-0310-8789-dd5450dbe970
* we're not using changelog files any moreKen Raeburn2007-09-242-49/+0
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19971 dc483132-0cff-0310-8789-dd5450dbe970
* Remove the broken optimization from UnicodeToANSI() that attemptedJeffrey Altman2007-09-241-5/+3
| | | | | | | | | | | | | | | | | | | | | in a stupid way to avoid to WideCharToMultiByte() call by testing to see if the second byte (not wchar) was NUL. This test works for Latin1 but not for anything more interesting. Always call WideCharToMultiByte(). I commented out the use of WC_NO_BEST_FIT_CHARS in order to provide compatibility with Windows. Windows converts the user name without that option. With the current code a principal name consisting of a single component equivalent to the Greek character Sigma and a realm name will be converted to S@REALM exactly as the "WhoAmI" command does. If WC_NO_BEST_FIT_CHARS was specified, this string would be converted to "?@REALM". ticket: 5766 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19970 dc483132-0cff-0310-8789-dd5450dbe970
* MSLSA krb5_cc module fails to check success of UNICODE string conversionsJeffrey Altman2007-09-241-13/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MSLSA krb5_cc module was written with an assumption that probably does not hold true anymore. It assumed that all Kerberos strings although stored in wide character data structures could in fact be represented in the application's ANSI code page and that such conversions would not fail. The UnicodeToANSI() function did not check the result of WideCharToMultiByte() for success. If the conversion failed, this could result in the caller believing the contents of the output string buffer were a valid string when instead they were simply stack garbage. The UnicodeStringToMITPrinc() and KerbExternalNameToMITPrinc() functions did not check the return value of krb5_parse_name() for success. If krb5_parse_name() was passed a pointer to garbage on the stack instead of an actual principal name, this could result in the caller believing the output krb5_principal * was valid when instead it was NULL. The function CacheInfoEx2ToMITCred() is dependent on the success or failure of UnicodeStringToMITPrinc() assumed it could not fail and did not return a success or failure indication to its caller. If Microsoft a formatted ticket contains a Unicode string that can not be represented in the application's ANSI code page, this could result in a NULL pointer dereference during a call to krb5_cc_resolve("MSLSA:") or krb5_cc_retrieve(), or krb5_cc_get_principal(). With the changes in this commit, tickets containing principal names that cannot be represented in the application's ANSI code page will be hidden from the application. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19969 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: Restore Copyright removed in revision 19855Jeffrey Altman2007-09-241-0/+1
| | | | | | | | | Restore MIT Copyright removed in revision 19855. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19968 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: khm_krb5_initialize() failed to return error codeJeffrey Altman2007-09-241-4/+4
| | | | | | | | | | | | | | | | khm_krb5_initialize() is called in the krb5cred.dll and krb4cred.dll credential providers in order to ensure that the caller has references to a valid krb5_context and a valid krb5_ccache. If the krb5_cc_resolve() call failed, the error code was not being returned to the caller. Instead, success was returned which in turn would result in the caller believing the NULL krb5_ccache pointer was in fact valid. This fix resolves Microsoft's WER Event ID 432405961. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19967 dc483132-0cff-0310-8789-dd5450dbe970
* Move the removal of the vc70.pdb and vc80.pdb files to the Jeffrey Altman2007-09-2213-23/+9
| | | | | | | | | global clean rule in config/Makefile.w32. No need to replicate them in each individual Makefile. ticket: 5756 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19966 dc483132-0cff-0310-8789-dd5450dbe970
* stdint.h should only be accessed if HAVE_STDINT_H definedJeffrey Altman2007-09-221-1/+3
| | | | | | | | | stdint.h does not exist on Windows. Conditionally include it based upon HAVE_STDINT_H ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19965 dc483132-0cff-0310-8789-dd5450dbe970
generated by cgit (git 2.34.1) at 2024-11-16 21:16:35 +0000