summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Rename 'free' -> 'free_func' in asn1_encode.c/.hKevin Wasserman2012-07-162-3/+3
| | | | | | | | | MSVC memory tracking tools do '#define free(p) _dbg_free(...)'. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7205 (new) tags: pullup
* KFW win-mac.h fixesKevin Wasserman2012-07-161-0/+6
| | | | | | | | | | | | | | | | kfw: add int16_t, uint16_t typedefs to win-mac.h uint16_t is used in chpw.c include stdlib.h, crtdbg.h in win-mac.h Allows leak-tracking using built-in msvc tools on windows. crtdbg.h needs to come _after_ stdlib.h, but _before_ checking for strdup. Define DEBUG and CRTDBG_MAP_ALLOC for full tracking. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7204 (new) tags: pullup
* kfw add preauth_sam2 to OBJS for windows buildKevin Wasserman2012-07-161-0/+1
| | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7203 (new) tags: pullup
* Clarify date-time format in admin documentationZhanna Tsitkov2012-07-134-86/+29
|
* Fix typo in "Supported date and type formats" docZhanna Tsitkov2012-07-132-5/+5
|
* Fix error handling in allocate_princ()Greg Hudson2012-07-131-2/+4
| | | | | The most recent change could leak memory when trying to parse an invalid principal because of a failure to use the cleanup handler.
* Replace // comment in ccdefname.cGreg Hudson2012-07-131-1/+1
|
* New "Supported date and time formats" documentZhanna Tsitkov2012-07-122-0/+139
|
* Tidy up configure options documentationBen Kaduk2012-07-121-45/+2
| | | | | | | | | | | | | Our only C++ code is under src/tests/misc/. Infodir is only referenced in send-pr's makefile but not used in any rules therein. Docdir and its descendants ({html,dvi,pdf,ps}dir) are not used in any install rules. We do not have anything to install into libexecdir or sharedstatedir, and oldincludedir simply has no effect.
* Standardize on commas after "e.g.", "i.e."Ben Kaduk2012-07-129-20/+20
| | | | It seems to be "more correct".
* Sync configure options with configureBen Kaduk2012-07-121-3/+41
| | | | | | | We should try to stay coupled with the actual configure options, as documented by 'configure --help'. Remove an option which is no longer present and add several that were missing.
* Only list --enable-dns-for-realm onceBen Kaduk2012-07-121-3/+0
| | | | | | | | If we list something as "commonly used", we seem to not also list it with the rest of the options. This has the advantage of not requiring us to remember to update two things for future changes, but the disadvantage of requiring users to look in two places for options. Stick with the prevailing form for now.
* Sort configure optionsBen Kaduk2012-07-121-11/+11
| | | | | | | | | Stick to the order of 'configure --help' for most sections, but sort environment variables alphabetically (since, e.g., configure --help does not list CPPFLAGS and there is not a good way to add that). Note that this does not add or remove any content, even though some options are missing/extra.
* Cleanup docs for DNS lookup configure optionsBen Kaduk2012-07-121-6/+5
| | | | | | | DNS lookups for KDCs have been unconditionally enabled in configure since 2003; configure options only affect whether DNS lookups are used for realm names. Change the RST documentation of configure options to catch up.
* Handle huge /bin directories in libdb2 testTom Yu2012-07-121-6/+7
| | | | | | | | | | | | The test suite for libdb2 uses /bin as a source of filenames and contents for insertion into databases. Fedora 17 (and possibly other OSes) have /bin symlinked to /usr/bin, which can vastly increase the number of files found, exceeding some limits of the test databases. Truncate this list of files at 100 to prevent this problem. ticket: 7201 (new) status: pullup target_version: 1.10.3
* Correct comments in port-sockets.hGreg Hudson2012-07-121-23/+20
|
* Always recreate acl files during dejagnu testsTom Yu2012-07-112-11/+7
| | | | | | | | | | | | | The dejagnu tests create some persistent acl files containing hostname-derived principal names. These can get out of date if the host has changed names since the last time the dejagnu tests were run, causing failures (notably in iprop.exp). To avoid this problem, change the dejagnu tests to always create new acl files for each test run. ticket: 7200 (new) tags: pullup target_version: 1.10.3
* Add comment documenting make_toolong_error()Tom Yu2012-07-111-0/+4
| | | | | The KDC doesn't obviously call make_toolong_error(), but some code in net-server.c (which is linked into the KDC) does. Document this fact.
* Add krb5int_cc_user_set_default_nameKevin Wasserman2012-07-113-4/+58
| | | | | | | | | | | | | Set the default credential cache name for all processes for the current user. Currently implemented, for windows only, by setting HKEY_CURRENT_USER\Software\MIT\Kerberos5:ccname to the specified ccache name. This will not override the environment variable 'KRB5CCNAME'. It will override HKEY_LOCAL_MACHINE and 'indirect' registry values. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7199 (new) tags: pullup
* Implement switch_to for ccapiv3Kevin Wasserman2012-07-112-0/+27
| | | | | | | | | | | krb5_stdccv3_switch_to() calls cc_ccache_set_default(). krb5_stdccv3_resolve() checks for NULL or empty residual and calls cc_context_get_default_ccache_name() in those cases. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7198 (new) tags: pullup
* Translate WinSock errors to Posix counterpartsKevin Wasserman2012-07-111-1/+35
| | | | | | | | | | | | | | | | | | | | | MSVC 2010 defines both Posix and WinSock error values so we can no longer simply #define the Posix error values to be their WinSock counterpart. This patch explicitly #includes <errno.h> in port-sockets.h and still conditionally defines the Posix error values for compatibility with older MSVC but also translates WinSock errors to Posix for MSVC 2010 compatibility. The downside to this approach is that there are some Posix errors we do not currently detect (e.g. EADDRINUSE) that are neither #defined nor translated. If we use one of those in the future but fail to update TranslateWSAGetLastError() we'll once again be in the situation that the windows build will compile but fail to work, possibly only when some rare error condition occurs. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7197 (new) tags: pullup
* Allow full ccache name in k5test's K5Realm.klistGreg Hudson2012-07-111-1/+4
|
* Automatically create DIR ccache directoriesGreg Hudson2012-07-114-4/+3
| | | | | | | | If the directory for a DIR ccache doesn't exist yet, try to create it (but not its parents) with mode 700. Exercise this in test scripts by not pre-creating directories. ticket: 7196 (new)
* Sphinx html: reorder admin/user commands indexZhanna Tsitkov2012-07-112-7/+7
|
* Updated Example section in kdc.confZhanna Tsitkov2012-07-112-5/+19
|
* Add *~ to .gitignoreGreg Hudson2012-07-091-0/+1
| | | | | This covers src/include/autoconf.h.in~ which can be created by util/reconf.
* Avoid mapping GSSAPI minor code on successGreg Hudson2012-07-081-1/+2
| | | | | | | | | In gssint_import_internal_name, don't map the minor code from mech->gss_duplicate_name if it returned successfully. Fixes an "unexpected non-zero minor status" error reported by SAP's gsstest when it invokes gss_canonicalize_name(). ticket: 7194 (new)
* Reject extra realm separators in principal namesGreg Hudson2012-07-081-0/+2
| | | | | | Commit f609e5caff410cc8f71db7d95b4da219541437db accidentally omitted the check for extra realm separators, leading to an assertion error when parsing x@y@z or similar. Restore the check.
* Revert "Document absolute times for 'kinit -s'"Ben Kaduk2012-07-072-5/+3
| | | | | | | | This reverts commit 20f85a81151f69689e3c060e89852687eb6c5a3c. The ability of 'kinit -s' to accept an absolute time is intentionally undocumented and remains only for backwards compatibility. Leave a comment in the source to this effect, for future generations.
* Allow using locales when gettext is absentBen Kaduk2012-07-0616-5/+18
| | | | | | | | | | | Previously, if configure did not detect dgettext(), we disabled anything that smelled like localization, inadvertently including setlocale(). Now that we use setlocale(LC_ALL, ""), we have localized dates available as well as messages, so we should not disable calls to setlocale() any more. Since the routines from locale.h are only used in a relatively small number of places, just include the header directly in those files and remove it from k5-platform.h.
* Pass the user's CPPFLAGS in ALL_CFLAGSBen Kaduk2012-07-061-1/+1
| | | | | | We need them if any headers we depend on are not in the default search path (e.g., gettext.h). These files are built for 'make check' but not for the normal build.
* Document absolute times for 'kinit -s'Ben Kaduk2012-07-061-1/+5
| | | | | | | | | | | kinit's -s argument takes a parameter, which is first interpreted as a time interval ("deltat"), in the same format used for the -l and -r arguments. However, if that fails, the time argument is interpreted as an absolute time, in one of twelve different possible formats, some of which are subject to localization via strptime(). Explicitly listing all twelve possible interpretations is overkill, but give the user a hint that absolute times are possible at all.
* Enable all localizations in main functionsBen Kaduk2012-07-0619-23/+26
| | | | | | | | | | | | | | | Bite the bullet and pass LC_ALL to setlocale() instead of just LC_MESSAGES. Calls to setlocale() itself were introduced in fabbf9e443459e8c0161c84563690ed70c7f6a61 for ticket 6918, but only for LC_MESSAGES since only localized strings were needed and that was the most conservative option. However, klist, kadmin, and kinit (and perhaps others) would benefit from localized formats for times (i.e., LC_TIME). If potentially localized data is being sent on the wire, that is a bug that should be fixed. No such bugs are found with the current test suite, so we are comfortable enabling LC_ALL at this time. ticket: 7192
* Remove dead codeBen Kaduk2012-07-051-11/+0
| | | | | This (hair-raising) macro is not referenced anywhere in the tree, so remove it and the associated comment.
* Add ccinit and ccrefresh to .gitignoreGreg Hudson2012-07-051-0/+2
|
* Clarify diff between krb5.conf and kdc.conf filesZhanna Tsitkov2012-07-051-22/+2
|
* Simplify pkinit_server_verify_padata slightlyGreg Hudson2012-07-051-7/+2
| | | | | Eliminate the effectively unused variable tmp_as_req, and eliminate two unnecessary conditionals for freeing pointers.
* Simplify and fix pkinit_as_req_create cleanupGreg Hudson2012-07-051-11/+5
| | | | | | Avoid dereferencing a null auth_pack pointer if we run out of memory initializing info or auth_pack. Eliminate an unnecessary switch by just cleaning up all of the potentially allocated variables.
* Fix minor memory leaks in PKINIT codeGreg Hudson2012-07-051-0/+2
|
* Fix PKINIT verify_kdc_eku trace loggingGreg Hudson2012-07-051-1/+1
| | | | Test the value of the eku_accepted output parameter, not the pointer.
* Correct an error in GSSAPI initiator cred docsGreg Hudson2012-07-031-3/+3
|
* Fix typo in previous change to get_fq_hostnameTom Yu2012-07-031-1/+1
| | | | ticket: 7086
* Fix a minor memory leak in get_fq_hostnameArlene Berry2012-07-031-1/+3
| | | | ticket: 7086
* Take care with types in process_routing_update()Ben Kaduk2012-07-031-8/+11
| | | | | | | read(2) returns an ssize_t, not an int. We want to compare this value against several unsigned size_ts, so make a local copy. Also cast to int for printing; size_t can be wider than int, but these values should be small.
* Clean up const usage for supported_kdf_alg_idsBen Kaduk2012-07-032-2/+2
| | | | | The previous declaration had redundant consts and missed making the actual pointers stored in the array const.
* Pass empty string instead of NULL to printf-likeBen Kaduk2012-07-031-1/+1
|
* Remove unused variableBen Kaduk2012-07-031-2/+0
|
* Minor cleanups relating to size_t being unsignedBen Kaduk2012-07-032-2/+2
| | | | | | | | | | | In order to use -1 as a sentinel value, we should explicitly cast to make it clear what we are doing. It might be better to use a less convoluted sentinel value such as SIZE_T_MAX, though. Additionally, since size_t is unsigned and at least as wide as an int, a loop with int index variable that compares against a size_t for its termination check could become an infinite loop. Make the loop index size_t for consistency.
* Use consistent types for overflow comparisonBen Kaduk2012-07-031-1/+1
| | | | | | Unsigned long might not be 32-bits, in which case the overflow check fails for a 32-bit kdb_sno_t. Cast from -1 explicitly as a more robust check.
* Avoid unsigned/signed comparison in loop conditionBen Kaduk2012-07-031-2/+1
| | | | | | | The gid_len length is declared as an unsigned int, and loop index 'i' is a signed int. This could manifest as an infinite loop if gid_len is very large. In practice, gid_len should be small, but make 'i' the same type for consistency.