diff options
| author | Ben Kaduk <kaduk@mit.edu> | 2012-08-23 12:38:57 -0400 |
|---|---|---|
| committer | Ben Kaduk <kaduk@mit.edu> | 2012-08-29 16:34:46 -0400 |
| commit | 932866ad41edf830123bdfef927f1314f3100be9 (patch) | |
| tree | 6fe2d49770b0930736293d3db26cee03ee874fdc | |
| parent | 626c4055d65e5f0089b634c9fe4a4f6cad21dece (diff) | |
| download | krb5-932866ad41edf830123bdfef927f1314f3100be9.tar.gz krb5-932866ad41edf830123bdfef927f1314f3100be9.tar.xz krb5-932866ad41edf830123bdfef927f1314f3100be9.zip | |
Do not emit debug printfs under NODEBUG
These printfs spew to the console when command-line utilities
such as 'klist' and 'aklog' are run, reducing usability.
These printfs can also cause application hangs.
On a multiprocessor machine, when PuTTY and the ccapiserver are
running on different CPUs, PuTTY appears to deadlock with three
concurrent threads inside cci_debug_printf().
ticket: 7342 (new)
target_version: 1.10.4
tags: pullup
| -rw-r--r-- | src/ccapi/common/win/cci_os_debugging.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/ccapi/common/win/cci_os_debugging.c b/src/ccapi/common/win/cci_os_debugging.c index de31c7c397..597ac85605 100644 --- a/src/ccapi/common/win/cci_os_debugging.c +++ b/src/ccapi/common/win/cci_os_debugging.c @@ -32,7 +32,9 @@ /* ------------------------------------------------------------------------ */ void cci_os_debug_vprintf (const char *in_format, va_list in_args) { +#ifdef DEBUG printf ( "%s %ld ", timestamp(), GetCurrentThreadId() ); vprintf ( in_format, in_args ); printf ( "\n" ); +#endif } |